Skip to content

Commit 8434259

Browse files
authored
Merge pull request #103 from geniejhang/master
ArrayBuilder is created by factory.
2 parents 41cdeed + b7a30c1 commit 8434259

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

epics-vtype/vtype-json/src/main/java/org/epics/vtype/json/JsonArrays.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ public static List<Instant> toListTimestamp(JsonArray array) {
257257
* @return an array of strings
258258
*/
259259
public static JsonArrayBuilder fromListString(List<String> list) {
260-
JsonArrayBuilder b = Json.createArrayBuilder();
260+
JsonArrayBuilder b = JsonVTypeBuilder.factory.createArrayBuilder();
261261
for (String element : list) {
262262
// TODO: Not clear how to handle nulls. Converting them to empty strings.
263263
if (element == null) {
@@ -275,7 +275,7 @@ public static JsonArrayBuilder fromListString(List<String> list) {
275275
* @return an array
276276
*/
277277
public static JsonArrayBuilder fromListTimestamp(List<Instant> list) {
278-
JsonArrayBuilder b = Json.createArrayBuilder();
278+
JsonArrayBuilder b = JsonVTypeBuilder.factory.createArrayBuilder();
279279
for (Instant element : list) {
280280
if (element == null) {
281281
b.addNull();
@@ -293,7 +293,7 @@ public static JsonArrayBuilder fromListTimestamp(List<Instant> list) {
293293
* @return an array of numbers
294294
*/
295295
public static JsonArrayBuilder fromListNumber(ListNumber list) {
296-
JsonArrayBuilder b = Json.createArrayBuilder();
296+
JsonArrayBuilder b = JsonVTypeBuilder.factory.createArrayBuilder();
297297
if (list instanceof ListInteger || list instanceof ListUShort || list instanceof ListShort || list instanceof ListUByte || list instanceof ListByte) {
298298
for (int i = 0; i < list.size(); i++) {
299299
b.add(list.getInt(i));

epics-vtype/vtype-json/src/main/java/org/epics/vtype/json/JsonVTypeBuilder.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
*/
3535
class JsonVTypeBuilder implements JsonObjectBuilder {
3636

37-
private static final JsonBuilderFactory factory = Json.createBuilderFactory(Collections.emptyMap());
37+
public static final JsonBuilderFactory factory = Json.createBuilderFactory(Collections.emptyMap());
3838
private final JsonObjectBuilder builder = factory.createObjectBuilder();
3939

4040
@Override
@@ -161,7 +161,7 @@ public JsonVTypeBuilder addListString(String string, List<String> ls) {
161161
}
162162

163163
public JsonVTypeBuilder addListColumnType(String string, List<Class<?>> ls) {
164-
JsonArrayBuilder b = Json.createArrayBuilder();
164+
JsonArrayBuilder b = factory.createArrayBuilder();
165165
for (Class<?> element : ls) {
166166
if (element.equals(String.class)) {
167167
b.add("String");
@@ -193,7 +193,7 @@ public JsonVTypeBuilder addListNumber(String string, ListNumber ln) {
193193
}
194194

195195
public JsonVTypeBuilder addListBoolean(String string, ListBoolean lb) {
196-
JsonArrayBuilder b = Json.createArrayBuilder();
196+
JsonArrayBuilder b = factory.createArrayBuilder();
197197
for (int i = 0; i < lb.size(); i++) {
198198
b.add(lb.getBoolean(i));
199199
}

0 commit comments

Comments
 (0)