Skip to content

Commit b6723d0

Browse files
committed
Fix handle_old_cross_variables()
For cross-builds using deprecated WINE and RTEMS variables: - add correct entry to CI_CROSS_TARGETS - print added entry as part of the deprecation warning - log change in CI_CROSS_TARGETS to debug log (see review in #69)
1 parent db7677a commit b6723d0

1 file changed

Lines changed: 28 additions & 8 deletions

File tree

cue.py

Lines changed: 28 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/usr/bin/env python
2-
"""CI build script for Linux/MacOS/Windows on Travis/AppVeyor/GitHub-Actions
2+
"""EPICS CI build script for Linux/MacOS/Windows on Travis/GitLab/AppVeyor/GitHub-Actions
33
"""
44

55
from __future__ import print_function
@@ -793,7 +793,7 @@ def edit_make_file(mode, path, values):
793793
794794
path should be a list, e.g. ["configure", "CONFIG_SITE"]
795795
796-
values should be a dictionnary of values to edit. If the value starts with
796+
values should be a dictionary of values to edit. If the value starts with
797797
a "+" the value will be appended.
798798
799799
Example usage:
@@ -819,20 +819,40 @@ def handle_old_cross_variables():
819819
os.environ["CI_CROSS_TARGETS"] = ""
820820

821821
if "RTEMS" in os.environ:
822+
if 'RTEMS_TARGET' in os.environ:
823+
rtems_target = os.environ['RTEMS_TARGET']
824+
elif os.path.exists(os.path.join(places['EPICS_BASE'], 'configure', 'os',
825+
'CONFIG.Common.RTEMS-pc386-qemu')):
826+
# Base 3.15 doesn't have -qemu target architecture
827+
rtems_target = 'RTEMS-pc386-qemu'
828+
else:
829+
rtems_target = 'RTEMS-pc386'
830+
831+
new_cross_target = ":" + rtems_target + "@" + os.environ["RTEMS"]
832+
os.environ["CI_CROSS_TARGETS"] += new_cross_target
833+
822834
print(
823-
"{0}WARNING: deprecated RTEMS environment variable was specified, please use CI_CROSS_TARGETS{1}".format(
824-
ANSI_RED, ANSI_RESET
835+
"{0}WARNING: deprecated RTEMS environment variable was specified." \
836+
" Please add '{1}' to CI_CROSS_TARGETS instead.{2}".format(
837+
ANSI_RED, new_cross_target, ANSI_RESET
825838
)
826839
)
827-
os.environ["CI_CROSS_TARGETS"] += ":RTEMS@" + os.environ["RTEMS"]
840+
logger.debug('Replaced deprecated RTEMS target with new entry in CI_CROSS_TARGETS: %s', new_cross_target)
828841

829842
if "WINE" in os.environ:
843+
if os.environ['WINE'] == '32':
844+
new_cross_target = ":win32-x86-mingw"
845+
else:
846+
new_cross_target = ":windows-x64-mingw"
847+
os.environ["CI_CROSS_TARGETS"] += new_cross_target
848+
830849
print(
831-
"{0}WARNING: deprecated WINE environment variable was specified, please use CI_CROSS_TARGETS{1}".format(
832-
ANSI_RED, ANSI_RESET
850+
"{0}WARNING: deprecated WINE environment variable was specified." \
851+
" Please add '{1}' to CI_CROSS_TARGETS instead.{2}".format(
852+
ANSI_RED, new_cross_target, ANSI_RESET
833853
)
834854
)
835-
os.environ["CI_CROSS_TARGETS"] += ":WINE@" + os.environ["WINE"]
855+
logger.debug('Replaced deprecated WINE target with new entry in CI_CROSS_TARGETS: %s', new_cross_target)
836856

837857

838858
def prepare_cross_compilation(cross_target_info):

0 commit comments

Comments
 (0)