Skip to content

Commit 12780d7

Browse files
committed
Fixed compilation fail CContextMenu.cpp(255,20): error C2039: 'BuildMenuTree': is not a member of 'CContextMenu' for build run https://github.com/end2endzone/ShellAnything/actions/runs/10540285814/job/29204765722.
1 parent 08d5c17 commit 12780d7

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/shellextension/CContextMenu.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ void CContextMenu::BuildSubMenuTree(HMENU hMenu, shellanything::Menu* menu, UINT
252252
SA_VERBOSE_LOG(INFO) << "Build of menu : " << menu_unique_id_desc << " completed. result=" << result << ", insert.pos=" << ra::strings::Format("%03d", insert_pos) << ".";
253253
}
254254

255-
void CContextMenu::BuildMenuTree(HMENU hMenu)
255+
void CContextMenu::BuildTopMenuTree(HMENU hMenu)
256256
{
257257
//Bitmap ressources must be properly destroyed.
258258
//When a menu (HMENU handle) is destroyed using win32 DestroyMenu() function, it also destroy the child menus:
@@ -264,7 +264,7 @@ void CContextMenu::BuildMenuTree(HMENU hMenu)
264264
//https://www.codeproject.com/Questions/1228261/Windows-shell-extension
265265
//
266266
//To prevent running out of bitmap ressource we use the shellanything::BitmapCache class.
267-
//Each bitmap is identified as 'used' in CContextMenu::BuildMenuTree() with 'm_BitmapCache.FindHandle()'.
267+
//Each bitmap is identified as 'used' in CContextMenu::BuildSubMenuTree() with 'm_BitmapCache.FindHandle()'.
268268
//Every 5 times the shell extension popup is displayed, we look for 'unused' bitmap and delete them.
269269
//
270270

src/tests/TestIcon.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ namespace shellanything
107107
TEST_F(TestIcon, testResolveFileExtensionIcon)
108108
{
109109
Icon icon;
110-
icon.SetFileExtension("txt");
110+
icon.SetFileExtension("html");
111111

112112
//act
113113
icon.ResolveFileExtensionIcon();

0 commit comments

Comments
 (0)