Skip to content

Commit 4ce5ee6

Browse files
authored
Merge pull request #92 from embulk/disable-tests-Asia-Choibalsan
Disable tests with Asia/Choibalsan in older dates
2 parents 87c9ffd + e71dd9d commit 4ce5ee6

1 file changed

Lines changed: 21 additions & 2 deletions

File tree

src/jrubyTest/java/org/embulk/util/rubytime/TestRubyDateTimeFormatterFormatWithJRuby.java

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,27 @@ private static Stream<OffsetDateTime> provideOffsetDateTime() {
120120
ZonedDateTime.of(1996, 7, 3, 2, 0, 45, 0, ZoneId.of("America/Santiago")),
121121
ZonedDateTime.of(1996, 1, 3, 2, 0, 45, 0, ZoneId.of("Asia/Baku")),
122122
ZonedDateTime.of(1996, 7, 3, 2, 0, 45, 0, ZoneId.of("Asia/Baku")),
123-
ZonedDateTime.of(1996, 1, 3, 2, 0, 45, 0, ZoneId.of("Asia/Choibalsan")),
124-
ZonedDateTime.of(1996, 7, 3, 2, 0, 45, 0, ZoneId.of("Asia/Choibalsan")),
123+
124+
// The timezone of Asia/Choibalsan was updated retroactively (like "backdate").
125+
// https://github.com/eggert/tz/commit/7eb5bf887927e35079e5cc12e2252819a7c47bb0
126+
//
127+
// The tzdb had believed :
128+
// "Asia/Choibalsan had been in UTC+9 until 2008-03-31"
129+
//
130+
// However, the tzdb was updated retroactively between 2024a and 2024b so that :
131+
// "Asia/Choibalsan has been in UTC+8 in all the time since 1979"
132+
//
133+
// Then, the interpretation of "1996-01-03T02:00:45 [Asia/Choibalsan]" has changed :
134+
// - Before: 1996-01-03T02:00:45 +09:00 [Asia/Choibalsan]
135+
// - After: 1996-01-03T02:00:45 +08:00 [Asia/Choibalsan]
136+
//
137+
// It'd be discussed whether the behavior of embulk-util-rubytime should change or not.
138+
// Until then, we disable the test cases about Asia/Choibalsan, and test it with later date.
139+
// ZonedDateTime.of(1996, 1, 3, 2, 0, 45, 0, ZoneId.of("Asia/Choibalsan")),
140+
// ZonedDateTime.of(1996, 7, 3, 2, 0, 45, 0, ZoneId.of("Asia/Choibalsan")),
141+
ZonedDateTime.of(2009, 1, 3, 2, 0, 45, 0, ZoneId.of("Asia/Choibalsan")),
142+
ZonedDateTime.of(2009, 7, 3, 2, 0, 45, 0, ZoneId.of("Asia/Choibalsan")),
143+
125144
ZonedDateTime.of(1996, 1, 3, 2, 0, 45, 0, ZoneId.of("Asia/Hovd")),
126145
ZonedDateTime.of(1996, 7, 3, 2, 0, 45, 0, ZoneId.of("Asia/Hovd")),
127146
ZonedDateTime.of(1996, 1, 3, 2, 0, 45, 0, ZoneId.of("Asia/Istanbul")),

0 commit comments

Comments
 (0)