From 5220e0cacbeb4b098c311b1c6db8a8649d115ec7 Mon Sep 17 00:00:00 2001 From: Edward Viaene Date: Fri, 20 Nov 2026 14:28:06 -0600 Subject: [PATCH] MCP e2e: the current-loop readback skips on every quad-DAC pod (an analog module too, not only v3r2) The firmware drives the 4-20 mA output from the quad DAC on analog v3r2 and on any board with an analog module (dac_quad_for_board); the 5 V loopback does not see that channel, so the test failed on a v3 board with a module (benchpod-c2f662, on 3.10.8 and on 4.0.0 alike). Co-Authored-By: Claude Opus 5.5 --- packages/embeddedci-mcp/tests/test_e2e_mcp.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/embeddedci-mcp/tests/test_e2e_mcp.py b/packages/embeddedci-mcp/tests/test_e2e_mcp.py index 787af07..a980339 100644 --- a/packages/embeddedci-mcp/tests/test_e2e_mcp.py +++ b/packages/embeddedci-mcp/tests/test_e2e_mcp.py @@ -115,7 +115,11 @@ def test_current_loop_terminals(connected): assert rng["current"] is None and 0.0039 < rng["min_current"] < 0.0042 < 0.0199 < rng["max_current"] held = call("current_out", current=0.012) assert abs(held["current"] - 0.012) < 2e-6 - if connected["firmware"].get("board_rev") == "v3r2": + # The quad DAC (analog v3r2, or any board with an analog module: firmware dac_quad_for_board) + # drives the 4-20 mA output from its own channel, which the 5 V loopback does not see. + fw = connected["firmware"] + module = fw.get("module") if isinstance(fw.get("module"), dict) else {} + if fw.get("board_rev") == "v3r2" or (module.get("present") and module.get("analog")): pytest.skip("quad DAC: the 5 V loopback does not see the 4-20 mA output; needs the J9 fixture") want = (0.012 - rng["min_current"]) / (rng["max_current"] - rng["min_current"]) * 65535 / 65536 * 4.99 time.sleep(0.1)