adding suggested fix for decimal. Pull request #24

Author: mjaric

lib/tds/types.ex

@@ -458,14 +458,10 @@ defmodule Tds.Types do
     d_ctx = Decimal.get_context
     d_ctx = %{d_ctx | precision: precision}
     Decimal.set_context d_ctx
-    d = Decimal.new pow10(value,(scale * -1))
-    value = pow10(d.coef, d.exp)
-    value =
     case sign do
-      0 -> value * -1
-      _ -> value
+      0 -> Decimal.new(-1, value, (scale * -1))
+      _ -> Decimal.new( 1, value, (scale * -1))
     end
-    Decimal.new value
   end
 
   def decode_char(_collation, <<data::binary>>) do

lib/tds/utils.ex

@@ -77,24 +77,24 @@ defmodule Tds.Utils do
  #   Connection.next(%{s | statement: "", queue: queue, state: :ready})
  # end
 
-  def pow10(num,0), do: num
-  def pow10(num,pow) when pow > 0 do
-    pow10(10*num, pow - 1)
-  end
-
-  def pow10(num,pow) when pow < 0 do
-    pow10(num/10, pow + 1)
-  end
-
-  def pow(_, 0), do: 1
-  def pow(a, 1), do: a
-
-  def pow(a, n) when rem(n, 2) === 0 do
-    tmp = pow(a, div(n, 2))
-    tmp * tmp
-  end
-
-  def pow(a, n) do
-    a * pow(a, n-1)
-  end
+  # def pow10(num,0), do: num
+  # def pow10(num,pow) when pow > 0 do
+  #   pow10(10*num, pow - 1)
+  # end
+
+  # def pow10(num,pow) when pow < 0 do
+  #   pow10(num/10, pow + 1)
+  # end
+
+  # def pow(_, 0), do: 1
+  # def pow(a, 1), do: a
+
+  # def pow(a, n) when rem(n, 2) === 0 do
+  #   tmp = pow(a, div(n, 2))
+  #   tmp * tmp
+  # end
+
+  # def pow(a, n) do
+  #   a * pow(a, n-1)
+  # end
 end

test/test_helper.exs

@@ -32,13 +32,10 @@ defmodule Tds.TestHelper do
       "-P", params[:password],
       "-S", params[:hostname],
       "-Q", ~s(#{sql}) | args]
-    |> IO.inspect()
     System.cmd "sqlcmd", args
   end
 end
 
 
 Application.get_env(:tds, :opts)
-
-|> IO.inspect()
-|> Tds.TestHelper.sqlcmd "IF NOT EXISTS(SELECT * FROM sys.databases where name = 'test') BEGIN CREATE DATABASE [test]; END;"
+|> Tds.TestHelper.sqlcmd("IF NOT EXISTS(SELECT * FROM sys.databases where name = 'test') BEGIN CREATE DATABASE [test]; END;")