Skip to content

Commit dcf596f

Browse files
authored
Add returning to delete (#559)
1 parent e9515f2 commit dcf596f

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

lib/ecto/adapters/sql.ex

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -251,10 +251,10 @@ defmodule Ecto.Adapters.SQL do
251251
end
252252

253253
@impl true
254-
def delete(adapter_meta, schema_meta, params, opts) do
254+
def delete(adapter_meta, schema_meta, params, returning, opts) do
255255
%{source: source, prefix: prefix} = schema_meta
256256
filter_values = Keyword.values(params)
257-
sql = @conn.delete(prefix, source, params, [])
257+
sql = @conn.delete(prefix, source, params, returning)
258258

259259
Ecto.Adapters.SQL.struct(
260260
adapter_meta,
@@ -265,7 +265,7 @@ defmodule Ecto.Adapters.SQL do
265265
params,
266266
filter_values,
267267
:raise,
268-
[],
268+
returning,
269269
opts
270270
)
271271
end
@@ -298,7 +298,7 @@ defmodule Ecto.Adapters.SQL do
298298
execute: 5,
299299
insert: 6,
300300
update: 6,
301-
delete: 4,
301+
delete: 5,
302302
insert_all: 8,
303303
execute_ddl: 3,
304304
loaders: 2,

mix.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"decimal": {:hex, :decimal, "2.1.1", "5611dca5d4b2c3dd497dec8f68751f1f1a54755e8ed2a966c2633cf885973ad6", [:mix], [], "hexpm", "53cfe5f497ed0e7771ae1a475575603d77425099ba5faef9394932b35020ffcc"},
66
"deep_merge": {:hex, :deep_merge, "0.2.0", "c1050fa2edf4848b9f556fba1b75afc66608a4219659e3311d9c9427b5b680b3", [:mix], [], "hexpm", "e3bf435a54ed27b0ba3a01eb117ae017988804e136edcbe8a6a14c310daa966e"},
77
"earmark_parser": {:hex, :earmark_parser, "1.4.33", "3c3fd9673bb5dcc9edc28dd90f50c87ce506d1f71b70e3de69aa8154bc695d44", [:mix], [], "hexpm", "2d526833729b59b9fdb85785078697c72ac5e5066350663e5be6a1182da61b8f"},
8-
"ecto": {:git, "https://github.com/elixir-ecto/ecto.git", "743ce048cfee927e20dba72f37d58eb52c3535a9", []},
8+
"ecto": {:git, "https://github.com/elixir-ecto/ecto.git", "d28ed617128734cf2cc52d371e8664993d61a260", []},
99
"ex_doc": {:hex, :ex_doc, "0.30.5", "aa6da96a5c23389d7dc7c381eba862710e108cee9cfdc629b7ec021313900e9e", [:mix], [{:earmark_parser, "~> 1.4.31", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_elixir, "~> 0.14", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1", [hex: :makeup_erlang, repo: "hexpm", optional: false]}], "hexpm", "88a1e115dcb91cefeef7e22df4a6ebbe4634fbf98b38adcbc25c9607d6d9d8e6"},
1010
"jason": {:hex, :jason, "1.4.0", "e855647bc964a44e2f67df589ccf49105ae039d4179db7f6271dfd3843dc27e6", [:mix], [{:decimal, "~> 1.0 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "79a3791085b2a0f743ca04cec0f7be26443738779d09302e01318f97bdb82121"},
1111
"makeup": {:hex, :makeup, "1.1.0", "6b67c8bc2882a6b6a445859952a602afc1a41c2e08379ca057c0f525366fc3ca", [:mix], [{:nimble_parsec, "~> 1.2.2 or ~> 1.3", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "0a45ed501f4a8897f580eabf99a2e5234ea3e75a4373c8a52824f6e873be57a6"},

0 commit comments

Comments
 (0)