MyXQL: quote locks (#443)

Closes #441.

Author: matiasgarciaisaia

Earthfile

@@ -99,7 +99,7 @@ integration-test-mysql:
         --pull "mysql:$MYSQL"
         RUN set -e; \
             timeout=$(expr $(date +%s) + 30); \
-            docker run --name mysql --network=host -d -e MYSQL_ROOT_PASSWORD=root "mysql:$MYSQL"; \
+            docker run --name mysql --network=host -d -e MYSQL_ROOT_PASSWORD=root "mysql:$MYSQL" --sql_mode="ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION,ANSI_QUOTES"; \
             # wait for mysql to start
             while ! mysqladmin ping --host=127.0.0.1 --port=3306 --protocol=TCP --silent; do \
                 test "$(date +%s)" -le "$timeout" || (echo "timed out waiting for mysql"; exit 1); \

integration_test/myxql/migrations_test.exs

@@ -16,8 +16,8 @@ defmodule Ecto.Integration.MigrationsTest do
   end
 
   describe "Migrator" do
-    @get_lock_command ~s[SELECT GET_LOCK("ecto_Ecto.Integration.PoolRepo", -1)]
-    @release_lock_command ~s[SELECT RELEASE_LOCK("ecto_Ecto.Integration.PoolRepo")]
+    @get_lock_command ~s[SELECT GET_LOCK('ecto_Ecto.Integration.PoolRepo', -1)]
+    @release_lock_command ~s[SELECT RELEASE_LOCK('ecto_Ecto.Integration.PoolRepo')]
     @create_table_sql ~s[CREATE TABLE IF NOT EXISTS `log_mode_table`]
     @create_table_log "create table if not exists log_mode_table"
     @drop_table_sql ~s[DROP TABLE IF EXISTS `log_mode_table`]

integration_test/sql/migration.exs

@@ -515,7 +515,7 @@ defmodule Ecto.Integration.MigrationTest do
     assert [0] ==
            PoolRepo.all from p in "alter_col_migration", select: p.from_no_default_to_default
 
-    query = "INSERT INTO alter_col_migration (from_not_null_to_null) VALUES ('foo')"
+    query = "INSERT INTO `alter_col_migration` (\"from_not_null_to_null\") VALUES ('foo')"
     assert catch_error(PoolRepo.query!(query))
 
     :ok = down(PoolRepo, num, AlterColumnMigration, log: false)

lib/ecto/adapters/myxql.ex

@@ -248,7 +248,7 @@ defmodule Ecto.Adapters.MyXQL do
 
     {:ok, result} =
       transaction(meta, opts, fn ->
-        lock_name = "\"ecto_#{inspect(repo)}\""
+        lock_name = "\'ecto_#{inspect(repo)}\'"
 
         try do
           {:ok, _} = Ecto.Adapters.SQL.query(meta, "SELECT GET_LOCK(#{lock_name}, -1)", [], opts)