Skip to content

Commit 6e6c26a

Browse files
committed
Remove unused ExpandableComposite styling in IDEApplication
Neither ChooseWorkspaceDialog nor ChooseWorkspaceWithSettingsDialog use ExpandableComposite, so the early dark-theme styling branch in applyStylesRecursive is dead code. Drop the ExpandableComposite handling, the import, and the org.eclipse.ui.forms bundle dependency, which is no longer needed.
1 parent 86c2766 commit 6e6c26a

2 files changed

Lines changed: 0 additions & 7 deletions

File tree

bundles/org.eclipse.ui.ide.application/META-INF/MANIFEST.MF

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ Require-Bundle: org.eclipse.ui.ide;bundle-version="[3.21.0,4.0.0)",
1818
org.eclipse.e4.core.di.extensions,
1919
org.eclipse.e4.core.services;bundle-version="2.4.0",
2020
org.eclipse.e4.core.contexts;bundle-version="[1.12.0,2.0.0)",
21-
org.eclipse.ui.forms,
2221
org.eclipse.urischeme;bundle-version="[1.3.0,2.0.0)",
2322
org.eclipse.e4.ui.di
2423
Export-Package: org.eclipse.ui.internal.ide.application;x-internal:=true,

bundles/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEApplication.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@
6666
import org.eclipse.swt.widgets.Shell;
6767
import org.eclipse.ui.IWorkbench;
6868
import org.eclipse.ui.PlatformUI;
69-
import org.eclipse.ui.forms.widgets.ExpandableComposite;
7069
import org.eclipse.ui.internal.Workbench;
7170
import org.eclipse.ui.internal.WorkbenchPlugin;
7271
import org.eclipse.ui.internal.WorkspaceLock;
@@ -953,11 +952,6 @@ private void applyStylesRecursive(Control control, Color bg, Color fg, Color lin
953952

954953
}
955954

956-
if (control instanceof ExpandableComposite expandable) {
957-
expandable.setTitleBarForeground(fg);
958-
expandable.setToggleColor(fg);
959-
expandable.setActiveToggleColor(fg);
960-
}
961955
if (control instanceof Composite composite) {
962956
for (Control child : composite.getChildren()) {
963957
applyStylesRecursive(child, bg, fg, linkColor);

0 commit comments

Comments
 (0)