Update Color constructors to modern signature

Follows eclipse-platform/eclipse.platform.swt#3232
by removing the Device/Display argument from Color constructors.

Author: vogella

bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/helpers/CSSSWTColorHelper.java

@@ -54,7 +54,7 @@ public class CSSSWTColorHelper {
 
 	public static Color getSWTColor(RGBColor rgbColor, Display display) {
 		RGBA rgb = getRGBA(rgbColor);
-		return new Color(display, rgb);
+		return new Color(rgb);
 	}
 
 	public static Color getSWTColor(CSSValue value, Display display) {
@@ -64,7 +64,7 @@ public static Color getSWTColor(CSSValue value, Display display) {
 		Color color = display.getSystemColor(SWT.COLOR_BLACK);
 		RGBA rgba = getRGBA((CSSPrimitiveValue) value, display);
 		if (rgba != null) {
-			color = new Color(display, rgba.rgb.red, rgba.rgb.green, rgba.rgb.blue, rgba.alpha);
+			color = new Color(rgba.rgb.red, rgba.rgb.green, rgba.rgb.blue, rgba.alpha);
 		}
 		return color;
 	}

bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/properties/GradientBackgroundListener.java

@@ -157,10 +157,10 @@ public void handleEvent(Event event) {
 				List<Color> colors = new ArrayList<>();
 				for (Object rgbObj : grad.getRGBs()) {
 					if (rgbObj instanceof RGBA rgba) {
-						Color color = new Color(control.getDisplay(), rgba);
+						Color color = new Color(rgba);
 						colors.add(color);
 					} else if (rgbObj instanceof RGB rgb) {
-						Color color = new Color(control.getDisplay(), rgb);
+						Color color = new Color(rgb);
 						colors.add(color);
 					}
 				}

bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/CTabRendering.java

@@ -411,7 +411,7 @@ void drawSelectedTab(int itemIndex, GC gc, Rectangle bounds) {
 		if (!active && !onBottom) {
 			RGB blendColor = gc.getDevice().getSystemColor(SWT.COLOR_WIDGET_LIGHT_SHADOW).getRGB();
 			RGB topGradient = blend(blendColor, tabOutlineColor.getRGB(), 40);
-			gradientLineTop = new Color(gc.getDevice(), topGradient);
+			gradientLineTop = new Color(topGradient);
 			foregroundPattern = new Pattern(gc.getDevice(), 0, 0, 0, bounds.height + 1, gradientLineTop,
 					gc.getDevice().getSystemColor(SWT.COLOR_WHITE));
 			gc.setForegroundPattern(foregroundPattern);

bundles/org.eclipse.e4.ui.workbench.swt/src/org/eclipse/e4/ui/internal/workbench/swt/CSSRenderingUtils.java

@@ -166,7 +166,7 @@ private Image rotateImage(Display display, Image image, Integer[] frameInts) {
 		Image rotatedImage = new Image(display, imageData);
 		GC gc = new GC(rotatedImage);
 		RGB rgb = new RGB(0x7d, 0, 0);
-		Color offRed = new Color(display, rgb);
+		Color offRed = new Color(rgb);
 		gc.setBackground(offRed);
 		gc.fillRectangle(0, 0, bounds.height, bounds.width);
 		Transform t = new Transform(display);

bundles/org.eclipse.jface.text/projection/org/eclipse/jface/text/source/projection/SourceViewerInformationControl.java

@@ -168,7 +168,7 @@ public void keyReleased(KeyEvent e) {}
 			GridData gd2= new GridData(GridData.FILL_VERTICAL | GridData.FILL_HORIZONTAL | GridData.HORIZONTAL_ALIGN_BEGINNING | GridData.VERTICAL_ALIGN_BEGINNING);
 			fStatusField.setLayoutData(gd2);
 
-			Color statusTextForegroundColor= new Color(fStatusField.getDisplay(),
+			Color statusTextForegroundColor= new Color(
 					blend(display.getSystemColor(SWT.COLOR_INFO_BACKGROUND).getRGB(), display.getSystemColor(SWT.COLOR_INFO_FOREGROUND).getRGB(), 0.56f));
 			fStatusField.setForeground(statusTextForegroundColor);
 

bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/AbstractInformationControl.java

@@ -655,7 +655,7 @@ private void setStatusLabelColors(Color foreground, Color background) {
 		if (foreground == null || background == null) {
 			return;
 		}
-		Color statusLabelForeground= new Color(fStatusLabel.getDisplay(), Colors.blend(background.getRGB(), foreground.getRGB(), 0.56f));
+		Color statusLabelForeground= new Color(Colors.blend(background.getRGB(), foreground.getRGB(), 0.56f));
 		fStatusLabel.setForeground(statusLabelForeground);
 		fStatusLabel.setBackground(background);
 	}

bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/hyperlink/DefaultHyperlinkPresenter.java

@@ -180,7 +180,7 @@ public void install(ITextViewer textViewer) {
 		} else if (fRGB != null) {
 			StyledText text= fTextViewer.getTextWidget();
 			if (text != null && !text.isDisposed()) {
-				fColor= new Color(text.getDisplay(), fRGB);
+				fColor= new Color(fRGB);
 			}
 		}
 	}
@@ -349,7 +349,7 @@ private Color createColorFromPreferenceStore() {
 			}
 
 			if (rgb != null) {
-				return new Color(textWidget.getDisplay(), rgb);
+				return new Color(rgb);
 			}
 		}
 
@@ -372,3 +372,6 @@ public void propertyChange(PropertyChangeEvent event) {
 		}
 	}
 }
+
+	}
+}

bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/PopupDialog.java

@@ -876,7 +876,6 @@ protected Control createInfoTextArea(Composite parent) {
 
 		GridDataFactory.fillDefaults().grab(true, false).align(SWT.FILL,
 				SWT.BEGINNING).applyTo(infoLabel);
-		Display display = parent.getDisplay();
 
 		Color backgroundColor = getBackground();
 		if (backgroundColor == null) {
@@ -886,7 +885,7 @@ protected Control createInfoTextArea(Composite parent) {
 		if (foregroundColor == null) {
 			foregroundColor = getDefaultForeground();
 		}
-		Color infoColor = new Color(display, blend(
+		Color infoColor = new Color(blend(
 				backgroundColor.getRGB(), foregroundColor.getRGB(),
 				0.56f));
 

bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/TitleAreaDialog.java

@@ -222,7 +222,7 @@ private Control createTitleArea(Composite parent) {
 		Color background;
 		Color foreground;
 		if (titleAreaRGB != null) {
-			titleAreaColor = new Color(display, titleAreaRGB);
+			titleAreaColor = new Color(titleAreaRGB);
 			background = titleAreaColor;
 			foreground = null;
 		} else {

bundles/org.eclipse.jface/src/org/eclipse/jface/fieldassist/FieldAssistColors.java

@@ -141,7 +141,7 @@ public static Color getRequiredFieldBackgroundColor(Control control) {
 		destBlue += (src.getBlue() - destBlue) * alpha / 0xFF;
 
 		// create the color
-		Color color = new Color(display, destRed, destGreen, destBlue);
+		Color color = new Color(destRed, destGreen, destBlue);
 		// record the color in a map using the original color as the key
 		requiredFieldColorMap.put(dest, color);
 		// If we have never created a color on this display before, install