Skip to content

Commit 2d4d435

Browse files
committed
[Gtk4] Fix Browser.setText
Disable hardware-acceleration-policy on Gtk 4.x (it is done for Gtk 3.x already) as first frame is never drawn when using accelerated compositing (GPU path). The DOM loads, signals fire, but the view stays blank. Different value compared to Gtk 3 is due to the fact that the setting no longer has always/ondemand/never but just always/never on Gtk 4.
1 parent 8a3980d commit 2d4d435

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

  • bundles/org.eclipse.swt/Eclipse SWT WebKit/gtk/org/eclipse/swt/browser

bundles/org.eclipse.swt/Eclipse SWT WebKit/gtk/org/eclipse/swt/browser/WebKit.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -786,7 +786,11 @@ public void create (Composite parent, int style) {
786786
OS.g_object_set (settings, WebKitGTK.enable_developer_extras, 1, 0);
787787
//disable hardware acceleration due to https://bugs.webkit.org/show_bug.cgi?id=239429#c11
788788
//even evolution ended up doing the same https://gitlab.gnome.org/GNOME/evolution/-/commit/eb62ccaa28bbbca7668913ce7d8056a6d75f9b05
789-
if (!GTK.GTK4) {
789+
if (GTK.GTK4) {
790+
// "1" is "never" in webkitgtk6 https://webkitgtk.org/reference/webkitgtk/stable/enum.HardwareAccelerationPolicy.html#never
791+
OS.g_object_set (settings, WebKitGTK.hardware_acceleration_policy, 1, 0);
792+
} else {
793+
// "2" is "never" in webkitgtk4 https://webkitgtk.org/reference/webkit2gtk/stable/enum.HardwareAccelerationPolicy.html#never
790794
OS.g_object_set (settings, WebKitGTK.hardware_acceleration_policy, 2, 0);
791795
}
792796

0 commit comments

Comments
 (0)