Skip to content

Commit 057b24c

Browse files
arunjose696akoch-yatta
authored andcommitted
Remove redundant GC.dispose() calls for Image
This minor refactoring eliminates unnecessary calls to GC.dispose() since disposing an Image automatically disposes its associated GC. There is no visual impact from this change.
1 parent 11c1f19 commit 057b24c

2 files changed

Lines changed: 0 additions & 2 deletions

File tree

bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2831,7 +2831,6 @@ private ImageData loadImageData(ZoomContext zoomContext) {
28312831
drawer.postProcess(imageData);
28322832
return adaptImageDataIfDisabledOrGray(imageData);
28332833
} finally {
2834-
gc.dispose();
28352834
image.dispose();
28362835
}
28372836
}

bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Composite.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1635,7 +1635,6 @@ LRESULT WM_PAINT (long wParam, long lParam) {
16351635
GCData gcData = gc.getGCData ();
16361636
if (gcData.focusDrawn && !isDisposed ()) updateUIState ();
16371637
}
1638-
gc.dispose();
16391638
if (!isDisposed ()) {
16401639
paintGC.drawImage (image, DPIUtil.pixelToPoint(ps.left, zoom), DPIUtil.pixelToPoint(ps.top, zoom));
16411640
}

0 commit comments

Comments
 (0)