Skip to content

Commit cf020b3

Browse files
committed
improve version check, prevent false positives by adding single quotes into the search term
1 parent 0d4aef7 commit cf020b3

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

.github/workflows/create-release-branch.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
- name: Check if version already exists as package
3939
id: check-version-existence
4040
run: |
41-
if [ -n "$( npm view @eccenca/gui-elements versions | grep ${{ steps.create-version.outputs.version }} )" ] ; then echo "Stop: v${{ steps.create-version.outputs.version }} is already published!" && false; else echo "Continue: v${{ steps.create-version.outputs.version }} is not published."; fi
41+
if [ -n "$( npm view @eccenca/gui-elements versions | grep \'${{ steps.create-version.outputs.version }}\' )" ] ; then echo "Stop: v${{ steps.create-version.outputs.version }} is already published!" && false; else echo "Continue: v${{ steps.create-version.outputs.version }} is not published."; fi
4242
- name: Create release branch
4343
id: create-branch
4444
run: |

.github/workflows/publish-featurefix-prerelease.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ jobs:
4848
preid=$(echo ${{ steps.branch-name.outputs.current_branch }} | tr '[:upper:]' '[:lower:]' | sed 's=[^[:alnum:][:space:]"]==g')
4949
publishedversions=$(npm view @eccenca/gui-elements versions)
5050
yarn version --no-git-tag-version --new-version $(node -p -e "require('./package.json').version.split('-').shift()")-$preid.0
51-
while [ -n "$( echo $publishedversions | grep $(node -p -e "require('./package.json').version") )" ] ; do yarn version --no-git-tag-version --preid "$preid" --prerelease ; done
51+
while [ -n "$( echo $publishedversions | grep \'$(node -p -e "require('./package.json').version")\' )" ] ; do yarn version --no-git-tag-version --preid "$preid" --prerelease ; done
5252
- name: Get version
5353
id: package-version
5454
run: echo "version=$(node -p -e "require('./package.json').version")" >> $GITHUB_OUTPUT

.github/workflows/publish-final-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ jobs:
5050
- name: Check if version already exists as package
5151
id: check-version-existence
5252
run: |
53-
if [ -n "$( npm view @eccenca/gui-elements versions | grep ${{ steps.package-version.outputs.version }} )" ] ; then echo "Stop: v${{ steps.package-version.outputs.version }} is already published!" && false; else echo "Continue: v${{ steps.package-version.outputs.version }} is not published."; fi
53+
if [ -n "$( npm view @eccenca/gui-elements versions | grep \'${{ steps.package-version.outputs.version }}\' )" ] ; then echo "Stop: v${{ steps.package-version.outputs.version }} is already published!" && false; else echo "Continue: v${{ steps.package-version.outputs.version }} is not published."; fi
5454
- name: Update version in repository
5555
run: |
5656
yarn version --no-git-tag-version --new-version ${{ steps.package-version.outputs.version }}

.github/workflows/publish-release-candidate.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
preid="rc"
4646
publishedversions=$(npm view @eccenca/gui-elements versions)
4747
yarn version --no-git-tag-version --new-version $(node -p -e "require('./package.json').version.split('-').shift()")-$preid.0
48-
while [ -n "$( echo $publishedversions | grep $(node -p -e "require('./package.json').version") )" ] ; do yarn version --no-git-tag-version --preid "$preid" --prerelease ; done
48+
while [ -n "$( echo $publishedversions | grep \'$(node -p -e "require('./package.json').version")\' )" ] ; do yarn version --no-git-tag-version --preid "$preid" --prerelease ; done
4949
- name: Get version
5050
id: package-version
5151
run: echo "version=$(node -p -e "require('./package.json').version")" >> $GITHUB_OUTPUT

0 commit comments

Comments
 (0)