Skip to content

Commit cb5b504

Browse files
committed
fix imports for storybook to prevent circular dpendencies
1 parent 6205dcf commit cb5b504

7 files changed

Lines changed: 21 additions & 33 deletions

File tree

src/cmem/ActivityControl/ActivityControlWidget.stories.tsx

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,9 @@ import { OverlaysProvider } from "@blueprintjs/core";
44
import { Meta, StoryFn } from "@storybook/react";
55

66
import { helpersArgTypes } from "../../../.storybook/helpers";
7-
import {
8-
ActivityControlWidget,
9-
ActivityControlWidgetAction,
10-
IconButton,
11-
SimpleDialog,
12-
Tag,
13-
TagList,
14-
} from "../../../index";
7+
import { IconButton, SimpleDialog, Tag, TagList } from "../../components";
8+
9+
import { ActivityControlWidget, ActivityControlWidgetAction } from "./ActivityControlWidget";
1510

1611
export default {
1712
title: "Cmem/ActivityControlWidget",

src/cmem/ActivityControl/ActivityControlWidget.tsx

Lines changed: 10 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,5 @@
11
import React from "react";
22

3-
import { ValidIconName } from "../../components/Icon/canonicalIconNames";
4-
import { IconProps } from "../../components/Icon/Icon";
5-
import { TestIconProps } from "../../components/Icon/TestIcon";
6-
import { TestableComponent } from "../../components/interfaces";
7-
import { ProgressBarProps } from "../../components/ProgressBar/ProgressBar";
8-
import { SpinnerProps } from "../../components/Spinner/Spinner";
9-
import { CLASSPREFIX as eccgui } from "../../configuration/constants";
103
import {
114
Card,
125
ContextMenu,
@@ -21,7 +14,14 @@ import {
2114
ProgressBar,
2215
Spinner,
2316
Tooltip,
24-
} from "../../index";
17+
} from "../../components";
18+
import { ValidIconName } from "../../components/Icon/canonicalIconNames";
19+
import { IconProps } from "../../components/Icon/Icon";
20+
import { TestIconProps } from "../../components/Icon/TestIcon";
21+
import { TestableComponent } from "../../components/interfaces";
22+
import { ProgressBarProps } from "../../components/ProgressBar/ProgressBar";
23+
import { SpinnerProps } from "../../components/Spinner/Spinner";
24+
import { CLASSPREFIX as eccgui } from "../../configuration/constants";
2525

2626
export interface ActivityControlWidgetProps extends TestableComponent {
2727
/**
@@ -212,11 +212,7 @@ export function ActivityControlWidget(props: ActivityControlWidgetProps) {
212212
activityActions.map((action, idx) => {
213213
return (
214214
<IconButton
215-
key={
216-
typeof action.icon === "string"
217-
? action.icon
218-
: action["data-test-id"] ?? action["data-testid"] ?? idx
219-
}
215+
key={idx}
220216
data-test-id={action["data-test-id"]}
221217
data-testid={action["data-testid"]}
222218
name={action.icon}
@@ -241,11 +237,7 @@ export function ActivityControlWidget(props: ActivityControlWidgetProps) {
241237
return (
242238
<MenuItem
243239
icon={menuAction.icon}
244-
key={
245-
typeof menuAction.icon === "string"
246-
? menuAction.icon
247-
: menuAction["data-test-id"] ?? idx
248-
}
240+
key={idx}
249241
onClick={menuAction.action}
250242
text={menuAction.tooltip}
251243
/>

src/components/Badge/Badge.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { LogoReact } from "@carbon/icons-react";
33
import { Meta, StoryFn } from "@storybook/react";
44

55
import { helpersArgTypes } from "../../../.storybook/helpers";
6-
import { Badge, Icon, TestIcon } from "../../../index";
6+
import { Badge, Icon, TestIcon } from "../../components";
77

88
export default {
99
title: "Components/Badge",

src/components/ContentGroup/ContentGroup.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import React from "react";
22
import { LoremIpsum } from "react-lorem-ipsum";
33
import { Meta, StoryFn } from "@storybook/react";
44

5-
import { Badge, ContentGroup, HtmlContentBlock, IconButton, Tag } from "../../../index";
5+
import { Badge, ContentGroup, HtmlContentBlock, IconButton, Tag } from "../../components";
66

77
export default {
88
title: "Components/ContentGroup",

src/components/ContentGroup/ContentGroup.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ import React from "react";
22
import classNames from "classnames";
33
import Color from "color";
44

5-
import { TestableComponent } from "../../components/interfaces";
6-
import { CLASSPREFIX as eccgui } from "../../configuration/constants";
75
import {
86
Divider,
97
Icon,
@@ -17,7 +15,9 @@ import {
1715
Toolbar,
1816
ToolbarSection,
1917
Tooltip,
20-
} from "../index";
18+
} from "../../components";
19+
import { TestableComponent } from "../../components/interfaces";
20+
import { CLASSPREFIX as eccgui } from "../../configuration/constants";
2121

2222
export interface ContentGroupProps extends Omit<React.HTMLAttributes<HTMLElement>, "title">, TestableComponent {
2323
/**

src/components/Icon/stories/IconButton.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { OverlaysProvider } from "@blueprintjs/core";
33
import { LogoReact } from "@carbon/icons-react";
44
import { Meta, StoryFn } from "@storybook/react";
55

6-
import { IconButton, TestIcon } from "../../../../index";
6+
import { IconButton, TestIcon } from "../../../components";
77

88
import buttonStory from "./../../Button/Button.stories";
99
import canonicalIcons from "./../canonicalIconNames";

src/components/Notification/Notification.stories.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@ import { LoremIpsum, loremIpsum } from "react-lorem-ipsum";
33
import { Meta, StoryFn } from "@storybook/react";
44

55
import { helpersArgTypes } from "../../../.storybook/helpers";
6-
import { Button, HtmlContentBlock, Markdown, Notification, Spacing } from "../../../index";
6+
import { Markdown } from "../../cmem";
7+
import { Button, HtmlContentBlock, Notification, Spacing } from "../../components";
78

89
export default {
910
title: "Components/Notification",

0 commit comments

Comments
 (0)