added version to deprecated comments and explicit replacements, added info intent to notification

Author: anda2002

src/components/Button/Button.stories.tsx

@@ -20,6 +20,7 @@ export default {
         },
         intent: {
             ...helpersArgTypes.exampleIntent,
+            options: ["UNDEFINED", "primary", "success", "warning", "danger"],
         },
     },
 } as Meta<typeof Button>;

src/components/Button/Button.tsx

@@ -6,7 +6,6 @@ import {
     ButtonProps as BlueprintButtonProps,
     Intent as BlueprintIntent,
 } from "@blueprintjs/core";
-import { IntentTypes } from "common/Intent";
 
 import { CLASSPREFIX as eccgui } from "../../configuration/constants";
 import { ValidIconName } from "../Icon/canonicalIconNames";
@@ -16,10 +15,6 @@ import Badge, { BadgeProps } from "./../Badge/Badge";
 import Tooltip, { TooltipProps } from "./../Tooltip/Tooltip";
 
 interface AdditionalButtonProps {
-    /**
-     * Intent state of the button.
-     */
-    intent?: IntentTypes;
     /**
      * Always use this when the button triggers an affirmative action, e.g. confirm a process.
      * The button is displayed with primary color scheme.
@@ -28,33 +23,31 @@ interface AdditionalButtonProps {
     /**
      * Always use this when the button triggers an disruptive action, e.g. delete or remove.
      * The button is displayed with primary color scheme.
-     *  @deprecated use `intent` instead.
      */
     disruptive?: boolean;
     /**
      * Use this when a button is important enough to highlight it in a set of other buttons.
      * The button is displayed with primary color scheme.
-     *  @deprecated use `intent` instead.
      */
     elevated?: boolean;
     /**
      * The button is displayed with primary color scheme.
-     * @deprecated use `intent` instead.
+     * @deprecated (v25) use `intent="primary"` instead.
      */
     hasStatePrimary?: boolean;
     /**
      * The button is displayed with success (some type of green) color scheme.
-     *  @deprecated use `intent` instead.
+     *  @deprecated (v25) use `intent="success"` instead.
      */
     hasStateSuccess?: boolean;
     /**
      * The button is displayed with warning (some type of orange) color scheme.
-     *  @deprecated use `intent` instead.
+     *  @deprecated (v25) use `intent="warning"` instead.
      */
     hasStateWarning?: boolean;
     /**
      * The button is displayed with danger (some type of red) color scheme.
-     *  @deprecated use `intent` instead.
+     *  @deprecated (v25) use `intent="danger"` instead.
      */
     hasStateDanger?: boolean;
     /**
@@ -84,12 +77,10 @@ interface AdditionalButtonProps {
     //target?: string;
 }
 
-interface ExtendedButtonProps
-    extends AdditionalButtonProps,
-        Omit<BlueprintButtonProps, "icon" | "rightIcon" | "intent"> {}
+interface ExtendedButtonProps extends AdditionalButtonProps, Omit<BlueprintButtonProps, "icon" | "rightIcon"> {}
 interface ExtendedAnchorButtonProps
     extends AdditionalButtonProps,
-        Omit<BlueprintAnchorButtonProps, "icon" | "rightIcon" | "intent"> {}
+        Omit<BlueprintAnchorButtonProps, "icon" | "rightIcon"> {}
 
 export type ButtonProps = ExtendedButtonProps & ExtendedAnchorButtonProps;
 

src/components/Form/FieldItem.tsx

@@ -18,25 +18,25 @@ export interface FieldItemProps extends React.HTMLAttributes<HTMLDivElement>, Te
     /**
      * Set primary state.
      * This is not routed through automatically.
-     * @deprecated use `intent` instead.
+     * @deprecated (v25) use `intent="primary"` instead.
      */
     hasStatePrimary?: boolean;
     /**
      * Set success state.
      * This is not routed through automatically.
-     * @deprecated use `intent` instead.
+     * @deprecated (v25) use `intent="success"` instead.
      */
     hasStateSuccess?: boolean;
     /**
      * Set warning state.
      * This is not routed through automatically.
-     * @deprecated use `intent` instead.
+     * @deprecated (v25) use `intent="warning"` instead.
      */
     hasStateWarning?: boolean;
     /**
      * Set danger state.
      * This is not routed through automatically.
-     * @deprecated use `intent` instead.
+     * @deprecated (v25) use `intent="danger"` instead.
      */
     hasStateDanger?: boolean;
     /**

src/components/Form/FieldSet.tsx

@@ -11,22 +11,22 @@ export interface FieldSetProps extends Omit<React.FieldsetHTMLAttributes<HTMLFie
     boxed?: boolean;
     /**
      * The fieldsetsection is displayed with primary color scheme.
-     * @deprecated use `intent` instead.
+     * @deprecated (v25) use `intent="primary"` instead.
      */
     hasStatePrimary?: boolean;
     /**
      * The fieldset section is displayed with success (some type of green) color scheme.
-     * @deprecated use `intent` instead.
+     * @deprecated (v25) use `intent="success"` instead.
      */
     hasStateSuccess?: boolean;
     /**
      * The fieldset section is displayed with warning (some type of orange) color scheme.
-     * @deprecated use `intent` instead.
+     * @deprecated (v25) use `intent="warning"` instead.
      */
     hasStateWarning?: boolean;
     /**
      * The fieldsetsection is displayed with danger (some type of red) color scheme.
-     * @deprecated use `intent` instead.
+     * @deprecated (v25) use `intent="danger"` instead.
      */
     hasStateDanger?: boolean;
     /**

src/components/Notification/Notification.stories.tsx

@@ -17,7 +17,7 @@ export default {
         },
         intent: {
             ...helpersArgTypes.exampleIntent,
-            options: ["UNDEFINED", "success", "warning", "danger", "neutral"],
+            options: ["UNDEFINED", "success", "warning", "danger", "neutral", "info"],
         },
     },
 } as Meta<typeof Notification>;

src/components/Notification/Notification.tsx

@@ -28,27 +28,28 @@ export interface NotificationProps
     /**
      * Intent state of the notification.
      */
-    intent?: Extract<IntentTypes, "neutral" | "success" | "warning" | "danger">;
+    intent?: Extract<IntentTypes, "neutral" | "success" | "warning" | "danger" | "info">;
     /**
      * Notification has a neutral color scheme.
+     * @deprecated (v25) use `intent="neutral"` instead.
      */
     neutral?: boolean;
     /**
      * Notification is a success info.
      * This defines the colorization and the icon symbol.
-     * @deprecated use `intent` instead.
+     * @deprecated (v25) use `intent="success"` instead.
      */
     success?: boolean;
     /**
      * Notification is a warning alert.
      * This defines the colorization and the icon symbol.
-     * @deprecated use `intent` instead.
+     * @deprecated (v25) use `intent="warning"` instead.
      */
     warning?: boolean;
     /**
      * Notification is a danger alert.
      * This defines the colorization and the icon symbol.
-     * @deprecated use `intent` instead.
+     * @deprecated (v25) use `intent="danger"` instead.
      */
     danger?: boolean;
     /**
@@ -88,7 +89,7 @@ export const Notification = ({
     wrapperProps,
     "data-test-id": dataTestId,
     "data-testid": dataTestid,
-    intent,
+    intent = "info",
     ...otherProps
 }: NotificationProps) => {
     let intentLevel: string = IntentClassNames.INFO;
@@ -113,7 +114,7 @@ export const Notification = ({
 
     const intents: Array<NotificationProps["intent"]> = ["success", "warning", "danger"];
     const intentClass = intent ? " " + IntentClassNames[intent.toUpperCase()] : "";
-    const intentIconSymbol = intents.includes(intent) ? `state-${intent}` : "";
+    const intentIconSymbol = intents.includes(intent) ? `state-${intent}` : "state-info";
 
     let notificationIcon = icon !== false ? icon : undefined;
     if (icon !== false && !notificationIcon && (!!iconSymbol || !!intentIconSymbol)) {

src/components/Spinner/Spinner.tsx

@@ -17,13 +17,13 @@ type Intent = "inherit" | "primary" | "success" | "warning" | "danger";
 export interface SpinnerProps extends Omit<BlueprintSpinnerProps, "size" | "intent"> {
     /**
      * intent value or a valid css color definition
-     * @deprecated use `intent` instead.
+     * @deprecated (v25) use `intent` instead.
      */
     color?: Intent | string;
     /**
      * Intent state of the field item.
      */
-    intent?: Intent | string;
+    intent?: Intent;
     /**
      * Additional CSS class names.
      */