Merge pull request #251 from eccenca/fix/uriPatternEditor-CMEM-6461

Fix: Code editor sets initial value on every code editor instance re-init

Author: haschek

CHANGELOG.md

@@ -8,8 +8,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
 
 ### Added
 
--   Added custom icon for "Concatenate to file" operator (CMEM-6476).
--   `CntentGroup` component
+- Added custom icon for "Concatenate to file" operator (CMEM-6476).
+-   `<ContentGroup />` component
     -   Manage display of a grouped content section.
     -   Add info, actions and context annotations by using its properties.
     -   Can be nested into each other.
@@ -19,7 +19,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
     -   editor is focused on load if `autoFocus` prop is set to `true`
     -   implemented support for `disabled` state in code editor
     -   implemented support for `intent` states in code editor
--   `Label` component
+-   `<Label />`
     -   added `additionalElements` property to display elements at the end of the label
 -   `<NodeContent />`
     -   `resizeDirections` to specifiy the axis that can be used to resize the node
@@ -31,6 +31,11 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
 -   `<MenutItem />`
     -   `tooltip` property to dislay tooltip on menu item label
 
+### Fixed
+
+-   `CodeAutocompleteField`:
+    -    Code editor resets to initial value on every code editor instance re-init
+
 ### Changed
 
 -   StickyNote data structure: Refactored position and dimension (breaking change)

src/components/AutoSuggestion/AutoSuggestion.tsx

@@ -219,6 +219,8 @@ const AutoSuggestion = ({
         CodeAutocompleteFieldSuggestionWithReplacementInfo | undefined
     >(undefined);
     const [cm, setCM] = React.useState<EditorView>();
+    const currentCm = React.useRef<EditorView>()
+    currentCm.current = cm
     const isFocused = React.useRef(false);
     const autoSuggestionDivRef = React.useRef<HTMLDivElement>(null);
     /** Mutable editor state, since this needs to be current in scope of the SingleLineEditorComponent. */
@@ -235,12 +237,12 @@ const AutoSuggestion = ({
     const pathIsValid = validationResponse?.valid ?? true;
 
     React.useEffect(() => {
-        if (reInitOnInitialValueChange && initialValue != null && cm) {
+        if (reInitOnInitialValueChange && initialValue != null && currentCm.current) {
             dispatch({
-                changes: { from: 0, to: cm?.state?.doc.length, insert: initialValue },
+                changes: { from: 0, to: currentCm.current.state?.doc.length, insert: initialValue },
             });
         }
-    }, [initialValue, cm, reInitOnInitialValueChange]);
+    }, [initialValue, reInitOnInitialValueChange]);
 
     const setCurrentIndex = (newIndex: number) => {
         editorState.index = newIndex;