Skip to content

Commit 86ea778

Browse files
committed
Check data-test-id before usage
1 parent d2f7033 commit 86ea778

1 file changed

Lines changed: 12 additions & 9 deletions

File tree

src/cmem/ActivityControl/ActivityControlWidget.tsx

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,8 @@ export function ActivityControlWidget(props: ActivityControlWidgetProps) {
141141
{progressBar && <ProgressBar {...progressBar} />}
142142
{(progressSpinner || progressSpinnerFinishedIcon) && (
143143
<OverviewItemDepiction
144-
data-testid={`${dataTestId}-progress-spinner`}
145-
data-test-id={`${dataTestIdLegacy}-progress-spinner`}
144+
data-testid={dataTestId ? `${dataTestId}-progress-spinner` : undefined}
145+
data-test-id={dataTestIdLegacy ? `${dataTestIdLegacy}-progress-spinner` : undefined}
146146
keepColors
147147
>
148148
{progressSpinnerFinishedIcon ? (
@@ -161,8 +161,8 @@ export function ActivityControlWidget(props: ActivityControlWidgetProps) {
161161
<OverviewItemDescription>
162162
{props.label && (
163163
<OverviewItemLine
164-
data-testid={`${dataTestId}-label`}
165-
data-test-id={`${dataTestIdLegacy}-label`}
164+
data-testid={dataTestId ? `${dataTestId}-label` : undefined}
165+
data-test-id={dataTestIdLegacy ? `${dataTestIdLegacy}-label` : undefined}
166166
small={small}
167167
>
168168
{React.cloneElement(labelWrapper, {}, props.label)}
@@ -171,8 +171,8 @@ export function ActivityControlWidget(props: ActivityControlWidgetProps) {
171171
)}
172172
{(props.statusMessage || tags) && (
173173
<OverviewItemLine
174-
data-testid={`${dataTestId}-status-message`}
175-
data-test-id={`${dataTestIdLegacy}-status-message`}
174+
data-testid={dataTestId ? `${dataTestId}-status-message` : undefined}
175+
data-test-id={dataTestIdLegacy ? `${dataTestIdLegacy}-status-message` : undefined}
176176
small
177177
>
178178
{tags}
@@ -196,15 +196,18 @@ export function ActivityControlWidget(props: ActivityControlWidgetProps) {
196196
)}
197197
{timerExecutionMsg && !(props.statusMessage || tags) && (
198198
<OverviewItemLine
199-
data-testid={`${dataTestId}-status-message`}
200-
data-test-id={`${dataTestIdLegacy}-status-message`}
199+
data-testid={dataTestId ? `${dataTestId}-status-message` : undefined}
200+
data-test-id={dataTestIdLegacy ? `${dataTestIdLegacy}-status-message` : undefined}
201201
small
202202
>
203203
{timerExecutionMsg}
204204
</OverviewItemLine>
205205
)}
206206
</OverviewItemDescription>
207-
<OverviewItemActions data-testid={`${dataTestId}-actions`} data-test-id={`${dataTestIdLegacy}-actions`}>
207+
<OverviewItemActions
208+
data-testid={dataTestId ? `${dataTestId}-actions` : undefined}
209+
data-test-id={dataTestIdLegacy ? `${dataTestIdLegacy}-actions` : undefined}
210+
>
208211
{activityActions &&
209212
activityActions.map((action, idx) => {
210213
return (

0 commit comments

Comments
 (0)