Skip to content

Commit 239bafb

Browse files
committed
fix keys in element arrays
1 parent 6fb807e commit 239bafb

1 file changed

Lines changed: 4 additions & 12 deletions

File tree

src/cmem/ActivityControl/ActivityControlWidget.tsx

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -224,11 +224,6 @@ export function ActivityControlWidget(props: ActivityControlWidgetProps) {
224224
{activityActions &&
225225
activityActions.map((action, idx) => {
226226
const ActionButton = () => <IconButton
227-
key={
228-
typeof action.icon === "string"
229-
? action.icon
230-
: action["data-test-id"] ?? action["data-testid"] ?? idx
231-
}
232227
data-test-id={action["data-test-id"]}
233228
data-testid={action["data-testid"]}
234229
name={action.icon}
@@ -244,6 +239,7 @@ export function ActivityControlWidget(props: ActivityControlWidgetProps) {
244239
/>
245240
return action.notification ?
246241
<ContextOverlay
242+
key={idx}
247243
content={<Notification
248244
message={action.notification.message}
249245
intent={action.notification.intent ?? "neutral"}
@@ -253,9 +249,9 @@ export function ActivityControlWidget(props: ActivityControlWidgetProps) {
253249
defaultIsOpen={true}
254250
onClose={action.notification.onClose}
255251
>
256-
<ActionButton/>
252+
<ActionButton />
257253
</ContextOverlay> :
258-
<ActionButton/>
254+
<ActionButton key={idx} />
259255
})}
260256
{additionalActions}
261257
{activityContextMenu && activityContextMenu.menuItems.length > 0 && (
@@ -267,11 +263,7 @@ export function ActivityControlWidget(props: ActivityControlWidgetProps) {
267263
return (
268264
<MenuItem
269265
icon={menuAction.icon}
270-
key={
271-
typeof menuAction.icon === "string"
272-
? menuAction.icon
273-
: menuAction["data-test-id"] ?? idx
274-
}
266+
key={idx}
275267
onClick={menuAction.action}
276268
text={menuAction.tooltip}
277269
/>

0 commit comments

Comments
 (0)