fixed changelog, notification icon, and updated button states

Author: anda2002

CHANGELOG.md

@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
 
 ## [Unreleased]
 
+### Added
+
+-   `intent` property to `Button`, `FieldItem`, `FieldSet`, `Notification`, and `Spinner`
+
 ## [24.1.0] - 2025-04-16
 
 ### Added
@@ -48,7 +52,6 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
     -   `operation-format-list-bullet`
     -   `operation-format-list-checked`
     -   `operation-format-list-numbered`
--   `intent` property to `Button`, `FieldItem`, `FieldSet`, `Notification`, and `Spinner`
 
 ### Fixed
 

src/components/Button/Button.stories.tsx

@@ -71,17 +71,17 @@ const TemplateSemantic: StoryFn<typeof Button> = (args) => (
 export const ButtonSemantics = TemplateSemantic.bind({});
 ButtonSemantics.args = FullExample.args;
 
-const TemplateState: StoryFn<typeof Button> = (args) => (
+const TemplateIntent: StoryFn<typeof Button> = (args) => (
     <OverlaysProvider>
-        <Button {...args} text="Success" hasStateSuccess />
+        <Button {...args} text="Success" intent="success" />
         <Spacing vertical />
-        <Button {...args} text="Warning" hasStateWarning />
+        <Button {...args} text="Warning" intent="warning" />
         <Spacing vertical />
-        <Button {...args} text="Danger" hasStateDanger />
+        <Button {...args} text="Danger" intent="danger" />
     </OverlaysProvider>
 );
-export const ButtonStates = TemplateState.bind({});
-ButtonStates.args = FullExample.args;
+export const ButtonIntent = TemplateIntent.bind({});
+ButtonIntent.args = FullExample.args;
 
 const TemplateContent: StoryFn<typeof Button> = (args) => (
     <OverlaysProvider>

src/components/Notification/Notification.tsx

@@ -114,11 +114,11 @@ export const Notification = ({
 
     const intents: Array<NotificationProps["intent"]> = ["info", "success", "warning", "danger"];
     const intentClass = intent ? " " + IntentClassNames[intent.toUpperCase()] : "";
-    const intentIconSymbol = intents.includes(intent) ? `state-${intent}` : "state-info";
+    const intentIconSymbol = intents.includes(intent) ? `state-${intent}` : iconSymbol;
 
     let notificationIcon = icon !== false ? icon : undefined;
-    if (icon !== false && !notificationIcon && (!!iconSymbol || !!intentIconSymbol)) {
-        notificationIcon = <Icon name={(intentIconSymbol || iconSymbol) as ValidIconName} />;
+    if (icon !== false && !notificationIcon && !!intentIconSymbol) {
+        notificationIcon = <Icon name={intentIconSymbol as ValidIconName} />;
     }
 
     const content = actions ? (