[Suggestion] Provide model pk instead of instance to ModelService update/patch/delete methods

[kennyhei]

To me it would make more sense to provide just pk to these methods:

def update(self, pk: t.Any, payload: PydanticModel, **kwargs: t.Any) -> t.Any:
    instance = self.get_one(pk=pk)
    data = payload.model_dump(exclude_unset=True)
    data.update(kwargs)
    for attr, value in data.items():
        setattr(instance, attr, value)
    instance.save()
    return instance

def patch(self, pk: t.Any, payload: PydanticModel, **kwargs: t.Any) -> t.Any:
    return self.update(pk=pk, payload=payload, **kwargs)

def delete(self, pk: t.Any) -> None:
    instance = self.get_one(pk=pk)
    instance.delete()

Example:

# BEFORE suggested change
@api.put("/items/{item_id}")
def update(request, item_id: int, item: Item):
    existing_item = self.service.get_one(item_id)
    return self.service.update(existing_item, item)

@api.delete("/items/{item_id}")
def delete(request, item_id: int):
    existing_item = self.service.get_one(item_id)
    return self.service.delete(existing_item)

# AFTER suggested change
@api.put("/items/{item_id}")
def update(request, item_id: int, item: Item):
    return self.service.update(item_id, item)

@api.delete("/items/{item_id}")
def delete(request, item_id: int):
    return self.service.delete(item_id)

[eadwinCode]

@kennyhei, how are you getting the items in the code below?

# AFTER suggested change
@api.put("/items/{item_id}")
def update(request, item_id: int, item: Item):
    return self.service.update(item_id, item)
    ```

[kennyhei]

Hmm, what do you mean? 🤔 It retrieves the item inside update() using the item_id and then updates it:

def update(self, pk: t.Any, schema: PydanticModel, **kwargs: t.Any) -> t.Any:
    instance = self.get_one(pk) # <-- this line is added here
    data = schema.model_dump(exclude_unset=True)
    data.update(kwargs)
    for attr, value in data.items():
        setattr(instance, attr, value)
    instance.save()
    return instance