From e50367ca98ce33e6588ba1a295369570db790c28 Mon Sep 17 00:00:00 2001 From: Nirmit Damania Date: Tue, 10 Nov 2026 08:56:38 -0500 Subject: [PATCH 1/2] fix parent_link fieldset bug --- liminal/base/properties/base_field_properties.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/liminal/base/properties/base_field_properties.py b/liminal/base/properties/base_field_properties.py index 10dd7a5..91657fe 100644 --- a/liminal/base/properties/base_field_properties.py +++ b/liminal/base/properties/base_field_properties.py @@ -69,6 +69,8 @@ def unsupported_field_properties( unsupported.add("unit_name") if field_type != BenchlingFieldType.DECIMAL: unsupported.add("decimal_places") + if not has_entity_link: + unsupported.add("parent_link") return unsupported def set_archived(self, value: bool) -> BaseFieldProperties: From abf8142aa0e0e93a171f3d918fcbfbecffe056d3 Mon Sep 17 00:00:00 2001 From: Nirmit Damania Date: Tue, 10 Nov 2026 09:10:46 -0500 Subject: [PATCH 2/2] loosen validation for parent_link --- liminal/base/properties/base_field_properties.py | 2 -- liminal/orm/column.py | 4 ---- 2 files changed, 6 deletions(-) diff --git a/liminal/base/properties/base_field_properties.py b/liminal/base/properties/base_field_properties.py index 91657fe..10dd7a5 100644 --- a/liminal/base/properties/base_field_properties.py +++ b/liminal/base/properties/base_field_properties.py @@ -69,8 +69,6 @@ def unsupported_field_properties( unsupported.add("unit_name") if field_type != BenchlingFieldType.DECIMAL: unsupported.add("decimal_places") - if not has_entity_link: - unsupported.add("parent_link") return unsupported def set_archived(self, value: bool) -> BaseFieldProperties: diff --git a/liminal/orm/column.py b/liminal/orm/column.py index 0ea95af..34dfc7f 100644 --- a/liminal/orm/column.py +++ b/liminal/orm/column.py @@ -108,10 +108,6 @@ def __init__( raise ValueError( f"Column {name}: Parent link can only be set if the field type is ENTITY_LINK." ) - if parent_link and not entity_link: - raise ValueError( - f"Column {name}: Parent link cannot be set without an entity link." - ) if type in BenchlingFieldType.get_non_multi_select_types() and is_multi is True: raise ValueError( f"Column {name}: Field type {type} cannot have multi-value set as True."