diff --git a/external/duckdb b/external/duckdb index b060f56d..fbd180f3 160000 --- a/external/duckdb +++ b/external/duckdb @@ -1 +1 @@ -Subproject commit b060f56de7ccaba45dd754a5ec7e2d69c1264702 +Subproject commit fbd180f3a40ca04d7165aa589771b8ea8110d693 diff --git a/tests/fast/arrow/scan/test_arrow_scan_row_ranges.py b/tests/fast/arrow/scan/test_arrow_scan_row_ranges.py index abf5588b..736b9449 100644 --- a/tests/fast/arrow/scan/test_arrow_scan_row_ranges.py +++ b/tests/fast/arrow/scan/test_arrow_scan_row_ranges.py @@ -919,14 +919,6 @@ def test_a_struct_dictionary_without_a_null_value_reads_its_values(self, indices con.register("src", pa.table({"d": column})) assert con.execute("SELECT d FROM src").fetchall() == expected - @pytest.mark.xfail( - strict=True, - raises=duckdb.InternalException, - reason=( - "the engine fails to read a list of dictionaries whose first vector holds only empty lists: it " - "dereferences a dictionary it never built" - ), - ) @pytest.mark.timeout(60) @pytest.mark.parametrize("threads", [1, 8]) @pytest.mark.parametrize(("empty", "valued"), [(2048, 1), (300_000, 1000)], ids=["one_vector", "several_ranges"]) diff --git a/tests/fast/types/test_time_ns.py b/tests/fast/types/test_time_ns.py index 0bcb2993..6eb0d0fb 100644 --- a/tests/fast/types/test_time_ns.py +++ b/tests/fast/types/test_time_ns.py @@ -2,7 +2,7 @@ import pytest -from duckdb import ConversionException, sqltypes +from duckdb import sqltypes def test_time_ns_select(duckdb_cursor): @@ -12,10 +12,6 @@ def test_time_ns_select(duckdb_cursor): assert isinstance(result, datetime.time) -@pytest.mark.xfail( - raises=ConversionException, - reason="Conversion Error: Unimplemented type for cast (TIME -> TIME_NS)", -) def test_time_ns_insert(duckdb_cursor): """This tests that datetime.time values can be inserted as TIME_NS.""" duckdb_cursor.execute("SELECT TIME_NS '1992-09-20 11:30:00.123456'") @@ -66,7 +62,7 @@ def test_time_ns_pandas_roundtrip(duckdb_cursor): def test_time_pandas_roundtrip(duckdb_cursor): - """For Pandas, creating a table using CREATE .... AS SELECT FROM df, will create TIME_NS cols by default.""" + """A pandas column of datetime.time values comes back as TIME, not TIME_NS.""" pytest.importorskip("pandas") df = duckdb_cursor.execute("SELECT TIME '12:34:56.123456789' AS time_col").df() assert df["time_col"].dtype == "object"