diff --git a/CHANGELOG.md b/CHANGELOG.md index 5d20878d4..043cb0bb9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed +- SqlServerDsc + - Several integration tests wrongly said that the command `Test-DscConfiguration` + return `$true` when it is in fact return the string value `'True'`. - DSC_SqlRS and DSC_SqlWindowsFirewall - Fixed a duplicated word in localized `TestFailedAfterSet` messages. - SqlServerDsc diff --git a/tests/Integration/Resources/DSC_SqlAgentAlert.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlAgentAlert.Integration.Tests.ps1 index 480408002..c97452bad 100644 --- a/tests/Integration/Resources/DSC_SqlAgentAlert.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlAgentAlert.Integration.Tests.ps1 @@ -111,7 +111,7 @@ Describe "_Integration" -Tag @('Integration_SQL2016', ' } } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -163,7 +163,7 @@ Describe "_Integration" -Tag @('Integration_SQL2016', ' $resourceCurrentState.Severity | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Integration/Resources/DSC_SqlAgentFailsafe.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlAgentFailsafe.Integration.Tests.ps1 index 47ad859d5..1108c3aad 100644 --- a/tests/Integration/Resources/DSC_SqlAgentFailsafe.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlAgentFailsafe.Integration.Tests.ps1 @@ -102,7 +102,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.NotificationMethod | Should-Be $ConfigurationData.AllNodes.NotificationMethod } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -154,7 +154,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.NotificationMethod | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Integration/Resources/DSC_SqlAgentOperator.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlAgentOperator.Integration.Tests.ps1 index 3cff8c8ec..8fd20fe27 100644 --- a/tests/Integration/Resources/DSC_SqlAgentOperator.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlAgentOperator.Integration.Tests.ps1 @@ -102,7 +102,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.EmailAddress | Should-Be $ConfigurationData.AllNodes.EmailAddress } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -154,7 +154,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.EmailAddress | Should-Be $ConfigurationData.AllNodes.NewEmailAddress1 } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -206,7 +206,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.EmailAddress | Should-Be ('{0};{1}' -f $ConfigurationData.AllNodes.NewEmailAddress1, $ConfigurationData.AllNodes.NewEmailAddress2 ) } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -258,7 +258,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.EmailAddress | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Integration/Resources/DSC_SqlAlwaysOnService.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlAlwaysOnService.Integration.Tests.ps1 index a767d0fe7..769850a4e 100644 --- a/tests/Integration/Resources/DSC_SqlAlwaysOnService.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlAlwaysOnService.Integration.Tests.ps1 @@ -153,7 +153,7 @@ Describe "$($script:dscResourceName)_Integration" -Skip { $resourceCurrentState.Ensure | Should-Be 'Present' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -203,7 +203,7 @@ Describe "$($script:dscResourceName)_Integration" -Skip { $resourceCurrentState.Ensure | Should-Be 'Absent' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Integration/Resources/DSC_SqlAudit.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlAudit.Integration.Tests.ps1 index 4bddfaecc..a0a9a0d21 100644 --- a/tests/Integration/Resources/DSC_SqlAudit.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlAudit.Integration.Tests.ps1 @@ -140,7 +140,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.MaximumRolloverFiles | Should-Be $ConfigurationData.AllNodes.MaximumRolloverFiles1 } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -195,7 +195,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.AuditFilter | Should-Be $ConfigurationData.AllNodes.AuditFilter2 } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -250,7 +250,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.AuditFilter | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -307,7 +307,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.MaximumRolloverFiles | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -362,7 +362,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.AuditFilter | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Integration/Resources/DSC_SqlDatabase.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlDatabase.Integration.Tests.ps1 index 2e2ba8381..14992cc62 100644 --- a/tests/Integration/Resources/DSC_SqlDatabase.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlDatabase.Integration.Tests.ps1 @@ -107,7 +107,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.OwnerName | Should-Be ('{0}\SqlAdmin' -f $env:COMPUTERNAME) } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -161,7 +161,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.Collation | Should-Be $ConfigurationData.AllNodes.Collation } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -215,7 +215,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.CompatibilityLevel | Should-Be $ConfigurationData.AllNodes.CompatibilityLevel } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -269,7 +269,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.RecoveryModel | Should-Be $ConfigurationData.AllNodes.RecoveryModel } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -323,7 +323,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.OwnerName | Should-Be $ConfigurationData.AllNodes.OwnerName } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -377,7 +377,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.SnapshotIsolation | Should-Be $ConfigurationData.AllNodes.SnapshotIsolation } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -435,7 +435,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.SnapshotIsolation | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Integration/Resources/DSC_SqlDatabaseDefaultLocation.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlDatabaseDefaultLocation.Integration.Tests.ps1 index 5b77c4c1e..95cb48520 100644 --- a/tests/Integration/Resources/DSC_SqlDatabaseDefaultLocation.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlDatabaseDefaultLocation.Integration.Tests.ps1 @@ -101,7 +101,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.Path | Should-Be $ConfigurationData.AllNodes.DataFilePath } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -152,7 +152,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.Path | Should-Be $ConfigurationData.AllNodes.LogFilePath } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -204,7 +204,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.Path | Should-Be $ConfigurationData.AllNodes.BackupFilePath.TrimEnd('\') } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Integration/Resources/DSC_SqlDatabaseMail.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlDatabaseMail.Integration.Tests.ps1 index 52b4518a2..9587ea8fa 100644 --- a/tests/Integration/Resources/DSC_SqlDatabaseMail.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlDatabaseMail.Integration.Tests.ps1 @@ -109,7 +109,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.TcpPort | Should-Be $ConfigurationData.AllNodes.TcpPort } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -150,7 +150,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $script:currentConfiguration = Get-DscConfiguration -Verbose -ErrorAction 'Stop' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -209,7 +209,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.TcpPort | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Integration/Resources/DSC_SqlDatabaseObjectPermission.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlDatabaseObjectPermission.Integration.Tests.ps1 index 2c8d0050f..59ca7f5e5 100644 --- a/tests/Integration/Resources/DSC_SqlDatabaseObjectPermission.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlDatabaseObjectPermission.Integration.Tests.ps1 @@ -219,7 +219,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $grantPermission.Permission | Should-ContainCollection @('Select') } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -290,7 +290,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $grantPermission.Permission | Should-ContainCollection @('Select') } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -355,7 +355,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $grantPermission.Permission | Should-ContainCollection @('Select') } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -433,7 +433,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $grantPermission.Permission | Should-ContainCollection @('Alter') } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -508,7 +508,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $grantPermission.Permission | Should-ContainCollection @('Alter') } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Integration/Resources/DSC_SqlDatabasePermission.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlDatabasePermission.Integration.Tests.ps1 index b19bc7ab2..5793bc444 100644 --- a/tests/Integration/Resources/DSC_SqlDatabasePermission.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlDatabasePermission.Integration.Tests.ps1 @@ -113,7 +113,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $grantState.Permission | Should-ContainCollection 'CreateTable' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -175,7 +175,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $grantState.Permission | Should-NotContainCollection 'CreateTable' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -242,7 +242,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $denyState.Permission | Should-ContainCollection 'CreateTable' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -313,7 +313,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $denyState.Permission | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -374,7 +374,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $grantState.Permission | Should-ContainCollection 'Select' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -435,7 +435,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $grantState.Permission | Should-NotContainCollection 'Select' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -496,7 +496,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $grantState.Permission | Should-ContainCollection 'Select' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -557,7 +557,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $grantState.Permission | Should-NotContainCollection 'Select' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Integration/Resources/DSC_SqlDatabaseUser.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlDatabaseUser.Integration.Tests.ps1 index 318891bfc..f4ef78b43 100644 --- a/tests/Integration/Resources/DSC_SqlDatabaseUser.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlDatabaseUser.Integration.Tests.ps1 @@ -110,7 +110,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.LoginType | Should-Be 'WindowsUser' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -170,7 +170,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.LoginType | Should-Be 'SqlLogin' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -230,7 +230,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.LoginType | Should-Be 'SqlLogin' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -290,7 +290,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.LoginType | Should-Be 'WindowsGroup' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -350,7 +350,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.LoginType | Should-Be 'SqlLogin' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -410,7 +410,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.UserType | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -470,7 +470,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.LoginType | Should-Be 'Certificate' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -530,7 +530,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.LoginType | Should-Be 'AsymmetricKey' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Integration/Resources/DSC_SqlEndpoint.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlEndpoint.Integration.Tests.ps1 index 0d28385ca..088bec585 100644 --- a/tests/Integration/Resources/DSC_SqlEndpoint.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlEndpoint.Integration.Tests.ps1 @@ -105,7 +105,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.State | Should-Be 'Started' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -156,7 +156,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.EndpointType | Should-Be 'DatabaseMirroring' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -214,7 +214,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.MessageForwardingSize | Should-Be $ConfigurationData.AllNodes.MessageForwardingSize } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -265,7 +265,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.EndpointType | Should-Be 'ServiceBroker' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Integration/Resources/DSC_SqlLogin.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlLogin.Integration.Tests.ps1 index e91b57ad5..7555e3c02 100644 --- a/tests/Integration/Resources/DSC_SqlLogin.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlLogin.Integration.Tests.ps1 @@ -141,7 +141,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.Disabled | Should-BeFalse } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -195,7 +195,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.Disabled | Should-BeFalse } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -248,7 +248,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.Disabled | Should-BeTrue } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -304,7 +304,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.LoginPasswordPolicyEnforced | Should-BeTrue } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } @@ -402,7 +402,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.LoginPasswordPolicyEnforced | Should-BeFalse } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } @@ -489,7 +489,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $script:currentConfiguration = Get-DscConfiguration -Verbose -ErrorAction 'Stop' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } @@ -559,7 +559,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.LoginPasswordPolicyEnforced | Should-BeFalse } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -601,7 +601,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $null = Start-DscConfiguration @startDscConfigurationParameters } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -657,7 +657,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.LoginPasswordPolicyEnforced | Should-BeTrue } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -699,7 +699,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $null = Start-DscConfiguration @startDscConfigurationParameters } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -795,7 +795,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.LoginPasswordPolicyEnforced | Should-BeTrue } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -852,7 +852,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.LoginPasswordPolicyEnforced | Should-BeTrue } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -908,7 +908,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.LoginPasswordPolicyEnforced | Should-BeFalse } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -961,7 +961,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.Disabled | Should-BeFalse } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -1013,7 +1013,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.LoginType | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -1065,7 +1065,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.LoginType | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Integration/Resources/DSC_SqlPermission.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlPermission.Integration.Tests.ps1 index 259ef64b3..1b66888f2 100644 --- a/tests/Integration/Resources/DSC_SqlPermission.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlPermission.Integration.Tests.ps1 @@ -112,7 +112,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $grantState.Permission | Should-ContainCollection 'CreateEndpoint' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -173,7 +173,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $grantState.Permission | Should-NotContainCollection 'CreateEndpoint' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -239,7 +239,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $denyState.Permission | Should-ContainCollection 'CreateEndpoint' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -309,7 +309,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $denyState.Permission | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -374,7 +374,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $grantState.Permission | Should-ContainCollection 'AlterAnyEndpoint' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -432,7 +432,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $grantState.Permission | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -497,7 +497,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $denyState.Permission | Should-ContainCollection 'AlterAnyEndpoint' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -560,7 +560,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $denyState.Permission | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Integration/Resources/DSC_SqlProtocol.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlProtocol.Integration.Tests.ps1 index 3251ffdf6..c9a42b8d5 100644 --- a/tests/Integration/Resources/DSC_SqlProtocol.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlProtocol.Integration.Tests.ps1 @@ -102,7 +102,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.PipeName | Should-Be '\\.\pipe\MSSQL$DSCSQLTEST\sql\query' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -154,7 +154,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.PipeName | Should-Be '\\.\pipe\MSSQL$DSCSQLTEST\sql\query' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Integration/Resources/DSC_SqlProtocolTcpIp.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlProtocolTcpIp.Integration.Tests.ps1 index 40aa60a84..37e61be06 100644 --- a/tests/Integration/Resources/DSC_SqlProtocolTcpIp.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlProtocolTcpIp.Integration.Tests.ps1 @@ -102,7 +102,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.IpAddress | Should-Be $ConfigurationData.AllNodes.IpAddress } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Integration/Resources/DSC_SqlRS.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlRS.Integration.Tests.ps1 index 1ebaf1a92..0a77894af 100644 --- a/tests/Integration/Resources/DSC_SqlRS.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlRS.Integration.Tests.ps1 @@ -167,7 +167,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.ReportServerReservedUrl | Should-ContainCollection 'http://+:80' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } diff --git a/tests/Integration/Resources/DSC_SqlRSSetup.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlRSSetup.Integration.Tests.ps1 index 67b76eee6..eb1d9f5f3 100644 --- a/tests/Integration/Resources/DSC_SqlRSSetup.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlRSSetup.Integration.Tests.ps1 @@ -183,7 +183,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2017', $resourceCurrentState.InstallFolder | Should-Be $ConfigurationData.AllNodes.InstallFolder } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Integration/Resources/DSC_SqlRS_Default.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlRS_Default.Integration.Tests.ps1 index b3c67dee5..f01538f0b 100644 --- a/tests/Integration/Resources/DSC_SqlRS_Default.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlRS_Default.Integration.Tests.ps1 @@ -166,7 +166,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.UseSsl | Should-BeFalse } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } @@ -340,7 +340,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.UseSsl | Should-BeTrue } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } @@ -410,7 +410,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.UseSsl | Should-BeFalse } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } diff --git a/tests/Integration/Resources/DSC_SqlReplication.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlReplication.Integration.Tests.ps1 index 58f2c33e0..022f8dc98 100644 --- a/tests/Integration/Resources/DSC_SqlReplication.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlReplication.Integration.Tests.ps1 @@ -138,7 +138,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.WorkingDirectory | Should-Be 'C:\Temp' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -193,7 +193,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.WorkingDirectory | Should-Be 'C:\Temp' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -248,7 +248,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.WorkingDirectory | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -303,7 +303,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.WorkingDirectory | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Integration/Resources/DSC_SqlRole.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlRole.Integration.Tests.ps1 index 4cf5c1770..7c3ff31d1 100644 --- a/tests/Integration/Resources/DSC_SqlRole.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlRole.Integration.Tests.ps1 @@ -104,8 +104,8 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.MembersToExclude | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { - Test-DscConfiguration -Verbose | Should-BeTrue + It 'Should return True when Test-DscConfiguration is run' { + Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -158,8 +158,8 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.MembersToExclude | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { - Test-DscConfiguration -Verbose | Should-BeTrue + It 'Should return True when Test-DscConfiguration is run' { + Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -215,8 +215,8 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.MembersToExclude | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { - Test-DscConfiguration -Verbose | Should-BeTrue + It 'Should return True when Test-DscConfiguration is run' { + Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -274,8 +274,8 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.MembersToExclude | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { - Test-DscConfiguration -Verbose | Should-BeTrue + It 'Should return True when Test-DscConfiguration is run' { + Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -334,8 +334,8 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.MembersToExclude | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { - Test-DscConfiguration -Verbose | Should-BeTrue + It 'Should return True when Test-DscConfiguration is run' { + Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -388,8 +388,8 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.MembersToExclude | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { - Test-DscConfiguration -Verbose | Should-BeTrue + It 'Should return True when Test-DscConfiguration is run' { + Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -442,8 +442,8 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.MembersToExclude | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { - Test-DscConfiguration -Verbose | Should-BeTrue + It 'Should return True when Test-DscConfiguration is run' { + Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Integration/Resources/DSC_SqlScript.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlScript.Integration.Tests.ps1 index 2dbc2ad72..9a6ef1ab0 100644 --- a/tests/Integration/Resources/DSC_SqlScript.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlScript.Integration.Tests.ps1 @@ -181,7 +181,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.SetFilePath | Should-Be $ConfigurationData.AllNodes.SetSqlScriptPath } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -236,7 +236,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.SetFilePath | Should-Be $ConfigurationData.AllNodes.SetSqlScriptPath } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -329,7 +329,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.SetFilePath | Should-Be $ConfigurationData.AllNodes.SetSqlScriptPath } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -422,7 +422,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.SetFilePath | Should-Be $ConfigurationData.AllNodes.SetSqlScriptPath2 } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Integration/Resources/DSC_SqlScriptQuery.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlScriptQuery.Integration.Tests.ps1 index 550177a58..8de9a7b2e 100644 --- a/tests/Integration/Resources/DSC_SqlScriptQuery.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlScriptQuery.Integration.Tests.ps1 @@ -143,7 +143,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.SetQuery -replace '\r\n', "`n" | Should-Be ($ConfigurationData.AllNodes.SetQuery -replace '\r\n', "`n") } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -198,7 +198,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.SetQuery -replace '\r\n', "`n" | Should-Be ($ConfigurationData.AllNodes.SetQuery -replace '\r\n', "`n") } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -291,7 +291,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.SetQuery -replace '\r\n', "`n" | Should-Be ($ConfigurationData.AllNodes.SetQuery -replace '\r\n', "`n") } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Integration/Resources/DSC_SqlSecureConnection.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlSecureConnection.Integration.Tests.ps1 index d2a75cf43..e8a019bc7 100644 --- a/tests/Integration/Resources/DSC_SqlSecureConnection.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlSecureConnection.Integration.Tests.ps1 @@ -116,7 +116,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.ServerName | Should-Be 'localhost' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -168,7 +168,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.ServerName | Should-Be 'localhost' } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Integration/Resources/DSC_SqlServiceAccount.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlServiceAccount.Integration.Tests.ps1 index 91f273d16..c5216773f 100644 --- a/tests/Integration/Resources/DSC_SqlServiceAccount.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlServiceAccount.Integration.Tests.ps1 @@ -143,7 +143,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.ServiceAccountName | Should-Be ('{0}\{1}' -f $env:COMPUTERNAME, (Split-Path -Path $ConfigurationData.AllNodes.SqlSecondary_UserName -Leaf)) } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -194,7 +194,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.ServiceAccountName | Should-Be ('{0}\{1}' -f $env:COMPUTERNAME, (Split-Path -Path $ConfigurationData.AllNodes.SqlAgentSecondary_UserName -Leaf)) } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -245,7 +245,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.ServiceAccountName | Should-Be ('{0}\{1}' -f $env:COMPUTERNAME, (Split-Path -Path $ConfigurationData.AllNodes.SqlPrimary_UserName -Leaf)) } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -296,7 +296,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.ServiceAccountName | Should-Be ('{0}\{1}' -f $env:COMPUTERNAME, (Split-Path -Path $ConfigurationData.AllNodes.SqlAgentPrimary_UserName -Leaf)) } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -380,7 +380,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.ServiceAccountName | Should-Be ('{0}\{1}' -f $env:COMPUTERNAME, (Split-Path -Path $ConfigurationData.AllNodes.SqlSecondary_UserName -Leaf)) } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -431,7 +431,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.ServiceAccountName | Should-Be ('{0}\{1}' -f $env:COMPUTERNAME, (Split-Path -Path $ConfigurationData.AllNodes.SqlAgentSecondary_UserName -Leaf)) } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -482,7 +482,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.ServiceAccountName | Should-Be ('{0}\{1}' -f $env:COMPUTERNAME, (Split-Path -Path $ConfigurationData.AllNodes.SqlPrimary_UserName -Leaf)) } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -533,7 +533,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.ServiceAccountName | Should-Be ('{0}\{1}' -f $env:COMPUTERNAME, (Split-Path -Path $ConfigurationData.AllNodes.SqlAgentPrimary_UserName -Leaf)) } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Integration/Resources/DSC_SqlSetup.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlSetup.Integration.Tests.ps1 index f80fdc1a0..544e8aab5 100644 --- a/tests/Integration/Resources/DSC_SqlSetup.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlSetup.Integration.Tests.ps1 @@ -250,7 +250,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', } # Make sure the module was installed. - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -387,7 +387,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.SQLSysAdminAccounts | Should-ContainCollection ('sa') } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -541,7 +541,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.SQLSysAdminAccounts | Should-ContainCollection ('sa') } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -701,7 +701,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.UpdateSource | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } @@ -861,7 +861,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.UpdateSource | Should-BeFalsy } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Integration/Resources/DSC_SqlWindowsFirewall.Integration.Tests.ps1 b/tests/Integration/Resources/DSC_SqlWindowsFirewall.Integration.Tests.ps1 index 5042f5a98..e72383e90 100644 --- a/tests/Integration/Resources/DSC_SqlWindowsFirewall.Integration.Tests.ps1 +++ b/tests/Integration/Resources/DSC_SqlWindowsFirewall.Integration.Tests.ps1 @@ -140,7 +140,7 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016', $resourceCurrentState.IntegrationServicesFirewall | Should-BeFalse } - It 'Should return $true when Test-DscConfiguration is run' { + It 'Should return True when Test-DscConfiguration is run' { Test-DscConfiguration -Verbose -ErrorAction 'Stop' | Should-Be 'True' } } diff --git a/tests/Unit/Public/Update-SqlDscServerEdition.Tests.ps1 b/tests/Unit/Public/Update-SqlDscServerEdition.Tests.ps1 index 6585e1830..c966a505b 100644 --- a/tests/Unit/Public/Update-SqlDscServerEdition.Tests.ps1 +++ b/tests/Unit/Public/Update-SqlDscServerEdition.Tests.ps1 @@ -107,13 +107,13 @@ Describe 'Update-SqlDscServerEdition' -Tag 'Public' { Update-SqlDscServerEdition -Confirm:$false @mockDefaultParameters Should-Invoke -CommandName Start-SqlSetupProcess -Exactly -ParameterFilter { - $ArgumentList | Should -MatchExactly '\/ACTION=EditionUpgrade' - $ArgumentList | Should -MatchExactly '\/INSTANCENAME="MSSQLSERVER"' # cspell: disable-line - $ArgumentList | Should -MatchExactly '\/PID="12345-12345-12345-12345-12345"' + $ArgumentList | Should-MatchString -CaseSensitive '\/ACTION=EditionUpgrade' + $ArgumentList | Should-MatchString -CaseSensitive '\/INSTANCENAME="MSSQLSERVER"' # cspell: disable-line + $ArgumentList | Should-MatchString -CaseSensitive '\/PID="12345-12345-12345-12345-12345"' # Return $true if none of the above throw. $true - } -Scope It -Times 1 } -Exactly -Times 1 -Scope It + } -Scope It -Times 1 } } @@ -122,11 +122,11 @@ Describe 'Update-SqlDscServerEdition' -Tag 'Public' { Update-SqlDscServerEdition -Force @mockDefaultParameters Should-Invoke -CommandName Start-SqlSetupProcess -Exactly -ParameterFilter { - $ArgumentList | Should -MatchExactly '\/ACTION=EditionUpgrade' + $ArgumentList | Should-MatchString -CaseSensitive '\/ACTION=EditionUpgrade' # Return $true if none of the above throw. $true - } -Scope It -Times 1s 1 -Scope It + } -Scope It -Times 1 } } @@ -171,11 +171,11 @@ Describe 'Update-SqlDscServerEdition' -Tag 'Public' { Update-SqlDscServerEdition @updateSqlDscServerEditionParameters Should-Invoke -CommandName Start-SqlSetupProcess -Exactly -ParameterFilter { - $ArgumentList | Should -MatchExactly $MockExpectedRegEx + $ArgumentList | Should-MatchString -CaseSensitive $MockExpectedRegEx # Return $true if none of the above throw. $true - } -Scope It -Times 1s 1 -Scope It + } -Scope It -Times 1 } }