Skip to content

Commit e732e8a

Browse files
authored
Merge pull request #3777 from thaJeztah/no_jsonmessage
driver/docker-container: remove uses of jsonmessage
2 parents 872d8e5 + 76ba2fa commit e732e8a

3 files changed

Lines changed: 1 addition & 298 deletions

File tree

driver/docker-container/driver.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ import (
2828
"github.com/moby/moby/api/types/container"
2929
"github.com/moby/moby/api/types/mount"
3030
dockerclient "github.com/moby/moby/client"
31-
"github.com/moby/moby/client/pkg/jsonmessage"
3231
"github.com/moby/moby/client/pkg/security"
3332
"github.com/pkg/errors"
3433
)
@@ -104,8 +103,7 @@ func (d *Driver) create(ctx context.Context, l progress.SubLogger) error {
104103
if err != nil {
105104
return err
106105
}
107-
defer resp.Close()
108-
return jsonmessage.DisplayStream(resp, io.Discard)
106+
return resp.Wait(ctx)
109107
}); err != nil {
110108
// image pulling failed, check if it exists in local image store.
111109
// if not, return pulling error. otherwise log it.

vendor/github.com/moby/moby/client/pkg/jsonmessage/jsonmessage.go

Lines changed: 0 additions & 294 deletions
This file was deleted.

vendor/modules.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -783,7 +783,6 @@ github.com/moby/moby/client
783783
github.com/moby/moby/client/internal
784784
github.com/moby/moby/client/internal/mod
785785
github.com/moby/moby/client/internal/timestamp
786-
github.com/moby/moby/client/pkg/jsonmessage
787786
github.com/moby/moby/client/pkg/security
788787
github.com/moby/moby/client/pkg/stringid
789788
github.com/moby/moby/client/pkg/versions

0 commit comments

Comments
 (0)