use a simple boolean instead of a count to determine if enumeration has values

Author: dkackman

LinqStatistics/EnumerableStatsMinMax.cs

@@ -40,17 +40,17 @@ public static Range<int> MinMax(this IEnumerable<int> source)
             // so that the first comparisons in the aggregate function work as expected
             var minMax = new Range<int>(int.MaxValue, int.MinValue, true);
 
-            long n = 0;
+            bool any = false;
             var result = source.Aggregate<int, Range<int>>(minMax, (accumulator, value) =>
             {
                 var min = Math.Min(accumulator.Min, value);
                 var max = Math.Max(accumulator.Max, value);
-                n++;
+                any = true;
 
                 return new Range<int>(min, max);
             });
 
-            if (n > 0)
+            if (any)
                 return result;
 
             throw new InvalidOperationException("source sequence contains no elements");
@@ -122,17 +122,17 @@ public static Range<long> MinMax(this IEnumerable<long> source)
             // so that the first comparisons in the aggregate function work as expected
             var minMax = new Range<long>(long.MaxValue, long.MinValue, true);
 
-            long n = 0;
+            bool any = false;
             var result = source.Aggregate<long, Range<long>>(minMax, (accumulator, value) =>
             {
                 var min = Math.Min(accumulator.Min, value);
                 var max = Math.Max(accumulator.Max, value);
-                n++;
+                any = true;
 
                 return new Range<long>(min, max);
             });
 
-            if (n > 0)
+            if (any)
                 return result;
 
             throw new InvalidOperationException("source sequence contains no elements");
@@ -204,17 +204,17 @@ public static Range<float> MinMax(this IEnumerable<float> source)
             // so that the first comparisons in the aggregate function work as expected
             var minMax = new Range<float>(float.MaxValue, float.MinValue, true);
 
-            long n = 0;
+            bool any = false;
             var result = source.Aggregate<float, Range<float>>(minMax, (accumulator, value) =>
             {
                 var min = Math.Min(accumulator.Min, value);
                 var max = Math.Max(accumulator.Max, value);
-                n++;
+                any = true;
 
                 return new Range<float>(min, max);
             });
 
-            if (n > 0)
+            if (any)
                 return result;
 
             throw new InvalidOperationException("source sequence contains no elements");
@@ -286,17 +286,17 @@ public static Range<double> MinMax(this IEnumerable<double> source)
             // so that the first comparisons in the aggregate function work as expected
             var minMax = new Range<double>(double.MaxValue, double.MinValue, true);
 
-            long n = 0;
+            bool any = false;
             var result = source.Aggregate<double, Range<double>>(minMax, (accumulator, value) =>
             {
                 var min = Math.Min(accumulator.Min, value);
                 var max = Math.Max(accumulator.Max, value);
-                n++;
+                any = true;
 
                 return new Range<double>(min, max);
             });
 
-            if (n > 0)
+            if (any)
                 return result;
 
             throw new InvalidOperationException("source sequence contains no elements");
@@ -368,17 +368,17 @@ public static Range<decimal> MinMax(this IEnumerable<decimal> source)
             // so that the first comparisons in the aggregate function work as expected
             var minMax = new Range<decimal>(decimal.MaxValue, decimal.MinValue, true);
 
-            long n = 0;
+            bool any = false;
             var result = source.Aggregate<decimal, Range<decimal>>(minMax, (accumulator, value) =>
             {
                 var min = Math.Min(accumulator.Min, value);
                 var max = Math.Max(accumulator.Max, value);
-                n++;
+                any = true;
 
                 return new Range<decimal>(min, max);
             });
 
-            if (n > 0)
+            if (any)
                 return result;
 
             throw new InvalidOperationException("source sequence contains no elements");

LinqStatistics/EnumerableStatsMinMax.tt

@@ -52,17 +52,17 @@ namespace LinqStatistics
             // so that the first comparisons in the aggregate function work as expected
             var minMax = new Range<<#= type #>>(<#= type #>.MaxValue, <#= type #>.MinValue, true);
 
-            long n = 0;
+            bool any = false;
             var result = source.Aggregate<<#= type #>, Range<<#= type #>>>(minMax, (accumulator, value) =>
             {
                 var min = Math.Min(accumulator.Min, value);
                 var max = Math.Max(accumulator.Max, value);
-                n++;
+                any = true;
 
                 return new Range<<#= type #>>(min, max);
             });
 
-            if (n > 0)
+            if (any)
                 return result;
 
             throw new InvalidOperationException("source sequence contains no elements");

LinqStatistics/NaN/EnumerableStatsMinMax.cs

@@ -40,17 +40,17 @@ public static Range<float> MinMaxNaN(this IEnumerable<float> source)
             // so that the first comparisons in the aggregate function work as expected
             var minMax = new Range<float>(float.MaxValue, float.MinValue, true);
 
-            long n = 0;
+            bool any = false;
             var result = source.Aggregate<float, Range<float>>(minMax, (accumulator, value) =>
             {
                 var min = Math.Min(accumulator.Min, value);
                 var max = Math.Max(accumulator.Max, value);
-                n++;
+                any = true;
 
                 return new Range<float>(min, max);
             });
 
-            if (n > 0)
+            if (any)
                 return result;
 
             return new Range<float>(float.NaN, float.NaN);
@@ -122,17 +122,17 @@ public static Range<double> MinMaxNaN(this IEnumerable<double> source)
             // so that the first comparisons in the aggregate function work as expected
             var minMax = new Range<double>(double.MaxValue, double.MinValue, true);
 
-            long n = 0;
+            bool any = false;
             var result = source.Aggregate<double, Range<double>>(minMax, (accumulator, value) =>
             {
                 var min = Math.Min(accumulator.Min, value);
                 var max = Math.Max(accumulator.Max, value);
-                n++;
+                any = true;
 
                 return new Range<double>(min, max);
             });
 
-            if (n > 0)
+            if (any)
                 return result;
 
             return new Range<double>(double.NaN, double.NaN);

LinqStatistics/NaN/EnumerableStatsMinMax.tt

@@ -52,17 +52,17 @@ namespace LinqStatistics.NaN
             // so that the first comparisons in the aggregate function work as expected
             var minMax = new Range<<#= type #>>(<#= type #>.MaxValue, <#= type #>.MinValue, true);
 
-            long n = 0;
+            bool any = false;
             var result = source.Aggregate<<#= type #>, Range<<#= type #>>>(minMax, (accumulator, value) =>
             {
                 var min = Math.Min(accumulator.Min, value);
                 var max = Math.Max(accumulator.Max, value);
-                n++;
+                any = true;
 
                 return new Range<<#= type #>>(min, max);
             });
 
-            if (n > 0)
+            if (any)
                 return result;
 
             return new Range<<#= type #>>(<#= type #>.NaN, <#= type #>.NaN);