Fix comparison methods and add tests; incorporate @coderabbitai comments

Author: rlskoeser

src/undate/date.py

@@ -57,9 +57,9 @@ def __iter__(self) -> Iterable:
     def __gt__(self, other: object) -> bool:
         match other:
             case int():
-                return self.upper > other
+                return self.lower > other
             case UnInt():
-                return self.upper > other.lower
+                return self.lower > other.upper
             case _:
                 return NotImplemented
 
@@ -90,22 +90,22 @@ def _replace_with(self, other_lower, other_upper, op):
             self, lower=op(self.lower, other_lower), upper=op(self.upper, other_upper)
         )
 
-    def __add__(self, other: object) -> bool:
+    def __add__(self, other: object) -> "UnInt":
         match other:
             case int():
                 # increase both values by the added amount
                 add_values = (other, other)
             case UnInt():
-                # subtract the upper and lower values by the other lower and upper
-                # to include the largest range of possible values
+                # add other lower value to current lower and other upper
+                # to current upper to include the largest range of possible values
                 # (when calculating with uncertain values, the uncertainty increases)
                 add_values = (other.lower, other.upper)
             case _:
                 return NotImplemented
 
         return self._replace_with(*add_values, operator.add)
 
-    def __sub__(self, other):
+    def __sub__(self, other) -> "UnInt":
         match other:
             case int():
                 # decrease both values by the subtracted amount
@@ -147,14 +147,12 @@ def __repr__(self):
         # specifies full UnInt initialization with upper and lower keywords
         return f"{self.__class__.__name__}(days=[{self.days.lower},{self.days.upper}])"
 
-    # TODO: what does equality for an uncertain range mean?
-    # is an uncertain range ever equal to another uncertain range?
-
     def __eq__(self, other: object) -> bool:
         # is an uncertain duration ever *equal* another, even if the values are the same?
-        if other is self:
-            return True
-        return False
+        # for now, make the assumption that we only want identity equality
+        # and not value equality; perhaps in future we can revisit
+        # or add functions to check value equality / equivalence / similarity
+        return other is self
 
     def __lt__(self, other: object) -> bool:
         match other:

tests/test_date.py

@@ -120,6 +120,34 @@ def test_contains(self):
         # other types are assumed not in range
         assert "twenty-eight" not in anymonth_days
 
+    def test_gt(self):
+        ten_twelve = UnInt(10, 12)
+        # compare with integer
+        assert 13 > ten_twelve
+        assert not 12 > ten_twelve
+        assert not 9 > ten_twelve
+        # compare with unint
+        assert UnInt(13, 23) > ten_twelve
+        assert not UnInt(12, 24) > ten_twelve
+        assert not UnInt(2, 4) > ten_twelve
+        # unsupported type
+        with pytest.raises(TypeError):
+            ten_twelve > "three"
+
+    def test_lt(self):
+        ten_twelve = UnInt(10, 12)
+        # compare with integer
+        assert 9 < ten_twelve
+        assert not 12 < ten_twelve
+        assert not 13 < ten_twelve
+        # compare with unint
+        assert UnInt(2, 4) < ten_twelve
+        assert not UnInt(12, 24) < ten_twelve
+        assert not UnInt(13, 23) < ten_twelve
+        # unsupported type
+        with pytest.raises(TypeError):
+            ten_twelve < "three"
+
     def test_iterable(self):
         anymonth_days = UnInt(lower=28, upper=31)
         assert list(anymonth_days) == [28, 29, 30, 31]