From 18ef72b044561f29b7936796acf7f68d3862ee06 Mon Sep 17 00:00:00 2001 From: Samuel K Date: Tue, 4 Aug 2026 00:28:38 +0000 Subject: [PATCH 1/2] fix(lint): resolve staticcheck S1008 and ST1005 findings - pkg/tunnel/services.go: simplify the retry.OnError predicate to `return ctx.Err() == nil` (S1008). - cmd/pro/start.go: suppress ErrLoftNotReachable's ST1005 (capitalized error string) since "Devsy Pro" is a proper noun, not a fixable style issue. No behavior changes. --- cmd/pro/start.go | 1 + pkg/tunnel/services.go | 5 +---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/cmd/pro/start.go b/cmd/pro/start.go index 8547cde53..9cac721d4 100644 --- a/cmd/pro/start.go +++ b/cmd/pro/start.go @@ -2174,6 +2174,7 @@ func getHelmWorkdir(chartName string) (string, error) { var ( ErrMissingContainer = errors.New("missing container") + //nolint:staticcheck // ST1005: "Devsy Pro" is a proper noun ErrLoftNotReachable = errors.New("Devsy Pro is not reachable") ) diff --git a/pkg/tunnel/services.go b/pkg/tunnel/services.go index fe149ce9c..cb86ac54c 100644 --- a/pkg/tunnel/services.go +++ b/pkg/tunnel/services.go @@ -258,10 +258,7 @@ func RunServices(ctx context.Context, opts RunServicesOptions) error { Factor: retryFactor, Jitter: retryJitter, }, func(err error) bool { - if ctx.Err() != nil { - return false - } - return true + return ctx.Err() == nil }, func() error { return runServicesIteration(ctx, opts, forwardedPorts, resolver) }) From 20b43a6962bce91b95b94eb773817afbbc1657a8 Mon Sep 17 00:00:00 2001 From: Samuel K Date: Tue, 4 Aug 2026 00:37:13 +0000 Subject: [PATCH 2/2] refactor(lint): rename ErrLoftNotReachable to ErrPlatformNotReachable Matches the current Devsy Platform naming; "Loft" is legacy. --- cmd/pro/start.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/pro/start.go b/cmd/pro/start.go index 9cac721d4..f307cd0cd 100644 --- a/cmd/pro/start.go +++ b/cmd/pro/start.go @@ -812,7 +812,7 @@ func (cmd *StartCmd) waitForLoftDocker(ctx context.Context, containerID string) if cmd.NoTunnel { return "", fmt.Errorf( "%w: %s", - ErrLoftNotReachable, + ErrPlatformNotReachable, "cannot connect to Devsy Pro as it has no exposed port and --no-tunnel is enabled", ) } @@ -2175,7 +2175,7 @@ func getHelmWorkdir(chartName string) (string, error) { var ( ErrMissingContainer = errors.New("missing container") //nolint:staticcheck // ST1005: "Devsy Pro" is a proper noun - ErrLoftNotReachable = errors.New("Devsy Pro is not reachable") + ErrPlatformNotReachable = errors.New("Devsy Pro is not reachable") ) type ContainerDetails struct {