Skip to content

Commit b714899

Browse files
committed
Fix format
1 parent dab3eab commit b714899

3 files changed

Lines changed: 25 additions & 43 deletions

File tree

benchmark/next-stylex/tsconfig.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"compilerOptions": {
3-
"target": "es5",
3+
"target": "es2024",
44
"lib": ["dom", "dom.iterable", "esnext"],
55
"allowJs": true,
66
"skipLibCheck": true,
@@ -9,7 +9,7 @@
99
"noEmit": true,
1010
"esModuleInterop": true,
1111
"module": "esnext",
12-
"moduleResolution": "node",
12+
"moduleResolution": "bundler",
1313
"resolveJsonModule": true,
1414
"isolatedModules": true,
1515
"jsx": "react-jsx",

libs/sheet/src/lib.rs

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -448,16 +448,8 @@ impl StyleSheet {
448448
self.theme.typography.keys().for_each(|key| {
449449
typography_keys.insert(key.clone());
450450
});
451-
for length_theme in self.theme.length.values() {
452-
for key in length_theme.keys() {
453-
length_keys.insert(key.clone());
454-
}
455-
}
456-
for shadow_theme in self.theme.shadows.values() {
457-
for key in shadow_theme.keys() {
458-
shadows_keys.insert(key.clone());
459-
}
460-
}
451+
length_keys.extend(self.theme.length.values().flat_map(|t| t.keys().cloned()));
452+
shadows_keys.extend(self.theme.shadows.values().flat_map(|t| t.keys().cloned()));
461453

462454
self.theme.colors.keys().for_each(|key| {
463455
theme_keys.insert(key.clone());

libs/sheet/src/theme.rs

Lines changed: 21 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -360,17 +360,15 @@ impl<'de> Deserialize<'de> for TokenValues {
360360
Value::Number(n) => result.push(Some(n.to_string())),
361361
_ => {
362362
return Err(serde::de::Error::custom(format!(
363-
"Invalid token value in array: {:?}",
364-
item
363+
"Invalid token value in array: {item:?}"
365364
)));
366365
}
367366
}
368367
}
369368
Ok(Self(result))
370369
}
371370
_ => Err(serde::de::Error::custom(format!(
372-
"Token value must be a string, number, or array, got: {:?}",
373-
value
371+
"Token value must be a string, number, or array, got: {value:?}"
374372
))),
375373
}
376374
}
@@ -388,11 +386,13 @@ pub type ShadowTheme = BTreeMap<String, TokenValues>;
388386
/// Convert a JSON number to a length value: `n * 4` + "px".
389387
fn number_to_length(n: &serde_json::Number) -> String {
390388
if let Some(i) = n.as_i64() {
391-
format!("{}px", i * 4)
389+
let v = i * 4;
390+
format!("{v}px")
392391
} else if let Some(f) = n.as_f64() {
393392
let val = f * 4.0;
394393
if val.fract() == 0.0 {
395-
format!("{}px", val as i64)
394+
let v = val as i64;
395+
format!("{v}px")
396396
} else {
397397
format!("{val}px")
398398
}
@@ -692,34 +692,29 @@ impl Theme {
692692
if themes.is_empty() {
693693
return;
694694
}
695-
let default_key = themes
695+
let Some(default_key) = themes
696696
.keys()
697697
.find(|k| *k == "default")
698698
.or_else(|| themes.keys().next())
699-
.cloned();
700-
701-
let Some(default_key) = &default_key else {
699+
.cloned()
700+
else {
702701
return;
703702
};
704703

705704
// Sort variants: default first, then alphabetical
706705
let mut sorted_variants: Vec<_> = themes.iter().collect();
707-
sorted_variants.sort_by(|a, b| {
708-
if a.0 == default_key {
709-
std::cmp::Ordering::Less
710-
} else if b.0 == default_key {
711-
std::cmp::Ordering::Greater
712-
} else {
713-
a.0.cmp(b.0)
714-
}
706+
sorted_variants.sort_by(|a, b| match (a.0 == &default_key, b.0 == &default_key) {
707+
(true, _) => std::cmp::Ordering::Less,
708+
(_, true) => std::cmp::Ordering::Greater,
709+
_ => a.0.cmp(b.0),
715710
});
716711

717712
for (variant_name, token_theme) in &sorted_variants {
718-
let is_default = *variant_name == default_key;
713+
let is_default = *variant_name == &default_key;
719714
let selector = if is_default {
720715
":root".to_string()
721716
} else {
722-
format!(":root[data-theme={}]", variant_name)
717+
format!(":root[data-theme={variant_name}]")
723718
};
724719

725720
// Group variables by breakpoint level
@@ -740,25 +735,20 @@ impl Theme {
740735
level_map
741736
.entry(idx)
742737
.or_default()
743-
.push(format!("--{}:{}", name, optimized));
738+
.push(format!("--{name}:{optimized}"));
744739
}
745740
}
746741
}
747742

748-
for (level, vars) in level_map {
743+
for (level, vars) in &level_map {
749744
if vars.is_empty() {
750745
continue;
751746
}
752747
let vars_str = vars.join(";");
753-
if level == 0 {
754-
write!(css, "{}{{{}}}", selector, vars_str).unwrap();
755-
} else if let Some(bp) = breakpoints.get(level) {
756-
write!(
757-
css,
758-
"@media(min-width:{bp}px){{{}{{{}}}}}",
759-
selector, vars_str
760-
)
761-
.unwrap();
748+
if *level == 0 {
749+
write!(css, "{selector}{{{vars_str}}}").unwrap();
750+
} else if let Some(bp) = breakpoints.get(*level) {
751+
write!(css, "@media(min-width:{bp}px){{{selector}{{{vars_str}}}}}").unwrap();
762752
}
763753
}
764754
}

0 commit comments

Comments
 (0)