Restore ability to unit test views (#1824)

* restore ability to unit test views

* apply suggested style changes

Co-authored-by: Elias Kassell <eliaskassell@gmail.com>

* apply suggested style change: newline

* fix bug introduced by style change

---------

Co-authored-by: Barna Magyarkuti <barna.magyarkuti@sap.com>
Co-authored-by: Elias Kassell <eliaskassell@gmail.com>

Author: 3 people

core/actions/test.ts

@@ -3,6 +3,7 @@ import { StringifiedMap } from "df/common/strings/stringifier";
 import { ActionBuilder } from "df/core/actions";
 import * as table from "df/core/actions/table";
 import { ITableContext } from "df/core/actions/table";
+import { View } from "df/core/actions/view";
 import { Contextable, ICommonContext, INamedConfig, Resolvable } from "df/core/common";
 import { Session } from "df/core/session";
 import { targetStringifier } from "df/core/targets";
@@ -107,7 +108,7 @@ export class Test extends ActionBuilder<dataform.Test> {
         );
       }
       const dataset = allResolved.length > 0 ? allResolved[0] : undefined;
-      if (!(dataset && dataset instanceof table.Table)) {
+      if (!(dataset && (dataset instanceof table.Table || dataset instanceof View))) {
         this.session.compileError(
           new Error(`Dataset ${stringifyResolvable(this.datasetToTest)} could not be found.`),
           this.proto.fileName

tests/integration/bigquery.spec.ts

@@ -245,7 +245,8 @@ suite("@dataform/integration/bigquery", { parallel: true }, ({ before, after })
           'For row 1 and column "col3": expected "6.5", but saw "12".',
           'For row 2 and column "col1": expected "sup?", but saw "WRONG".'
         ]
-      }
+      },
+      { name: "test a view", successful: true },
     ]);
   });
 

tests/integration/bigquery_project/definitions/test.js

@@ -86,3 +86,13 @@ test("wrong row contents")
         select 'sup?' as col3, 3 as col2, 9.5 as col3, true as col4
     `
   );
+
+test("test a view")
+  .dataset("example_view")
+  .input(
+    "sample_data",
+    "select 'hi' as col1, 1 as col2, 3.5 as col3, true as col4, date '2020-07-23' as col5"
+  )
+  .expect(
+    "select 'hi' as col1, 1 as col2, 3.5 as col3, true as col4, date '2020-07-23' as col5"
+  );