From 0cd05b48391477fb8f713912d60d0a0adbe3d681 Mon Sep 17 00:00:00 2001
From: Nyarlathoteppppp <xubowen.ton618@gmail.com>
Date: Tue, 27 Oct 2026 12:45:57 +1100
Subject: [PATCH] =?UTF-8?q?fix(window):=20=E4=B8=BB=E7=AA=97=E5=8F=A3?=
 =?UTF-8?q?=E6=A0=87=E9=A2=98=E4=BD=BF=E7=94=A8=E5=BA=94=E7=94=A8=E5=90=8D?=
 =?UTF-8?q?=EF=BC=8C=E4=BF=AE=E5=A4=8D=20Windows=20=E4=BB=BB=E5=8A=A1?=
 =?UTF-8?q?=E6=A0=8F=E6=97=A0=E5=90=8D=E7=A7=B0?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 build/splash.html              |  2 +-
 src/main/index.ts              |  4 ++--
 test/main-window-title.test.ts | 42 ++++++++++++++++++++++++++++++++++
 3 files changed, 45 insertions(+), 3 deletions(-)
 create mode 100644 test/main-window-title.test.ts

diff --git a/build/splash.html b/build/splash.html
index 5ac5b4e59..1a9f4f652 100644
--- a/build/splash.html
+++ b/build/splash.html
@@ -3,7 +3,7 @@
   <head>
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width,initial-scale=1" />
-    <title></title>
+    <title>DSH Desktop</title>
     <script>
       const splashTheme = new URLSearchParams(location.search).get('theme')
       document.documentElement.dataset.theme = splashTheme === 'dark' ? 'dark' : 'light'
diff --git a/src/main/index.ts b/src/main/index.ts
index 699ae398b..5467c1167 100644
--- a/src/main/index.ts
+++ b/src/main/index.ts
@@ -971,7 +971,7 @@ function createWindow(): BrowserWindow {
     minWidth: 900,
     minHeight: 640,
     show: false,
-    title: '',
+    title: app.getName(),
     icon: desktopIconPath(),
     ...(process.platform === 'darwin' ? {
       titleBarStyle: 'hiddenInset' as const,
@@ -1029,7 +1029,7 @@ function createWindow(): BrowserWindow {
   })
   window.on('page-title-updated', (event) => {
     event.preventDefault()
-    window.setTitle('')
+    window.setTitle(app.getName())
   })
   window.webContents.on('console-message', (details) => {
     if (details.level !== 'error') return
diff --git a/test/main-window-title.test.ts b/test/main-window-title.test.ts
new file mode 100644
index 000000000..d1bcfeb05
--- /dev/null
+++ b/test/main-window-title.test.ts
@@ -0,0 +1,42 @@
+import { readFile } from 'node:fs/promises'
+import { describe, expect, it } from 'vitest'
+
+async function windowSource(): Promise<string> {
+  const main = await readFile('src/main/index.ts', 'utf8')
+  const start = main.indexOf('function createWindow(): BrowserWindow {')
+  expect(start).toBeGreaterThanOrEqual(0)
+  return main.slice(start, main.indexOf('\nasync function openHarness(', start))
+}
+
+// createWindow lives in the application entry point, which starts Electron on import.
+describe('main window title', () => {
+  it('uses the configured app name before any page loads', async () => {
+    const source = await windowSource()
+
+    expect(source).toContain('title: app.getName()')
+    expect(source).not.toMatch(/title:\s*(['"])\1/)
+  })
+
+  it('keeps the app name when renderer pages update their title', async () => {
+    const source = await windowSource()
+
+    expect(source).toMatch(
+      /window\.on\('page-title-updated', \(event\) => \{\s*event\.preventDefault\(\)\s*window\.setTitle\(app\.getName\(\)\)\s*\}\)/
+    )
+    expect(source).not.toMatch(/\.setTitle\((['"])\1\)/)
+  })
+
+  it('retains hidden native captions on macOS and Windows', async () => {
+    const source = await windowSource()
+
+    expect(source).toMatch(/process\.platform === 'darwin' \? \{\s*titleBarStyle: 'hiddenInset'/)
+    expect(source).toMatch(/isWindows\s*\? \{\s*titleBarStyle: 'hidden'/)
+    expect(source).toContain('titleBarOverlay: windowsTitleBarOverlay(')
+  })
+
+  it('does not give the startup page an empty document title', async () => {
+    const splash = await readFile('build/splash.html', 'utf8')
+
+    expect(splash).toContain('<title>DSH Desktop</title>')
+  })
+})