Addressed PR comments

Author: Priyanka-Patil14

aci-preupgrade-validation-script.py

@@ -5882,16 +5882,10 @@ def n9300_switch_memory_check(tversion, fabric_nodes, **kwargs):
     result = PASS
     headers = ["NodeId", "Name", "Model", "Memory Detected (GB)"]
     data = []
-    recommended_action = 'Increase the switch memory to at least 24GB before proceeding with the Cisco ACI software upgrade.'
+    recommended_action = 'Increase the switch memory to at least 24GB on affected N9300-series switches.'
     doc_url = 'https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#n9300-switch-memory'
     min_memory_kb = 24 * 1024 * 1024
 
-    if not tversion:
-        return Result(result=MANUAL, msg=TVER_MISSING)
-
-    if tversion.major_version != '6.1':
-        return Result(result=NA, msg=VER_NOT_AFFECTED)
-
     proc_mem_query = 'procMemUsage.json'
     affected_nodes = [
         node for node in fabric_nodes

docs/docs/validations.md

@@ -2650,12 +2650,6 @@ Due to [CSCwp95515][59], upgrading to an affected version while having any `conf
 
 If any instances of `configpushShardCont` are flagged by this script, Cisco TAC must be contacted to identify and resolve the underlying issue before performing the upgrade.
 
-### N9300 Switch Memory
-
-This check applies only when the target upgrade version is 6.1. It reviews `procMemUsage` for N9300-series switches and flags nodes with less than 24GB memory installed.
-
-If any N9300-series switch is flagged by this check, increase the switch memory to at least 24GB before the upgrade.
-
 ### Auto Firmware Update on Switch Discovery
 
 [Auto Firmware Update on Switch Discovery][63] automatically upgrades a new switch to the target firmware version before registering it to the ACI fabric. This feature activates in three scenarios:
@@ -2675,6 +2669,14 @@ To avoid this risk, consider disabling Auto Firmware Update before upgrading to
 !!! note
     This issue occurs because older switch firmware versions are not compatible with switch images 6.0(3) or newer. The APIC version is not a factor.
 
+### N9300 Switch Memory
+
+This check applies to N9300-series switches only. It reviews `procMemUsage` and flags nodes with less than 24GB memory installed.
+
+Impact: Running an N9300-series switch with less than 24GB memory can lead to memory pressure and increase the risk of service instability.
+
+If any N9300-series switch is flagged by this check, increase the switch memory to at least 24GB.
+
 
 [0]: https://github.com/datacenter/ACI-Pre-Upgrade-Validation-Script
 [1]: https://www.cisco.com/c/dam/en/us/td/docs/Website/datacenter/apicmatrix/index.html

tests/checks/n9300_switch_memory_24g_check/test_n9300_switch_memory_24g_check.py

@@ -18,33 +18,11 @@
 @pytest.mark.parametrize(
     "fabric_nodes, icurl_outputs, tversion, expected_result, expected_msg, expected_data",
     [
-        # Target version missing
-        (
-            read_data(dir, "fabricNode_one.json"),
-            {
-                proc_mem_query: read_data(dir, "procMemUsage_gt24gb.json"),
-            },
-            None,
-            script.MANUAL,
-            script.TVER_MISSING,
-            [],
-        ),
-        # Target version not affected
-        (
-            read_data(dir, "fabricNode_one.json"),
-            {
-                proc_mem_query: read_data(dir, "procMemUsage_gt24gb.json"),
-            },
-            "6.0(3c)",
-            script.NA,
-            script.VER_NOT_AFFECTED,
-            [],
-        ),
         # No nodes returned
         (
             [],
             {},
-            "6.1(2f)",
+            "6.0(3c)",
             script.NA,
             'No N9300 switches found. Skipping.',
             [],
@@ -55,7 +33,7 @@
             {
                 proc_mem_query: read_data(dir, "procMemUsage_node201_gt24gb.json"),
             },
-            "6.1(2f)",
+            "6.0(3c)",
             script.NA,
             'No N9300 switches found. Skipping.',
             [],
@@ -66,7 +44,7 @@
             {
                 proc_mem_query: read_data(dir, "procMemUsage_gt24gb.json"),
             },
-            "6.1(2f)",
+            "6.0(3c)",
             script.PASS,
             '',
             [],
@@ -77,7 +55,7 @@
             {
                 proc_mem_query: read_data(dir, "procMemUsage_all_gt24gb.json"),
             },
-            "6.1(2f)",
+            "6.0(3c)",
             script.PASS,
             '',
             [],
@@ -88,7 +66,7 @@
             {
                 proc_mem_query: read_data(dir, "procMemUsage_mixed.json"),
             },
-            "6.1(2f)",
+            "6.0(3c)",
             script.FAIL_O,
             '',
             [["102", "leaf102", "N9K-C9364C", 21.49]],
@@ -97,7 +75,7 @@
 )
 def test_logic(run_check, mock_icurl, fabric_nodes, tversion, expected_result, expected_msg, expected_data):
     result = run_check(
-        tversion=script.AciVersion(tversion) if tversion else None,
+        tversion=script.AciVersion(tversion),
         fabric_nodes=fabric_nodes,
     )
     assert result.result == expected_result