Added N9300 switch memory check

Author: Priyanka-Patil14

aci-preupgrade-validation-script.py

@@ -950,9 +950,7 @@ def start(self, timeout=5.0):
             timeout (float): How long we wait for the thread start event.
                              5.0 sec by default.
         """
-        _active_limbo_lock = threading._active_limbo_lock
-        _limbo = threading._limbo
-        _start_new_thread = threading._start_new_thread
+        _start_new_thread = getattr(threading, "_start_new_thread", None)
 
         # Python2 uses name mangling
         if hasattr(self, "_Thread__initialized"):
@@ -968,6 +966,18 @@ def start(self, timeout=5.0):
         if self._started.is_set():
             raise RuntimeError("threads can only be started once")
 
+        # Python 3.14+ no longer exposes threading._start_new_thread.
+        # In that case, defer to Thread.start() to keep internal join handles valid.
+        if _start_new_thread is None:
+            super(CustomThread, self).start()
+            self._started.wait(timeout)
+            if not self._started.is_set():
+                raise RuntimeError("can't start new thread")
+            return
+
+        _active_limbo_lock = threading._active_limbo_lock
+        _limbo = threading._limbo
+
         with _active_limbo_lock:
             _limbo[self] = self
         try:
@@ -1493,11 +1503,19 @@ def get_row(widths, values, spad="  ", lpad=""):
 
 def prints(objects, sep=' ', end='\n'):
     with open(RESULT_FILE, 'a') as f:
-        print(objects, sep=sep, end=end, file=sys.stdout)
+        stdout_ok = True
+        try:
+            print(objects, sep=sep, end=end, file=sys.stdout)
+        except (OSError, ValueError):
+            stdout_ok = False
         if end == "\r":
             end = "\n"  # easier to read with \n in a log file
         print(objects, sep=sep, end=end, file=f)
-        sys.stdout.flush()
+        if stdout_ok:
+            try:
+                sys.stdout.flush()
+            except (OSError, ValueError):
+                pass
         f.flush()
 
 
@@ -5877,6 +5895,73 @@ def isis_database_byte_check(tversion, **kwargs):
     return Result(result=result, headers=headers, data=data, recommended_action=recommended_action, doc_url=doc_url)
 
 
+@check_wrapper(check_title='N9300 Switch Memory')
+def n9300_switch_memory_check(tversion, fabric_nodes, **kwargs):
+    result = PASS
+    headers = ["NodeId", "Name", "Model", "Memory Detected (GB)"]
+    data = []
+    recommended_action = 'Increase the switch memory to at least 24GB before proceeding with the Cisco ACI software upgrade.'
+    doc_url = 'https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#n9300-switch-memory'
+    min_memory_kb = 24 * 1024 * 1024
+
+    if not tversion:
+        return Result(result=MANUAL, msg=TVER_MISSING)
+
+    if tversion.major_version != '6.1':
+        return Result(result=NA, msg=VER_NOT_AFFECTED)
+
+    proc_mem_query = 'procMemUsage.json'
+    affected_nodes = [
+        node for node in fabric_nodes
+        if node.get('fabricNode', {}).get('attributes', {}).get('model', '').startswith('N9K-C93')
+    ]
+
+    if not affected_nodes:
+        return Result(result=NA, msg='No N9300 switches found. Skipping.')
+
+    proc_mem_mos = icurl('class', proc_mem_query)
+    node_total_kb = {}
+
+    for memory_mo in proc_mem_mos:
+        attrs = memory_mo.get('procMemUsage', {}).get('attributes', {})
+        total = attrs.get('Total')
+        mem_dn = attrs.get('dn', '')
+        if not total or '/memusage-sup' not in mem_dn:
+            continue
+        dn_match = re.search(node_regex, mem_dn)
+        if not dn_match:
+            continue
+        try:
+            total_kb = int(total)
+        except ValueError:
+            continue
+
+        node_id = dn_match.group('node')
+        if node_id not in node_total_kb:
+            node_total_kb[node_id] = total_kb
+
+    for node in affected_nodes:
+        node_id = node['fabricNode']['attributes']['id']
+        total_kb = node_total_kb.get(node_id)
+        if total_kb is None:
+            continue
+
+        memory_in_gb = round(total_kb / 1048576, 2)
+        if total_kb < min_memory_kb:
+            result = FAIL_O
+            data.append([
+                node_id,
+                node['fabricNode']['attributes'].get('name', ''),
+                node['fabricNode']['attributes'].get('model', ''),
+                memory_in_gb,
+            ])
+
+    if result == PASS:
+        return Result(result=result)
+
+    return Result(result=result, headers=headers, data=data, recommended_action=recommended_action, doc_url=doc_url)
+
+
 # Subprocess check - cat + acidiag
 @check_wrapper(check_title='APIC Database Size')
 def apic_database_size_check(cversion, **kwargs):
@@ -6214,6 +6299,7 @@ class CheckManager:
         pbr_high_scale_check,
         standby_sup_sync_check,
         isis_database_byte_check,
+        n9300_switch_memory_check,
         configpush_shard_check,
         auto_firmware_update_on_switch_check,
 

docs/docs/validations.md

@@ -194,6 +194,7 @@ Items                                           | Defect       | This Script
 [ISIS DTEPs Byte Size][d27]                     | CSCwp15375   | :white_check_mark: | :no_entry_sign:
 [Policydist configpushShardCont Crash][d28]     | CSCwp95515   | :white_check_mark: | :no_entry_sign:
 [Auto Firmware Update on Switch Discovery][d29] | CSCwe83941   | :white_check_mark: | :no_entry_sign:
+[N9300 Switch Memory][d30]                      | -            | :white_check_mark: | :no_entry_sign:
 
 [d1]: #ep-announce-compatibility
 [d2]: #eventmgr-db-size-defect-susceptibility
@@ -224,6 +225,7 @@ Items                                           | Defect       | This Script
 [d27]: #isis-dteps-byte-size
 [d28]: #policydist-configpushshardcont-crash
 [d29]: #auto-firmware-update-on-switch-discovery
+[d30]: #n9300-switch-memory
 
 ## General Check Details
 
@@ -2648,6 +2650,12 @@ Due to [CSCwp95515][59], upgrading to an affected version while having any `conf
 
 If any instances of `configpushShardCont` are flagged by this script, Cisco TAC must be contacted to identify and resolve the underlying issue before performing the upgrade.
 
+### N9300 Switch Memory
+
+This check applies only when the target upgrade version is 6.1. It reviews `procMemUsage` for N9300-series switches and flags nodes with less than 24GB memory installed.
+
+If any N9300-series switch is flagged by this check, increase the switch memory to at least 24GB before the upgrade.
+
 ### Auto Firmware Update on Switch Discovery
 
 [Auto Firmware Update on Switch Discovery][63] automatically upgrades a new switch to the target firmware version before registering it to the ACI fabric. This feature activates in three scenarios:

tests/checks/n9300_switch_memory_24g_check/fabricNode_non_n9300.json

@@ -0,0 +1,13 @@
+[
+    {
+        "fabricNode": {
+            "attributes": {
+                "dn": "topology/pod-1/node-201",
+                "id": "201",
+                "name": "leaf201",
+                "model": "N9K-C9508",
+                "role": "leaf"
+            }
+        }
+    }
+]

tests/checks/n9300_switch_memory_24g_check/fabricNode_one.json

@@ -0,0 +1,13 @@
+[
+    {
+        "fabricNode": {
+            "attributes": {
+                "dn": "topology/pod-1/node-101",
+                "id": "101",
+                "name": "leaf101",
+                "model": "N9K-C93180YC-FX3",
+                "role": "leaf"
+            }
+        }
+    }
+]

tests/checks/n9300_switch_memory_24g_check/fabricNode_two.json

@@ -0,0 +1,24 @@
+[
+    {
+        "fabricNode": {
+            "attributes": {
+                "dn": "topology/pod-1/node-101",
+                "id": "101",
+                "name": "leaf101",
+                "model": "N9K-C93180YC-FX3",
+                "role": "leaf"
+            }
+        }
+    },
+    {
+        "fabricNode": {
+            "attributes": {
+                "dn": "topology/pod-1/node-102",
+                "id": "102",
+                "name": "leaf102",
+                "model": "N9K-C9364C",
+                "role": "leaf"
+            }
+        }
+    }
+]

tests/checks/n9300_switch_memory_24g_check/procMemUsage_all_gt24gb.json

@@ -0,0 +1,20 @@
+[
+    {
+        "procMemUsage": {
+            "attributes": {
+                "dn": "topology/pod-1/node-101/sys/procmem/memusage-sup",
+                "Modname": "sup",
+                "Total": "32535444"
+            }
+        }
+    },
+    {
+        "procMemUsage": {
+            "attributes": {
+                "dn": "topology/pod-1/node-102/sys/procmem/memusage-sup",
+                "Modname": "sup",
+                "Total": "28535444"
+            }
+        }
+    }
+]

tests/checks/n9300_switch_memory_24g_check/procMemUsage_gt24gb.json

@@ -0,0 +1,11 @@
+[
+    {
+        "procMemUsage": {
+            "attributes": {
+                "dn": "topology/pod-1/node-101/sys/procmem/memusage-sup",
+                "Modname": "sup",
+                "Total": "26535444"
+            }
+        }
+    }
+]

tests/checks/n9300_switch_memory_24g_check/procMemUsage_lt24gb.json

@@ -0,0 +1,11 @@
+[
+    {
+        "procMemUsage": {
+            "attributes": {
+                "dn": "topology/pod-1/node-101/sys/procmem/memusage-sup",
+                "Modname": "sup",
+                "Total": "22535444"
+            }
+        }
+    }
+]

tests/checks/n9300_switch_memory_24g_check/procMemUsage_mixed.json

@@ -0,0 +1,20 @@
+[
+    {
+        "procMemUsage": {
+            "attributes": {
+                "dn": "topology/pod-1/node-101/sys/procmem/memusage-sup",
+                "Modname": "sup",
+                "Total": "32535444"
+            }
+        }
+    },
+    {
+        "procMemUsage": {
+            "attributes": {
+                "dn": "topology/pod-1/node-102/sys/procmem/memusage-sup",
+                "Modname": "sup",
+                "Total": "22535444"
+            }
+        }
+    }
+]

tests/checks/n9300_switch_memory_24g_check/procMemUsage_node201_gt24gb.json

@@ -0,0 +1,11 @@
+[
+    {
+        "procMemUsage": {
+            "attributes": {
+                "dn": "topology/pod-1/node-201/sys/procmem/memusage-sup",
+                "Modname": "sup",
+                "Total": "28535444"
+            }
+        }
+    }
+]