Skip to content

Commit fcbd44f

Browse files
committed
Fix mypy union-attr errors in broken symlink tests
Add explicit `assert message is not None` before calling `.lower()` on ValidationResult.message, which is typed as `str | None`. https://claude.ai/code/session_01CLi49c7QcJx11b7UfshbvE
1 parent f55a9aa commit fcbd44f

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

dandi/validate/tests/test_core.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,9 +222,10 @@ def test_validate_broken_symlink_error_default(tmp_path: Path) -> None:
222222
errs = [r for r in results if r.id == "DANDI.FILE_CONTENT_MISSING"]
223223
assert len(errs) == 1
224224
assert errs[0].severity == Severity.ERROR
225+
assert errs[0].message is not None
225226
assert "broken symlink" in errs[0].message.lower()
226227
# No traceback should appear in the message
227-
assert "Traceback" not in (errs[0].message or "")
228+
assert "Traceback" not in errs[0].message
228229

229230

230231
@pytest.mark.ai_generated
@@ -235,6 +236,7 @@ def test_validate_broken_symlink_skip(tmp_path: Path) -> None:
235236
skipped = [r for r in results if r.id == "DANDI.FILE_CONTENT_MISSING_SKIPPED"]
236237
assert len(skipped) == 1
237238
assert skipped[0].severity == Severity.WARNING
239+
assert skipped[0].message is not None
238240
assert "skipped" in skipped[0].message.lower()
239241
# No pynwb/nwbinspector errors should appear
240242
pynwb_errs = [r for r in results if r.origin.validator in (Validator.pynwb,)]

0 commit comments

Comments
 (0)