Skip to content

Commit b27cc0f

Browse files
yarikopticclaude
andcommitted
refactor: move unnecessary in-function imports to module level
Move write_validation_jsonl import in upload.py and load_validation_jsonl import in cmd_validate.py to module level. These had no circular import justification (unlike the validate_bids import in files/bids.py which must stay lazy). Co-Authored-By: Claude Code 2.1.81 / Claude Opus 4.6 <noreply@anthropic.com>
1 parent 1c235d0 commit b27cc0f

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

dandi/cli/cmd_validate.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,11 @@
1616
from .formatter import JSONFormatter, JSONLinesFormatter, YAMLFormatter
1717
from ..utils import pluralize
1818
from ..validate._core import validate as validate_
19-
from ..validate._io import validation_companion_path, write_validation_jsonl
19+
from ..validate._io import (
20+
load_validation_jsonl,
21+
validation_companion_path,
22+
write_validation_jsonl,
23+
)
2024
from ..validate._types import Severity, ValidationResult
2125

2226
lgr = logging.getLogger(__name__)
@@ -264,8 +268,6 @@ def validate(
264268
raise click.UsageError("--load and positional paths are mutually exclusive.")
265269

266270
if load:
267-
from ..validate._io import load_validation_jsonl
268-
269271
results = load_validation_jsonl(load)
270272
else:
271273
results = _collect_results(paths, schema, devel_debug, allow_any_path)

dandi/upload.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
from .support import pyout as pyouts
5050
from .support.pyout import naturalsize
5151
from .utils import ensure_datetime, path_is_subpath, pluralize
52+
from .validate._io import write_validation_jsonl
5253
from .validate._types import Severity
5354

5455

@@ -302,8 +303,6 @@ def process_path(dfile: DandiFile) -> Iterator[dict]:
302303
yield {"status": "pre-validating"}
303304
validation_statuses = dfile.get_validation_errors()
304305
if validation_log_path is not None and validation_statuses:
305-
from .validate._io import write_validation_jsonl
306-
307306
write_validation_jsonl(
308307
validation_statuses, validation_log_path, append=True
309308
)

0 commit comments

Comments
 (0)