Merge branch 'master' into enh-lad-docstrings-operations

Author: CodyCBakerPhD

CHANGELOG.md

@@ -1,3 +1,23 @@
+# 0.74.3 (Sat Feb 14 2026)
+
+#### 🐛 Bug Fix
+
+- bf: pass aiohttp timeouts to fsspec to fix test hang [#1795](https://github.com/dandi/dandi-cli/pull/1795) ([@yarikoptic](https://github.com/yarikoptic))
+- Enhance dandiset metadata error messages [#1790](https://github.com/dandi/dandi-cli/pull/1790) ([@yarikoptic](https://github.com/yarikoptic) [@yarikoptic-gitmate](https://github.com/yarikoptic-gitmate))
+- Fix type annotation in upload sync path prefix calculation [#1794](https://github.com/dandi/dandi-cli/pull/1794) ([@yarikoptic](https://github.com/yarikoptic) [@yarikoptic-gitmate](https://github.com/yarikoptic-gitmate))
+- Fix macOS-15-intel CI failures: h5py and opencv-python regressions [#1783](https://github.com/dandi/dandi-cli/pull/1783) ([@yarikoptic](https://github.com/yarikoptic))
+
+#### 📝 Documentation
+
+- Add module docstrings to validation and NWB utilities [#1789](https://github.com/dandi/dandi-cli/pull/1789) ([@yarikoptic](https://github.com/yarikoptic) [@yarikoptic-gitmate](https://github.com/yarikoptic-gitmate))
+
+#### Authors: 2
+
+- GitMate for @yarikoptic ([@yarikoptic-gitmate](https://github.com/yarikoptic-gitmate))
+- Yaroslav Halchenko ([@yarikoptic](https://github.com/yarikoptic))
+
+---
+
 # 0.74.2 (Fri Jan 30 2026)
 
 #### 🐛 Bug Fix

dandi/dandiset.py

@@ -42,7 +42,11 @@ def __init__(
         if not allow_empty and not os.path.lexists(
             self.path_obj / dandiset_metadata_file
         ):
-            raise ValueError(f"No dandiset at {path}")
+            raise ValueError(
+                f"No dandiset at {path}. "
+                f"The directory does not contain a '{dandiset_metadata_file}' file. "
+                "Use 'dandi download' to download a dandiset or check the path."
+            )
         self.metadata: dict | None = None
         self._metadata_file_obj = self.path_obj / dandiset_metadata_file
         self._load_metadata()
@@ -139,11 +143,17 @@ def _get_identifier(metadata: dict) -> str | None:
     @property
     def identifier(self) -> str:
         if self.metadata is None:
-            raise ValueError("No metadata record found in Dandiset")
+            raise ValueError(
+                f"No metadata record found in Dandiset at {self.path}. "
+                f"The '{dandiset_metadata_file}' file may be empty or corrupted. "
+                "Use 'dandi download' to re-download the dandiset metadata."
+            )
         id_ = self._get_identifier(self.metadata)
         if not id_:
             raise ValueError(
-                f"Found no dandiset.identifier in metadata record: {self.metadata}"
+                f"Found no dandiset.identifier in metadata record. "
+                f"The '{dandiset_metadata_file}' file must contain an 'identifier' field. "
+                f"Metadata: {self.metadata}"
             )
         return id_
 

dandi/misctypes.py

@@ -345,10 +345,27 @@ def open(self) -> IO[bytes]:
         # Optional dependency:
         import fsspec
 
+        from aiohttp import ClientTimeout
+
         # We need to call open() on the return value of fsspec.open() because
         # otherwise the filehandle will only be opened when used to enter a
         # context manager.
-        return cast(IO[bytes], fsspec.open(self.url, mode="rb").open())
+        #
+        # Pass explicit timeouts to aiohttp to prevent indefinite hangs in
+        # fsspec's sync() wrapper.  Without these, a stalled connection to S3
+        # (or minio in tests) causes fsspec's background IO thread to block
+        # forever, which in turn blocks the calling thread in
+        # threading.Event.wait() — see https://github.com/fsspec/filesystem_spec/issues/1666
+        return cast(
+            IO[bytes],
+            fsspec.open(
+                self.url,
+                mode="rb",
+                client_kwargs={
+                    "timeout": ClientTimeout(total=120, sock_read=60, sock_connect=30)
+                },
+            ).open(),
+        )
 
     def get_size(self) -> int:
         return self.size

dandi/pynwb_utils.py

@@ -1,3 +1,14 @@
+"""Utilities for working with NWB (Neurodata Without Borders) files.
+
+This module provides helper functions for reading, validating, and extracting
+metadata from NWB files using PyNWB. Features include:
+- NWB file I/O with caching
+- Metadata extraction for DANDI schema
+- Version compatibility checking
+- External link detection
+- Validation against NWB standards
+"""
+
 from __future__ import annotations
 
 from collections import Counter

dandi/tests/test_metadata.py

@@ -1145,6 +1145,7 @@ def test_nwb2asset(simple2_nwb: Path) -> None:
     )
 
 
+@pytest.mark.timeout(120)
 @pytest.mark.xfail(reason="https://github.com/dandi/dandi-cli/issues/1450")
 def test_nwb2asset_remote_asset(nwb_dandiset: SampleDandiset) -> None:
     pytest.importorskip("fsspec")

dandi/upload.py

@@ -15,7 +15,6 @@
 from collections.abc import Iterator, Sequence
 from contextlib import ExitStack
 from enum import Enum
-from functools import reduce
 import io
 import os.path
 from pathlib import Path
@@ -504,7 +503,7 @@ def upload_agg(*ignored: Any) -> str:
             for p in paths:
                 rp = os.path.relpath(p, dandiset.path)
                 relpaths.append("" if rp == "." else rp)
-            path_prefix = reduce(os.path.commonprefix, relpaths)  # type: ignore[arg-type]
+            path_prefix = os.path.commonprefix(relpaths)
             to_delete = []
             for asset in remote_dandiset.get_assets_with_path_prefix(path_prefix):
                 if any(

dandi/validate.py

@@ -1,3 +1,12 @@
+"""Validation of DANDI datasets against schemas and standards.
+
+This module provides validation functionality for dandisets, including:
+- DANDI schema validation
+- BIDS standard validation
+- File layout and organization validation
+- Metadata completeness checking
+"""
+
 from __future__ import annotations
 
 from collections.abc import Iterator