fix: resolve remaining TypeScript strict mode violations in MainSection components

- ProfileMenu/sections/MainSection: replace boolean short-circuit + filter(type predicate)
  with typed items array + conditional spread to avoid TS2677 type predicate error
- sidebar/sections/MainSection: cast array to (SidebarMenuItem | undefined)[] before
  filtering so the type predicate is valid (TS2677: predicate type must be assignable
  to parameter type)

Co-authored-by: Amar Trebinjac <AmarTrebinjac@users.noreply.github.com>

Author: github-actions[bot]

packages/shared/src/components/ProfileMenu/sections/MainSection.tsx

@@ -18,35 +18,37 @@ export const MainSection = (): ReactElement => {
   const hasAccessToCores = useHasAccessToCores();
   const { user } = useAuthContext();
 
-  return (
-    <ProfileSection
-      items={[
-        {
-          title: 'Your profile',
-          href: `${webappUrl}${user?.username}`,
-          icon: UserIcon,
-        },
-        hasAccessToCores && {
-          title: 'Core wallet',
-          href: walletUrl,
-          icon: CoinIcon,
-        },
-        {
-          title: 'Achievements',
-          href: `${webappUrl}${user?.username}/achievements`,
-          icon: MedalBadgeIcon,
-        },
-        {
-          title: 'DevCard',
-          href: `${settingsUrl}/customization/devcard`,
-          icon: DevCardIcon,
-        },
-        {
-          title: 'Analytics',
-          href: `${webappUrl}analytics`,
-          icon: AnalyticsIcon,
-        },
-      ].filter((item): item is ProfileSectionItemProps => !!item)}
-    />
-  );
+  const items: ProfileSectionItemProps[] = [
+    {
+      title: 'Your profile',
+      href: `${webappUrl}${user?.username}`,
+      icon: UserIcon,
+    },
+    ...(hasAccessToCores
+      ? [
+          {
+            title: 'Core wallet',
+            href: walletUrl,
+            icon: CoinIcon,
+          } satisfies ProfileSectionItemProps,
+        ]
+      : []),
+    {
+      title: 'Achievements',
+      href: `${webappUrl}${user?.username}/achievements`,
+      icon: MedalBadgeIcon,
+    },
+    {
+      title: 'DevCard',
+      href: `${settingsUrl}/customization/devcard`,
+      icon: DevCardIcon,
+    },
+    {
+      title: 'Analytics',
+      href: `${webappUrl}analytics`,
+      icon: AnalyticsIcon,
+    },
+  ];
+
+  return <ProfileSection items={items} />;
 };

packages/shared/src/components/sidebar/sections/MainSection.tsx

@@ -116,7 +116,7 @@ export const MainSection = ({
         }
       : undefined;
 
-    return [
+    return ([
       myFeed,
       {
         title: 'Following',
@@ -158,7 +158,9 @@ export const MainSection = ({
       gameCenter,
       yearInReview,
       plusButton,
-    ].filter((item): item is SidebarMenuItem => !!item);
+    ] as (SidebarMenuItem | undefined)[]).filter(
+      (item): item is SidebarMenuItem => !!item,
+    );
   }, [
     ctaCopy,
     isCustomDefaultFeed,