preprocess files, improve lang selector formatting

- preprocess files so gathered metadata is only generated once
- improve language selector
  - remove duplicates
  - sort entries
  - put each entry on a newline to make diffs easier to read
- these updates do result in changes to the legalcode files when the
  script is run, but the changes do NOT modify elements of the [Legal Code
  Defined - Creative Commons](https://creativecommons.org/legal-code-defined/)

Author: TimidRobot

tools/update_cc4_includes.py

@@ -46,6 +46,10 @@ class UpdateLicenseCode(object):
 
     languages = {}
 
+    license_data = {}
+
+    license_types = []
+
     iso_to_language = {
         "ar": "العربية",
         "be": "Беларуская",
@@ -58,7 +62,6 @@ class UpdateLicenseCode(object):
         "en": "English",
         "eo": "Esperanto",
         "es": "Español",
-        "es_ES": "Castellano (España)",
         "eu": "euskara",
         "fa": "پارسی",
         "fi": "suomeksi",
@@ -102,7 +105,6 @@ class UpdateLicenseCode(object):
         "en": "This page is available in the following languages:",
         "eo": "Ĉi tiu paĝo estas disponebla en la jenaj lingvoj:",
         "es": "Esta página está disponible en los siguientes idiomas:",
-        "es_ES": "",
         "eu": "Orri hau hizkuntza hauetan ikus daiteke:",
         "fa": "این صفحه به زبان های زیر در دسترس است : ",
         "fi": "Tämä sivu on saatavilla seuraavilla kielillä:",
@@ -181,6 +183,23 @@ def get_path(self):
 
     def process_files(self, filelist):
         """File processing loop"""
+        languages = {}
+        license_types = []
+        # pre-process
+        for filepath in filelist:
+            license_data = self.parse_filename(filepath)
+            type_ = license_data["type"]
+            license_types.append(type_)
+            if type_ not in languages:
+                languages[type_] = []
+            languages[type_].append(license_data["language"])
+            self.license_data[filepath] = license_data
+        # sort and store data
+        self.license_types = sorted(list(set(license_types)))
+        for type_ in self.license_types:
+            self.languages[type_] = []
+            self.languages[type_] = sorted(list(set(languages[type_])))
+        # process files
         for filepath in filelist:
             self.process_file(filepath)
 
@@ -232,50 +251,35 @@ def add_includes(self, content):
 
     def add_language_selector(self, content, filepath):
         """Build and insert a language selector dropdown list."""
-        # Get a list of all the other languages for this license type and store
-        # it so it can be reused.
-        license_data = self.parse_filename(filepath)
-        if license_data["type"] not in self.languages:
-            self.languages[license_data["type"]] = []
-            glob_string = (
-                f"{license_data['type']}_{license_data['version']}*.html"
-            )
-            language_file_list = [f for f in self.path.glob(glob_string)]
-            for filepath in language_file_list:
-                sibling_data = self.parse_filename(filepath)
-                self.languages[license_data["type"]].append(
-                    sibling_data["language"]
-                )
-            self.languages[license_data["type"]].sort()
-
+        license_data = self.license_data[filepath]
         current_language = license_data["language"]
         sibling_languages = self.languages[license_data["type"]]
 
         selector = (
             '<div id="language-selector-block" class="container">'
-            '  <div class="language-selector-inner">'
-            f"{self.lang_sel_text[current_language]}"
-            '    <img class="language-icon"'
-            ' src="/images/language_icon_x2.png" alt="Languages" />'
-            "    <select>"
+            '\n<div class="language-selector-inner">'
+            f"\n{self.lang_sel_text[current_language]}"
+            '\n<img class="language-icon"'
+            ' src="/images/language_icon_x2.png" alt="Languages">'
+            "\n<select>"
         )
         for iso_code in sibling_languages:
             # Set the selected option to the current language of the page
             selected = ""
             if iso_code == current_language:
-                selected = ' selected="selected" '
+                selected = ' selected="selected"'
             # Determine to option value for the language. English breaks the
             # pattern so handle it differently.
             option_value = f"legalcode.{iso_code}"
             if iso_code == "en":
                 option_value = "legalcode"
             # Add the selector vlaue
             selector = (
-                f'{selector}<option value="{option_value}"{selected}>'
+                f'{selector}\n<option value="{option_value}"{selected}>'
                 f"{self.iso_to_language[iso_code]}"
                 "</option>"
             )
-        selector = f"{selector}    </select>  </div></div>"
+        selector = f"{selector}\n</select>\n</div>\n</div>"
 
         # Add the language selector block to the content
         start, end = UpdateLicenseCode.placeholders["language-selector"]