Fix potential issues found by CodeQL

Change-Id: I6693b015826c70bb12621f99180fddce072b9ccf
Reviewed-on: https://review.couchbase.org/c/libcouchbase/+/224708
Reviewed-by: Jared Casey <jared.casey@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

Author: avsej

contrib/cbsasl/src/client.c

@@ -335,7 +335,11 @@ cbsasl_error_t cbsasl_client_step(cbsasl_conn_t *conn, const char *serverin, uns
             break;
     }
     *clientout = conn->c.client.userdata;
-    *clientoutlen = strlen(conn->c.client.userdata);
+    if (conn->c.client.userdata != NULL) {
+        *clientoutlen = strlen(conn->c.client.userdata);
+    } else {
+        *clientoutlen = 0;
+    }
 
     return SASL_CONTINUE;
 }

src/cntl.cc

@@ -384,6 +384,9 @@ HANDLER(force_sasl_mech_handler)
         if (arg) {
             const char *s = reinterpret_cast<const char *>(arg);
             instance->settings->sasl_mech_force = lcb_strdup(s);
+            if (instance->settings->sasl_mech_force == nullptr) {
+                return LCB_ERR_NO_MEMORY;
+            }
             for (char *p = instance->settings->sasl_mech_force; *p != '\0'; p++) {
                 if (*p == ',') {
                     *p = ' ';

tests/iotests/t_get.cc

@@ -1382,7 +1382,7 @@ TEST_F(GetUnitTest, testGetReplicaWithGroups)
         number_of_nodes = instance->cmdq.config->nsrv;
         if (number_of_nodes <= static_cast<std::size_t>(number_of_replicas)) {
             char buf[256]{};
-            snprintf(buf, 256, "number of nodes (%d) is less or equal to number of replicas",
+            snprintf(buf, 256, "number of nodes (%d) is less or equal to number of replicas (%d)",
                      static_cast<int>(number_of_nodes), number_of_replicas);
             MockEnvironment::printSkipMessage(__FILE__, __LINE__, buf);
             return;