CCBC-1666: do not schedule config request during shutdown

Change-Id: I828fd50b9d349968460bc2c47d81a0b941efa784
Reviewed-on: https://review.couchbase.org/c/libcouchbase/+/228818
Reviewed-by: Jared Casey <jared.casey@couchbase.com>
Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
Tested-by: Build Bot <build@couchbase.com>

Author: avsej

src/bucketconfig/bc_cccp.cc

@@ -288,14 +288,14 @@ lcb_STATUS CccpProvider::mcio_error(lcb_STATUS err)
     }
 
     stop_current_request(err == LCB_ERR_UNSUPPORTED_OPERATION);
-    if (err == LCB_ERR_PROTOCOL_ERROR && LCBT_SETTING(instance, conntype) == LCB_TYPE_CLUSTER) {
-        lcb_log(LOGARGS(this, WARN), LOGFMT "Failed to bootstrap using CCCP", LOGID(this));
+    if ((err == LCB_ERR_REQUEST_CANCELED && instance->destroying) ||
+        (err == LCB_ERR_PROTOCOL_ERROR && LCBT_SETTING(instance, conntype) == LCB_TYPE_CLUSTER)) {
+        lcb_log(LOGARGS(this, WARN), LOGFMT "Failed to bootstrap using CCCP: %s", LOGID(this), lcb_strerror_short(err));
         timer.cancel();
         parent->provider_failed(this, err);
         return err;
-    } else {
-        return schedule_next_request(err, /* can_rollover */ false, /* skip_if_push_supported */ false);
     }
+    return schedule_next_request(err, /* can_rollover */ false, /* skip_if_push_supported */ false);
 }
 
 /** Update the configuration from a server. */

src/bucketconfig/confmon.cc

@@ -214,6 +214,12 @@ int Confmon::do_set_next(ConfigInfo *new_config, bool notify_miss)
 
 void Confmon::provider_failed(Provider *provider, lcb_STATUS reason)
 {
+    if (instance->destroying) {
+        lcb_log(LOGARGS(this, INFO), "Provider '%s' failed: %s, but the instance is destroying ignoring the error",
+                provider_string(provider->type), lcb_strerror_short(reason));
+        stop();
+        return;
+    }
     lcb_log(LOGARGS(this, INFO), "Provider '%s' failed: %s", provider_string(provider->type),
             lcb_strerror_short(reason));