CCBC-1596: Fix dangling pointer in cbc-bucket-list

tools/cbc.cc:2048:28: warning: object backing the pointer will be destroyed at the end of the full-expression [-Wdangling-gsl]
        const char *name = json[i]["name"].asString().c_str();
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~
tools/cbc.cc:2049:34: warning: object backing the pointer will be destroyed at the end of the full-expression [-Wdangling-gsl]
        const char *bucketType = json[i]["bucketType"].asString().c_str();
                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Change-Id: Ife437d498e83778666f6911dafc8020a92f433a8
Reviewed-on: https://review.couchbase.org/c/libcouchbase/+/190104
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Brett Lawson <brett19@gmail.com>

Author: avsej

tools/cbc.cc

@@ -2044,11 +2044,11 @@ void BucketListHandler::format()
 
     printf("%-20s%-10s%s\n", "Name", "Type", "Items");
 
-    for (Json::Value::ArrayIndex i = 0; i < json.size(); ++i) {
-        const char *name = json[i]["name"].asString().c_str();
-        const char *bucketType = json[i]["bucketType"].asString().c_str();
-        const int itemCount = json[i]["basicStats"]["itemCount"].asInt();
-        printf("%-20s%-10s%i\n", name, bucketType, itemCount);
+    for (auto &bucket : json) {
+        auto name = bucket["name"].asString();
+        auto type = bucket["bucketType"].asString();
+        const int itemCount = bucket["basicStats"]["itemCount"].asInt();
+        printf("%-20s%-10s%i\n", name.c_str(), type.c_str(), itemCount);
     }
 }