CCBC-1592: allow to generate more randomized bodies in pillowfight

By default cbc-pillowfight pre-generates only one document body per
selected size. New option --random-body-pool-size allows to control how
many documents will be generated (default is 100).

This fixes behaviour in the corner case when --min-size equals
--max-size and allow still have many random bodies in this case.

Change-Id: If8dd15076950473f0539bea5037addafc6b6346e
Reviewed-on: https://review.couchbase.org/c/libcouchbase/+/189713
Reviewed-by: Dave Rigby <daver@couchbase.com>
Tested-by: Build Bot <build@couchbase.com>

Author: avsej

tools/cbc-pillowfight.cc

@@ -99,7 +99,8 @@ class Configuration
   public:
     Configuration()
         : o_multiSize("batch-size"), o_numItems("num-items"), o_keyPrefix("key-prefix"), o_numThreads("num-threads"),
-          o_randSeed("random-seed"), o_randomBody("random-body"), o_setPercent("set-pct"), o_minSize("min-size"),
+          o_randSeed("random-seed"), o_randomBody("random-body"), o_randomBodyPoolSize("random-body-pool-size"),
+          o_setPercent("set-pct"), o_minSize("min-size"),
           o_maxSize("max-size"), o_noPopulate("no-population"), o_numCycles("num-cycles"), o_sequential("sequential"),
           o_startAt("start-at"), o_rateLimit("rate-limit"), o_userdocs("docs"), o_writeJson("json"),
           o_templatePairs("template"), o_subdoc("subdoc"), o_noop("noop"), o_sdPathCount("pathcount"),
@@ -114,6 +115,9 @@ class Configuration
         o_randSeed.setDefault(0).abbrev('s').description("Specify random seed").hide();
         o_randomBody.setDefault(false).abbrev('R').description(
             "Randomize document body (otherwise use 'x' and '*' to fill)");
+        o_randomBodyPoolSize.setDefault(100).description(
+            "How many of randomized documents should be generated for each size in the range [min-size..max-size]. "
+            "Only used if --random-body is specified.");
         o_setPercent.setDefault(33).abbrev('r').description("The percentage of operations which should be mutations");
         o_minSize.setDefault(50).abbrev('m').description("Set minimum payload size");
         o_maxSize.setDefault(5120).abbrev('M').description("Set maximum payload size");
@@ -222,7 +226,8 @@ class Configuration
 
         if (specs.empty()) {
             if (o_writeJson.result()) {
-                docgen.reset(new JsonDocGenerator(o_minSize.result(), o_maxSize.result(), o_randomBody.numSpecified()));
+                docgen.reset(new JsonDocGenerator(o_minSize.result(), o_maxSize.result(), o_randomBody.numSpecified(),
+                                                  o_randomBodyPoolSize.result()));
             } else if (!userdocs.empty()) {
                 docgen.reset(new PresetDocGenerator(userdocs));
             } else {
@@ -232,7 +237,8 @@ class Configuration
             if (o_writeJson.result()) {
                 if (userdocs.empty()) {
                     docgen.reset(new PlaceholderJsonGenerator(o_minSize.result(), o_maxSize.result(), specs,
-                                                          o_randomBody.numSpecified()));
+                                                              o_randomBody.numSpecified(),
+                                                              o_randomBodyPoolSize.result()));
                 } else {
                     docgen.reset(new PlaceholderJsonGenerator(userdocs, specs));
                 }
@@ -262,6 +268,7 @@ class Configuration
         parser.addOption(o_numThreads);
         parser.addOption(o_randSeed);
         parser.addOption(o_randomBody);
+        parser.addOption(o_randomBodyPoolSize);
         parser.addOption(o_setPercent);
         parser.addOption(o_noPopulate);
         parser.addOption(o_minSize);
@@ -397,6 +404,7 @@ class Configuration
     UIntOption o_numThreads;
     UIntOption o_randSeed;
     BoolOption o_randomBody;
+    UIntOption o_randomBodyPoolSize;
     UIntOption o_setPercent;
     UIntOption o_minSize;
     UIntOption o_maxSize;

tools/docgen/docgen.h

@@ -259,18 +259,18 @@ class JsonDocGenerator : public PresetDocGenerator
      * @param minsz Minimum JSON document size
      * @param maxsz Maximum JSON document size
      */
-    JsonDocGenerator(uint32_t minsz, uint32_t maxsz, int rnd)
+    JsonDocGenerator(uint32_t minsz, uint32_t maxsz, int rnd, uint32_t pool_size)
     {
-        genDocuments(minsz, maxsz, m_docs, rnd);
+        genDocuments(minsz, maxsz, m_docs, rnd, pool_size);
         for (size_t ii = 0; ii < m_docs.size(); ++ii) {
             m_bufs.push_back(m_docs[ii].m_doc);
         }
     }
 
-    static void genDocuments(uint32_t minsz, uint32_t maxsz, std::vector< std::string > &out, int rnd)
+    static void genDocuments(uint32_t minsz, uint32_t maxsz, std::vector< std::string > &out, int rnd, uint32_t pool_size)
     {
         std::vector< Doc > docs;
-        genDocuments(minsz, maxsz, docs, rnd);
+        genDocuments(minsz, maxsz, docs, rnd, pool_size);
         for (size_t ii = 0; ii < docs.size(); ++ii) {
             out.push_back(docs[ii].m_doc);
         }
@@ -290,11 +290,13 @@ class JsonDocGenerator : public PresetDocGenerator
         *orig = std::max(0, *orig - static_cast< int >(toDecr));
     }
 
-    static void genDocuments(uint32_t minsz, uint32_t maxsz, std::vector< Doc > &out, int rnd)
+    static void genDocuments(uint32_t minsz, uint32_t maxsz, std::vector< Doc > &out, int rnd, uint32_t pool_size)
     {
         std::vector< size_t > sizes = RawDocGenerator::gen_graded_sizes(minsz, maxsz);
-        for (std::vector< size_t >::iterator ii = sizes.begin(); ii != sizes.end(); ++ii) {
-            out.push_back(generate(*ii, rnd));
+        for (const auto &size : sizes) {
+            for (uint32_t ii = 0; ii < pool_size; ++ii) {
+                out.push_back(generate(size, rnd));
+            }
         }
     }
 
@@ -487,11 +489,12 @@ class PlaceholderJsonGenerator : public PlaceholderDocGenerator
      * @param minsz Minimum document size
      * @param maxsz Maximum document size
      */
-    PlaceholderJsonGenerator(uint32_t minsz, uint32_t maxsz, const std::vector< TemplateSpec > &specs, int rnd)
+    PlaceholderJsonGenerator(uint32_t minsz, uint32_t maxsz, const std::vector<TemplateSpec> &specs, int rnd,
+                             uint32_t pool_size)
     {
 
         std::vector< std::string > jsondocs;
-        JsonDocGenerator::genDocuments(minsz, maxsz, jsondocs, rnd);
+        JsonDocGenerator::genDocuments(minsz, maxsz, jsondocs, rnd, pool_size);
         initJsonPlaceholders(specs, jsondocs);
     }