Repository navigation
Commit 8091fa5
committed
Plugins page: only show the loading skeleton on an actual tenant change
The reload-key restructure from the previous commit made every imperative
reload (a connect/disconnect panel's onChanged, the error screen's Retry)
re-run the fetch effect, which unconditionally set status: "loading" and
tore the page down to the full skeleton — a regression from main, where an
imperative reload just fetched and swapped in the result. Each effect now
tracks the tenant it last fetched for in a ref and only shows the loading
state when selectedTenantId actually changed; a same-tenant reload keeps
whatever is on screen until the fresh data (or a new error) lands.
Fixes CL-7138.1 parent 671564f commit 8091fa5
1 file changed
Lines changed: 16 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
108 | | - | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
109 | 117 | | |
110 | 118 | | |
111 | 119 | | |
112 | | - | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
113 | 123 | | |
114 | 124 | | |
115 | 125 | | |
| |||
126 | 136 | | |
127 | 137 | | |
128 | 138 | | |
129 | | - | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
130 | 142 | | |
131 | 143 | | |
132 | 144 | | |
| |||
0 commit comments