Repository navigation
Commit 233744e
authored
feat(workflow-schedule): emit cron TimerSet for schedule-triggered deployments (CL-8169) (#765)
* Add tests for the cron emitter's re-arm
A tick that fires re-arms from its own instant, so a slow or late fire
lands on the next tick after the one it ran rather than on one that has
already passed — the scheduler seam drops a past-due cron TimerSet as a
missed tick, so arming one would stall the schedule for good.
Claude-Session: https://claude.ai/code/session_01RweuMUskU2nvcFhdckc7EG
* workflow-schedule: emit the cron tick for schedule-triggered deployments
PR #761 deleted the hub's cron poller and left `@corbits/workflow-schedule`
with the grammar and `armCronTimer` but no emitter, so a schedule-triggered
workflow only fired via run-now.
`createCronEmitter` is that emitter: it reads the live schedule-triggered
deployments, arms each one's next tick, fires it, and re-arms from the
instant the tick fell on. A tick's identity is derived, not minted —
`timerIdForTick(deploymentId, fireAt)` is a pure function, so two emitters
arming the same tick name it the same thing.
Where it lives and why the fire is a trigger, not a seam TimerFired: the
`@intx/workflow-host` scheduler seam
(`vendor/intx/workflow-host/src/seams/scheduler.ts`) is constructed per
workflow-run child, scoped to that child's own run repo — see
`apps/sidecar/src/workflow-substrate-factory/index.ts`, which builds it
with `listActiveDeployments: () => [workflowRunRepoId]` — and the
supervisor is the sole writer of that ref. A `TimerFired` there unblocks a
`waitForTimer` inside a run that is already executing; it cannot start a
fresh one, and a definition cannot re-arm its own cron. So a tick that must
launch a run fires through the deployment's own native trigger, the same
signed-mail primitive `runNowScheduledDefinition` uses
(`apps/hub/src/native-workflow-routine-launch.ts`): a scheduled tick and a
run-now are now one primitive with a different clock.
The hub composition root supplies only the two host bindings the emitter
cannot own — which deployments are live
(`listDeployedCronDefinitions`, new in `@corbits/workflows`) and how a tick
fires — and no DB claim column comes back: the exactly-once column #761
dropped stays dropped.
Claude-Session: https://claude.ai/code/session_01RweuMUskU2nvcFhdckc7EG1 parent b888616 commit 233744e
9 files changed
Lines changed: 424 additions & 10 deletions
File tree
- apps/hub
- src
- packages
- workflow-schedule
- src
- workflows/src
- schedule
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | | - | |
| 28 | + | |
28 | 29 | | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
| 34 | + | |
33 | 35 | | |
34 | 36 | | |
35 | 37 | | |
| 38 | + | |
36 | 39 | | |
37 | 40 | | |
38 | | - | |
39 | 41 | | |
| 42 | + | |
40 | 43 | | |
41 | 44 | | |
42 | 45 | | |
| |||
54 | 57 | | |
55 | 58 | | |
56 | 59 | | |
| 60 | + | |
57 | 61 | | |
| 62 | + | |
58 | 63 | | |
59 | 64 | | |
60 | 65 | | |
| |||
67 | 72 | | |
68 | 73 | | |
69 | 74 | | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | 75 | | |
75 | 76 | | |
76 | 77 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
230 | 230 | | |
231 | 231 | | |
232 | 232 | | |
| 233 | + | |
| 234 | + | |
233 | 235 | | |
234 | 236 | | |
235 | 237 | | |
| |||
263 | 265 | | |
264 | 266 | | |
265 | 267 | | |
266 | | - | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
267 | 273 | | |
268 | 274 | | |
269 | 275 | | |
| |||
2307 | 2313 | | |
2308 | 2314 | | |
2309 | 2315 | | |
| 2316 | + | |
| 2317 | + | |
| 2318 | + | |
| 2319 | + | |
| 2320 | + | |
| 2321 | + | |
| 2322 | + | |
| 2323 | + | |
| 2324 | + | |
| 2325 | + | |
| 2326 | + | |
| 2327 | + | |
| 2328 | + | |
| 2329 | + | |
| 2330 | + | |
| 2331 | + | |
| 2332 | + | |
| 2333 | + | |
| 2334 | + | |
| 2335 | + | |
| 2336 | + | |
| 2337 | + | |
| 2338 | + | |
| 2339 | + | |
| 2340 | + | |
| 2341 | + | |
| 2342 | + | |
| 2343 | + | |
| 2344 | + | |
| 2345 | + | |
| 2346 | + | |
| 2347 | + | |
| 2348 | + | |
| 2349 | + | |
| 2350 | + | |
| 2351 | + | |
2310 | 2352 | | |
2311 | 2353 | | |
2312 | 2354 | | |
| |||
2347 | 2389 | | |
2348 | 2390 | | |
2349 | 2391 | | |
| 2392 | + | |
2350 | 2393 | | |
2351 | 2394 | | |
2352 | 2395 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
0 commit comments