diff --git a/plugins/corbits-skills/skills/git-worktrees/SKILL.md b/plugins/corbits-skills/skills/git-worktrees/SKILL.md index 13c551062..c866540e9 100644 --- a/plugins/corbits-skills/skills/git-worktrees/SKILL.md +++ b/plugins/corbits-skills/skills/git-worktrees/SKILL.md @@ -7,7 +7,7 @@ description: Create and tear down a worktree from origin/. Load # git-worktrees -How to create a worktree from origin/ and tear it down. Load via `use_skill("git-worktrees")` and copy commands into a coder brief. The coder executes via `run_shell`. Do not run the git on the parent. +Every workflow that writes code or checks out a branch works in a worktree, not the main checkout. Load this with `use_skill("git-worktrees")` and run the commands through `bash`. ## Create from origin/ @@ -17,7 +17,7 @@ git fetch origin git worktree add ../worktree/ -b origin/ ``` -Always base new branches on `origin/` (whatever the repository uses). After creating the worktree, the coder `cd`s into it and installs local dependencies (`bun install` when the project uses Bun; otherwise follow developer docs). Worktrees do not share `node_modules`. +Always base new branches on `origin/` (whatever the repository uses); a stacked branch bases on the previous branch instead. After creating the worktree, `cd` into it and install local dependencies (`bun install` when the project uses Bun; otherwise follow developer docs). Worktrees do not share `node_modules`. ## Teardown diff --git a/plugins/corbits-skills/skills/implement/SKILL.md b/plugins/corbits-skills/skills/implement/SKILL.md index 24f5ff5d0..1ad6a1527 100644 --- a/plugins/corbits-skills/skills/implement/SKILL.md +++ b/plugins/corbits-skills/skills/implement/SKILL.md @@ -7,6 +7,10 @@ description: Per-commit workflow with planner review, build gate, and reviewer l A disciplined implementation workflow that produces reviewed, verified commits. Load this skill when you want each commit to go through architectural review, build verification, and code review before it lands. +## Preflight + +Requires a git repo. Run `git rev-parse --show-toplevel`; if it fails, stop and tell the operator to `git init` first. Work in a worktree from `origin/`, never in the main checkout: `use_skill("git-worktrees")` for the commands. + ## Prerequisites Before using this workflow, load the `style` and `philosophy` skills. Follow their conventions throughout. diff --git a/plugins/corbits-skills/skills/native-integration/SKILL.md b/plugins/corbits-skills/skills/native-integration/SKILL.md index 2bfcf4f91..3d7463725 100644 --- a/plugins/corbits-skills/skills/native-integration/SKILL.md +++ b/plugins/corbits-skills/skills/native-integration/SKILL.md @@ -1,6 +1,6 @@ --- name: native-integration -description: Corbits rules for non-git folders, Linear status, tracker-agnostic issues, and posting reviews on GitHub +description: Corbits rules for Linear status, tracker-agnostic issues, and posting reviews on GitHub user-invocable: false --- @@ -26,10 +26,6 @@ Move the issue to In Review when the PR is ready for review. Draft or WIP PRs st `linear-issue-workflow` owns the full Linear ship loop. -## Non-git folders - -A folder without `.git` is a valid working directory (scratch, unpacked tarball, new project). Git-using skills (`implement`, `review`, `pull-request`) no-op or ask when they need a repo. Do not invent a git repo to satisfy them. - ## Tracker-agnostic issues `/issue` is not Linear-only: diff --git a/plugins/corbits-skills/skills/plan/SKILL.md b/plugins/corbits-skills/skills/plan/SKILL.md index dfd430a70..676f82f41 100644 --- a/plugins/corbits-skills/skills/plan/SKILL.md +++ b/plugins/corbits-skills/skills/plan/SKILL.md @@ -7,6 +7,8 @@ description: Author an eng change plan. Does not implement or file issues. How to produce an engineering change plan. Does not implement. Does not file tracker issues. +Requires a git repo. Run `git rev-parse --show-toplevel`; if it fails, stop and tell the operator to `git init` first. + If the change target is too fuzzy to plan, `ask_operator` first. ## What the plan must contain diff --git a/plugins/corbits-skills/skills/refactor/SKILL.md b/plugins/corbits-skills/skills/refactor/SKILL.md index d4e49cea5..214f59440 100644 --- a/plugins/corbits-skills/skills/refactor/SKILL.md +++ b/plugins/corbits-skills/skills/refactor/SKILL.md @@ -8,6 +8,10 @@ description: Document a directory's design and plan improvements with the operat Use this skill to analyze existing code, produce a structured design document, and collaboratively plan improvements for future implementation. +## Preflight + +Requires a git repo. Run `git rev-parse --show-toplevel`; if it fails, stop and tell the operator to `git init` first. Work in a worktree from `origin/`, never in the main checkout: `use_skill("git-worktrees")` for the commands. + ## Initialization Before doing anything else, load the `philosophy` skill. The principles in that skill guide how you evaluate design decisions. diff --git a/plugins/corbits-skills/skills/review/SKILL.md b/plugins/corbits-skills/skills/review/SKILL.md index 7b2a52d99..3feeb1ee2 100644 --- a/plugins/corbits-skills/skills/review/SKILL.md +++ b/plugins/corbits-skills/skills/review/SKILL.md @@ -7,6 +7,8 @@ description: Review a branch or pull request diff and report findings. Use this skill when performing code reviews or pull request reviews. +Requires a git repo. Run `git rev-parse --show-toplevel`; if it fails, stop and tell the operator to `git init` first. + ## Classify, Then Recommend a Selected Fleet First classify the review target, then recommend only the fleet the