fix(logging): restore terminal follow-up failure log

A final steer whose promise rejects was silent after settlement. Log that
failure again with the same id and error shape as the handoff path, and
drop the narration comments added with the collapse.

Author: TheGreatAxios

src/logging/caught.ts

@@ -1,6 +1,3 @@
-// Shared hunter for the "best-effort step failed" debug catch: callers keep
-// their message; the helper owns the caught-value normalization-and-append
-// shape so that boilerplate exists once, not per site.
 interface DebugSink {
   debug: (message: string, properties?: Record<string, unknown>) => void;
 }

src/permission/approval-store-migration.ts

@@ -192,7 +192,6 @@ export async function migratePersistedApprovalStores(
       });
     }
   }
-  // One summary warn per migration, not one per store file.
   const failed = files.filter((file) => file.error !== undefined);
   if (failed.length > 0) {
     log.warn("Skipped approval-store migration: {details}", {

src/session/runtime-assembly.ts

@@ -149,9 +149,7 @@ export async function loadSeededApprovals(
   // residual throw from breaking session start.
   try {
     await migratePersistedApprovalStores(cwd, sessionId, home);
-  } catch {
-    // Swallowed on purpose: the migration already surfaced the cause.
-  }
+  } catch {}
   const sessionApprovals = await loadApprovals(cwd, sessionId, home);
   const [
     projectApprovals,

src/subagent/session-store.test.ts

@@ -1,4 +1,6 @@
-import { describe, expect, test } from "bun:test";
+import { describe, expect, spyOn, test } from "bun:test";
+import { getLogger } from "@intx/log";
+import { LOG_NAMESPACE_ROOT } from "../branding.js";
 
 import {
   createSubAgentSessionStore,
@@ -656,24 +658,36 @@ describe("CL-6943 reusable worker sessions", () => {
   });
 
   test("rejected followup restores strip status so interrupt_agent fails closed", async () => {
-    const store = createSubAgentSessionStore();
-    const session = retainedSession(store, {
-      interrupt: true,
-      followup: async () => {
-        throw new Error("send failed");
-      },
-      complete: "## Summary\nDone.",
-    });
-    resumeCompleted(store, session.id);
-    await new Promise((resolve) => setTimeout(resolve, 0));
-
-    const after = store.get(session.id);
-    expect(after?.status).toBe("done");
-    expect(after?.lifecycleStatus).toBe("completed");
-    expect(store.interruptOne(session.id)).toEqual({
-      ok: false,
-      status: "completed",
-    });
+    const errorLog = spyOn(
+      getLogger([LOG_NAMESPACE_ROOT, "subagent", "session-store"]),
+      "error",
+    );
+    try {
+      const store = createSubAgentSessionStore();
+      const session = retainedSession(store, {
+        interrupt: true,
+        followup: async () => {
+          throw new Error("send failed");
+        },
+        complete: "## Summary\nDone.",
+      });
+      resumeCompleted(store, session.id);
+      await new Promise((resolve) => setTimeout(resolve, 0));
+
+      const after = store.get(session.id);
+      expect(after?.status).toBe("done");
+      expect(after?.lifecycleStatus).toBe("completed");
+      expect(store.interruptOne(session.id)).toEqual({
+        ok: false,
+        status: "completed",
+      });
+      expect(errorLog).toHaveBeenCalledWith(
+        "followup turn failed for {id}: {error}",
+        { id: session.id, error: "send failed" },
+      );
+    } finally {
+      errorLog.mockRestore();
+    }
   });
 
   test("rejected followup after interrupt restamps stopReason interrupted", async () => {

src/subagent/session-store.ts

@@ -1289,6 +1289,10 @@ export function createSubAgentSessionStore(
     }
     endFollowupTurn(id, failLifecycle);
     pendingFailures.delete(id);
+    log.error("followup turn failed for {id}: {error}", {
+      id,
+      error: errorMessage(err),
+    });
   };
   const queueFollowupTurn = (
     id: string,

src/trust/project-trust.ts

@@ -52,8 +52,7 @@ const emptyStore = (): ProjectTrustStore => ({
 
 /**
  * Extract a schema-confirmed array field: missing → [], non-strings dropped.
- * Hand-edited partial files must not wipe consent. Issues accumulate on
- * `issues` for the caller's one summary warn per store.
+ * Hand-edited partial files must not wipe consent.
  */
 function extractStringArrayField(
   value: unknown[] | undefined,
@@ -147,8 +146,6 @@ export async function readProjectTrustStore(
     logger.warn`project trust store has an invalid shape at ${path}: ${validated.summary}`;
     return { state: "invalid", store: emptyStore() };
   }
-  // Field/entry issues collect; the store gets one summary warn, not one
-  // per field or entry.
   const issues: string[] = [];
   const trustedPluginPaths = extractStringArrayField(
     validated.trustedPluginPaths,
@@ -193,7 +190,6 @@ export async function readProjectTrustStore(
       `trustedPluginPaths: dropped ${nonAbsolute} non-absolute entries`,
     );
   }
-  // One summary warn per store, not one warn per field or per entry.
   if (issues.length > 0) {
     logger.warn`project trust store issues at ${path} (${issues.length}): ${issues.join("; ")}`;
   }

src/tui/runner/submit.ts

@@ -55,20 +55,14 @@ import {
   type RunnerState,
 } from "./state.js";
 import { LOG_NAMESPACE_ROOT } from "../../branding.js";
+import { caughtDebug } from "../../logging/caught.js";
 import { buildCredentialRecoveryAlternatives } from "./credential-recovery.js";
 import type { PendingCredentialRecovery } from "./credential-recovery.js";
 import type { PendingReconnectRecovery } from "./reconnect-recovery.js";
 import { listCommands } from "../commands/registry.js";
 
 const tuiLogger = getLogger([LOG_NAMESPACE_ROOT, "tui"]);
 
-// Shared tail for both recordSent paths; append is best-effort recall.
-const logSentAppendFailure = (err: unknown): void => {
-  tuiLogger.debug("sent-message append failed: {error}", {
-    error: err instanceof Error ? err.message : String(err),
-  });
-};
-
 export type SubmissionRoute =
   | { kind: "empty" }
   | { kind: "command"; name: string; args: string }
@@ -454,7 +448,7 @@ export function createSubmitPath(
     state.sendAborted = false;
     if (text.trim().length > 0) {
       void appendSentMessage(state.config.cwd, state.sessionId, text).catch(
-        logSentAppendFailure,
+        caughtDebug(tuiLogger, "sent-message append failed"),
       );
     }
     const ingested = await ingestOperatorPrompt(
@@ -550,7 +544,7 @@ export function createDeliverRouting(
         if (text.startsWith(ASK_DIRECTOR_WAKE_PREFIX)) return;
         if (text.startsWith(MAILBOX_MAIL_WAKE_PREFIX)) return;
         void appendSentMessage(state.config.cwd, state.sessionId, text).catch(
-          logSentAppendFailure,
+          caughtDebug(tuiLogger, "sent-message append failed"),
         );
       },
       captureGeneration: services.deliveryGeneration.capture,