Skip to content

Commit e24d46f

Browse files
committed
test(tui): settle Esc-closed gates as abandoned, not denied
1 parent 0b0857a commit e24d46f

2 files changed

Lines changed: 8 additions & 9 deletions

File tree

‎src/tui/gate-wire.test.ts‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -550,7 +550,7 @@ describe("wireGates", () => {
550550
).toEqual(["Reject", "Accept once", "Allow git A"]);
551551

552552
closeInsetOverlay(shell);
553-
expect(resolvedA).toEqual({ allow: false });
553+
expect(resolvedA).toBeUndefined();
554554
expect(shell.overlayList).toBeNull();
555555

556556
emitter.emit("permission.gate", {
@@ -621,7 +621,7 @@ describe("wireGates", () => {
621621
},
622622
});
623623
closeInsetOverlay(shell);
624-
expect(resolvedA).toEqual({ allow: false });
624+
expect(resolvedA).toBeUndefined();
625625
expect(shell.overlayList).toBeNull();
626626

627627
emitter.emit("permission.gate", {
@@ -1674,7 +1674,7 @@ describe("operator.gate auto-cancel", () => {
16741674
});
16751675

16761676
describe("Esc on a gate overlay settles the awaited promise", () => {
1677-
test("permission.gate: Esc denies instead of abandoning the promise", async () => {
1677+
test("permission.gate: Esc abandons instead of denying", async () => {
16781678
await withTestRenderer(async (h) => {
16791679
const shell = createAppShell(h.renderer, {
16801680
terminal: { columns: 80, rows: 24 },
@@ -1699,8 +1699,7 @@ describe("Esc on a gate overlay settles the awaited promise", () => {
16991699

17001700
expect(shell.overlayList).toBeNull();
17011701
expect(resolveCount).toBe(1);
1702-
expect(resolved).toEqual({ allow: false });
1703-
expect(resolved).not.toEqual(unavailable);
1702+
expect(resolved).toBeUndefined();
17041703
} finally {
17051704
shell.dispose();
17061705
}

‎src/tui/slash-popup-gate.test.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,7 @@ describe("slash/palette accept holds the host until dispatch settles", () => {
438438
closeInsetOverlay(shell);
439439
await Promise.resolve();
440440
expect(shell.overlayKind).toBe("help");
441-
expect(resolved).toEqual({ allow: false });
441+
expect(resolved).toBeUndefined();
442442
} finally {
443443
dispose();
444444
}
@@ -657,7 +657,7 @@ describe("slash/palette accept holds the host until dispatch settles", () => {
657657
closeInsetOverlay(shell);
658658
await Promise.resolve();
659659
expect(shell.overlayKind).toBe("settings");
660-
expect(resolved).toEqual({ allow: false });
660+
expect(resolved).toBeUndefined();
661661
} finally {
662662
dispose();
663663
}
@@ -720,7 +720,7 @@ describe("slash/palette accept holds the host until dispatch settles", () => {
720720
closeInsetOverlay(shell);
721721
await Promise.resolve();
722722
expect(shell.overlayKind).toBe("mcp");
723-
expect(resolved).toEqual({ allow: false });
723+
expect(resolved).toBeUndefined();
724724
} finally {
725725
dispose();
726726
}
@@ -1162,7 +1162,7 @@ describe("overlay host occupancy and opt-in deferral", () => {
11621162
closeInsetOverlay(shell);
11631163
await Promise.resolve();
11641164
expect(shell.overlayKind).toBe("add_provider");
1165-
expect(resolved).toEqual({ allow: false });
1165+
expect(resolved).toBeUndefined();
11661166
} finally {
11671167
dispose();
11681168
}

0 commit comments

Comments
 (0)