You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit c9f666b
Browse filesBrowse the repository at this point in the historyBrowse files
Copy file name to clipboardExpand all lines: plugins/corbits-skills/skills/implement/SKILL.md
+33-33Lines changed: 33 additions & 33 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,11 +1,11 @@
1
1
---
2
2
name: implement
3
-
description: Disciplined per-commit workflow with Greybeard review, build gates, and Critique loops
3
+
description: Disciplined per-commit workflow with Planner review, build gates, and Reviewer loops
4
4
---
5
5
6
6
# Implement
7
7
8
-
A disciplined implementation workflow that produces reviewed, verified commits. Load this skill when you want each commit to go through architectural review, build verification, and code critique before it lands.
8
+
A disciplined implementation workflow that produces reviewed, verified commits. Load this skill when you want each commit to go through architectural review, build verification, and code review before it lands.
9
9
10
10
## Prerequisites
11
11
@@ -19,43 +19,43 @@ The caller defines what work to do and where the commit boundaries are. This ski
19
19
20
20
## Tracking Progress
21
21
22
-
Use `TaskCreate`, `TaskUpdate`, and `TaskList`to track progress throughout the workflow. These tools give the user real-time visibility into what you're doing.
22
+
Use `manage_tasks`to track progress throughout the workflow. It gives the user real-time visibility into what you're doing.
23
23
24
24
### Initial Planning
25
25
26
-
Before starting implementation, use `TaskCreate` for each commit-sized unit of work from the caller's instructions:
26
+
Before starting implementation, use `manage_tasks` to add each commit-sized unit of work from the caller's instructions:
27
27
28
-
-**subject**: Clear imperative description of the unit of work
28
+
-**title**: Clear imperative description of the unit of work
29
29
-**description**: Enough context that you could pick it up cold
30
-
-**activeForm**: Present continuous form for the spinner (e.g., "Refactoring HTTP client retry logic")
30
+
-**active form**: Present continuous form for the status line (e.g., "Refactoring HTTP client retry logic")
31
31
32
32
### During the Per-Commit Workflow
33
33
34
-
When you begin a unit of work, mark its task `in_progress` with `TaskUpdate`. As you move through the workflow steps, update the task's `activeForm` to reflect which step you're in:
34
+
When you begin a unit of work, mark its task `in_progress` with `manage_tasks`. As you move through the workflow steps, update the task's active form to reflect which step you're in:
35
35
36
-
-**Step 1**: "Reviewing approach with Greybeard: {subject}"
36
+
-**Step 1**: "Reviewing approach with Planner: {subject}"
37
37
-**Step 2**: "Implementing: {subject}"
38
38
-**Step 3**: "Running build gate: {subject}"
39
39
-**Step 4**: "Committing: {subject}"
40
-
-**Step 5**: "Running Critique loop: {subject}"
40
+
-**Step 5**: "Running Reviewer loop: {subject}"
41
41
42
-
When the commit lands and Critique is clean, mark the task `completed`.
42
+
When the commit lands and Reviewer is clean, mark the task `completed`.
43
43
44
44
### Discovered Work
45
45
46
-
If new work surfaces during implementation (Greybeard suggests a preparatory refactor, Critique reveals a missing edge case that warrants its own commit), create a new task with `TaskCreate` and work it through the full per-commit workflow.
46
+
If new work surfaces during implementation (Planner suggests a preparatory refactor, Reviewer reveals a missing edge case that warrants its own commit), add a new task with `manage_tasks` and work it through the full per-commit workflow.
47
47
48
48
## Workflow Per Commit
49
49
50
50
For each logical unit of work that results in a commit, follow these steps in order. Do not skip steps.
51
51
52
-
### Step 1: Greybeard Review
52
+
### Step 1: Planner Review
53
53
54
-
Mark the task `in_progress` and set `activeForm`to "Reviewing approach with Greybeard: {subject}".
54
+
Mark the task `in_progress` and set the active form to "Reviewing approach with Planner: {subject}".
55
55
56
-
Before writing any code, describe your implementation approach to Greybeard and ask for feedback.
56
+
Before writing any code, describe your implementation approach to Planner and ask for feedback.
57
57
58
-
**What to send Greybeard:**
58
+
**What to send Planner:**
59
59
60
60
- What you're about to change and why
61
61
- Which files you expect to touch
@@ -64,16 +64,16 @@ Before writing any code, describe your implementation approach to Greybeard and
64
64
65
65
**How to handle feedback:**
66
66
67
-
- If Greybeard identifies problems with your approach, adjust before proceeding
68
-
- If Greybeard suggests a fundamentally different approach, consider it seriously
67
+
- If Planner identifies problems with your approach, adjust before proceeding
68
+
- If Planner suggests a fundamentally different approach, consider it seriously
69
69
- You don't need to agree with every suggestion, but you need a reason to disagree
70
70
- Once you're aligned on approach, move to Step 2
71
71
72
-
Use the `@greybeard` subagent for this step.
72
+
Use `spawn_agent(agent="planner")` for this step.
73
73
74
74
### Step 2: Implement and Test
75
75
76
-
Update `activeForm` to "Implementing: {subject}".
76
+
Update the active form to "Implementing: {subject}".
77
77
78
78
The order of operations depends on whether you're fixing a bug or building a feature. In both cases, follow the repository's existing test conventions — look at how existing tests are structured, where they live, what framework they use, and match that style. If the repository has no existing tests, ask the caller what test framework and conventions to use before proceeding.
79
79
@@ -98,7 +98,7 @@ Keep the scope tight to what was discussed. If you discover additional work is n
98
98
99
99
### Step 3: Build Gate
100
100
101
-
Update `activeForm` to "Running build gate: {subject}".
101
+
Update the active form to "Running build gate: {subject}".
102
102
103
103
Run `make` (or the project's equivalent full pipeline: format, lint, build, test).
104
104
@@ -111,19 +111,19 @@ Run `make` (or the project's equivalent full pipeline: format, lint, build, test
111
111
112
112
### Step 4: Commit
113
113
114
-
Update `activeForm` to "Committing: {subject}".
114
+
Update the active form to "Committing: {subject}".
115
115
116
116
Create the commit. Follow the commit message conventions from the `style` skill. Include the test in the same unit of work as the implementation — same commit when committing — one logical unit — and update the docs when the commit changes documented behavior. Worker-chain branch/PR convention: branch name carries the issue id, the PR body ends with `Fixes CL-…` and carries no AI-attribution lines (CONTRIBUTING: title is a Conventional Commits subject, body is Summary/Verification).
Update the active form to "Running Reviewer loop: {subject}".
121
121
122
-
Ask Critique to review the committed change.
122
+
Ask Reviewer to review the committed change.
123
123
124
124
**How to run:**
125
125
126
-
1.Spawn the `@critique` subagent and ask it to review the output of `git show HEAD`. Include the intent from Step 1 (what the change is meant to accomplish and the approach agreed with Greybeard) so Critique can evaluate whether the implementation matches the plan, not just surface-level quality. Tell Critique to limit its findings to the scope of the current commit -- pre-existing issues in touched files are out of scope.
126
+
1.Use `spawn_agent(agent="reviewer")` to ask it to review the output of `git show HEAD`. Include the intent from Step 1 (what the change is meant to accomplish and the approach agreed with Planner) so Reviewer can evaluate whether the implementation matches the plan, not just surface-level quality. Tell Reviewer to limit its findings to the scope of the current commit -- pre-existing issues in touched files are out of scope.
127
127
2. Read its findings
128
128
3. For each issue marked VERIFIED or HIGH confidence: fix it
129
129
4. Re-run the build gate (Step 3) to verify fixes
@@ -140,30 +140,30 @@ Ask Critique to review the committed change.
140
140
141
141
If the situation calls for more elaborate history surgery, search your available skills for one whose description covers git rebase or branch-history cleanup, and load it. Re-run the build gate after the rebase completes.
142
142
143
-
6. Ask Critique to review `git show HEAD` again. Re-include the original intent from Step 1 and tell it what you fixed since the last pass so it can focus on verifying the fixes and checking for new issues rather than re-reviewing the entire change from scratch.
144
-
7. Repeat until Critique comes back clean or all remaining findings are acknowledged and intentional
143
+
6. Ask Reviewer to review `git show HEAD` again. Re-include the original intent from Step 1 and tell it what you fixed since the last pass so it can focus on verifying the fixes and checking for new issues rather than re-reviewing the entire change from scratch.
144
+
7. Repeat until Reviewer comes back clean or all remaining findings are acknowledged and intentional
145
145
146
146
**When to stop looping:**
147
147
148
-
-Critique reports no issues
148
+
-Reviewer reports no issues
149
149
- Remaining findings are judgment calls you've consciously decided against, not oversights
150
150
- The build passes after the last round of fixes
151
151
152
152
### Step 6: Next
153
153
154
-
Mark the current task `completed` with `TaskUpdate`. Move to the next unit of work and return to Step 1.
154
+
Mark the current task `completed` with `manage_tasks`. Move to the next unit of work and return to Step 1.
155
155
156
156
## Guidelines
157
157
158
-
**Don't shortcut the loop.** The value is in the discipline. Skipping Greybeard "because this change is simple" or skipping Critique "because the build passes" defeats the purpose.
158
+
**Don't shortcut the loop.** The value is in the discipline. Skipping Planner "because this change is simple" or skipping Reviewer "because the build passes" defeats the purpose.
159
159
160
-
**Keep commits focused, but do not drop findings.** When Critique surfaces something outside the current commit's scope, every finding must be assigned one of four dispositions: (a) fix in the current commit, (b) commit it separately on this branch, (c) file a new issue with concrete acceptance criteria, or (d) accept it as-is. "Out of scope" is not a disposition. "Note it for later" is not a disposition unless you also say which of (a)–(d) "later" means.
160
+
**Keep commits focused, but do not drop findings.** When Reviewer surfaces something outside the current commit's scope, every finding must be assigned one of four dispositions: (a) fix in the current commit, (b) commit it separately on this branch, (c) file a new issue with concrete acceptance criteria, or (d) accept it as-is. "Out of scope" is not a disposition. "Note it for later" is not a disposition unless you also say which of (a)–(d) "later" means.
161
161
162
-
**Disposition (d) always requires operator approval** — neither you nor greybeard can drop a finding on your own. For (c), the issue must be filed in this session, with its ID or URL in the status update; a promise to file it later is dropping the work. If you are orchestrated by karen, route the decision through karen's section 9 procedure (consult greybeard, paste his recommendation verbatim, escalate to the operator for any "accept as-is" or any unclear answer). If you are running directly, consult the operator before choosing (c) or (d).
162
+
**Disposition (d) always requires operator approval** — neither you nor planner can drop a finding on your own. For (c), the issue must be filed in this session, with its ID or URL in the status update; a promise to file it later is dropping the work. If you are orchestrated by karen, route the decision through karen's section 9 procedure (consult planner, paste his recommendation verbatim, escalate to the operator for any "accept as-is" or any unclear answer). If you are running directly, consult the operator before choosing (c) or (d).
163
163
164
164
**Build must pass before every commit, amend, and rebase stop.** Never commit code that doesn't compile or pass tests. Fix build failures first, then commit, amend, or continue the rebase.
165
165
166
-
**Greybeard is for approach, Critique is for execution.**Greybeard reviews your plan before you write code. Critique reviews your code after you write it. Don't conflate the two.
166
+
**Planner is for approach, Reviewer is for execution.**Planner reviews your plan before you write code. Reviewer reviews your code after you write it. Don't conflate the two.
Copy file name to clipboardExpand all lines: plugins/corbits-skills/skills/interview/SKILL.md
+4-6Lines changed: 4 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,14 +1,12 @@
1
1
---
2
2
name: interview
3
3
argument-hint: "<topic>[; <context>]"
4
-
description: Conduct an iterative multiple-choice interview using AskUserQuestion. Returns the Q&A inline. Use as a utility when a caller needs structured user input on a topic.
5
-
tools:
6
-
- AskUserQuestion
4
+
description: Conduct an iterative multiple-choice interview using `ask_operator`. Returns the Q&A inline. Use as a utility when a caller needs structured user input on a topic.
7
5
---
8
6
9
7
# Interview
10
8
11
-
Use this skill to gather user input on a topic by asking multiple-choice questions in batches via `AskUserQuestion`. Return the questions and answers in the conversation. The caller decides what to do with them.
9
+
Use this skill to gather user input on a topic by asking multiple-choice questions in batches via `ask_operator`. Return the questions and answers in the conversation. The caller decides what to do with them.
12
10
13
11
This is a utility, not a planner. It does not decide what to build, write any files, or invoke other skills.
14
12
@@ -31,7 +29,7 @@ Probe objective and priorities before details. They shape every later question,
31
29
32
30
### Ask in batches
33
31
34
-
Each round uses `AskUserQuestion`. Refer to the tool's own documentation for parameter limits and multi-select behavior.
32
+
Each round uses `ask_operator`. Refer to the tool's own documentation for parameter limits and multi-select behavior.
35
33
36
34
**Quality bar for options:**
37
35
@@ -95,7 +93,7 @@ After emitting the findings, stop. Do not load other skills, invoke other agents
95
93
**Round 1** (3 questions, bundled because none depends on the others):
96
94
97
95
```
98
-
AskUserQuestion([
96
+
ask_operator([
99
97
{ header: "Goal", question: "What is the primary goal of the notification system?",
0 commit comments