|
| 1 | +import { afterEach, describe, expect, mock, spyOn, test } from "bun:test"; |
| 2 | +import { mkdtemp, readFile, rm, writeFile } from "node:fs/promises"; |
| 3 | +import { tmpdir } from "node:os"; |
| 4 | +import { join } from "node:path"; |
| 5 | +import { SETTINGS_DIR_NAME } from "../branding.js"; |
| 6 | +import { generateSessionId, initSessionDir } from "../session/index.js"; |
| 7 | +import { loadSeededApprovals } from "../session/runtime-assembly.js"; |
| 8 | +import { createPermissionsAdmin } from "./admin.js"; |
| 9 | +import { createPermissionGate } from "./gate.js"; |
| 10 | +import * as permissionStore from "./store.js"; |
| 11 | + |
| 12 | +describe("createPermissionsAdmin --permissions reseed", () => { |
| 13 | + let cwd = ""; |
| 14 | + let home = ""; |
| 15 | + |
| 16 | + afterEach(async () => { |
| 17 | + mock.restore(); |
| 18 | + if (cwd !== "") await rm(cwd, { recursive: true, force: true }); |
| 19 | + if (home !== "") await rm(home, { recursive: true, force: true }); |
| 20 | + cwd = ""; |
| 21 | + home = ""; |
| 22 | + }); |
| 23 | + |
| 24 | + test("revoking a project grant keeps the file grant and does not restore or edit user grants", async () => { |
| 25 | + cwd = await mkdtemp(join(tmpdir(), "perm-admin-")); |
| 26 | + home = await mkdtemp(join(tmpdir(), "perm-admin-home-")); |
| 27 | + const sessionId = generateSessionId(); |
| 28 | + await initSessionDir(cwd, sessionId, home); |
| 29 | + |
| 30 | + await permissionStore.saveGlobalApproval( |
| 31 | + { tool: "run_shell", pattern: "global-only git *" }, |
| 32 | + home, |
| 33 | + ); |
| 34 | + await permissionStore.saveProviderModelApproval( |
| 35 | + "openai:gpt-5", |
| 36 | + { tool: "run_shell", pattern: "provider-only npm *" }, |
| 37 | + home, |
| 38 | + ); |
| 39 | + await permissionStore.saveProjectApproval( |
| 40 | + cwd, |
| 41 | + { tool: "run_shell", pattern: "project keep *" }, |
| 42 | + home, |
| 43 | + ); |
| 44 | + await permissionStore.saveProjectApproval( |
| 45 | + cwd, |
| 46 | + { tool: "run_shell", pattern: "project drop *" }, |
| 47 | + home, |
| 48 | + ); |
| 49 | + const permissionsPath = join(cwd, "grants.json"); |
| 50 | + await writeFile( |
| 51 | + permissionsPath, |
| 52 | + JSON.stringify({ |
| 53 | + approvals: [ |
| 54 | + { tool: "run_shell", pattern: "bun install*" }, |
| 55 | + { |
| 56 | + tool: "run_shell", |
| 57 | + pattern: "scoped cargo *", |
| 58 | + providerModel: "openai:gpt-5", |
| 59 | + }, |
| 60 | + ], |
| 61 | + }), |
| 62 | + ); |
| 63 | + const userStorePath = join(home, SETTINGS_DIR_NAME, "permissions.json"); |
| 64 | + const userStoreBefore = await readFile(userStorePath, "utf-8"); |
| 65 | + |
| 66 | + const seeded = await loadSeededApprovals(cwd, sessionId, home, { |
| 67 | + permissionsPath, |
| 68 | + }); |
| 69 | + const gate = createPermissionGate({ |
| 70 | + approvals: seeded, |
| 71 | + cwd, |
| 72 | + interactive: false, |
| 73 | + skipPermissions: false, |
| 74 | + reactorGated: false, |
| 75 | + }); |
| 76 | + |
| 77 | + // homedir() is cached, so a no-arg reload of the user store would not see |
| 78 | + // this temp home — and a no-arg remove would edit the real user file. |
| 79 | + // Surface either call as the sentinel grant / a throw instead. |
| 80 | + spyOn(permissionStore, "loadGlobalApprovals").mockResolvedValue([ |
| 81 | + { tool: "run_shell", pattern: "global-only git *" }, |
| 82 | + ]); |
| 83 | + spyOn(permissionStore, "loadProviderModelApprovals").mockResolvedValue([ |
| 84 | + { |
| 85 | + tool: "run_shell", |
| 86 | + pattern: "provider-only npm *", |
| 87 | + providerModel: "openai:gpt-5", |
| 88 | + }, |
| 89 | + ]); |
| 90 | + const removeGlobal = spyOn( |
| 91 | + permissionStore, |
| 92 | + "removeGlobalApproval", |
| 93 | + ).mockImplementation(() => { |
| 94 | + throw new Error("user global store must not be mutated"); |
| 95 | + }); |
| 96 | + const removeProvider = spyOn( |
| 97 | + permissionStore, |
| 98 | + "removeProviderModelApproval", |
| 99 | + ).mockImplementation(() => { |
| 100 | + throw new Error("user provider-model store must not be mutated"); |
| 101 | + }); |
| 102 | + |
| 103 | + const admin = createPermissionsAdmin(gate, cwd, { permissionsPath, home }); |
| 104 | + await admin.revoke({ |
| 105 | + scope: "project", |
| 106 | + tool: "run_shell", |
| 107 | + pattern: "project drop *", |
| 108 | + }); |
| 109 | + |
| 110 | + const patterns = gate.getApprovals().map((approval) => approval.pattern); |
| 111 | + expect(patterns).toContain("bun install*"); |
| 112 | + expect(patterns).toContain("scoped cargo *"); |
| 113 | + expect(patterns).toContain("project keep *"); |
| 114 | + expect(patterns).not.toContain("project drop *"); |
| 115 | + expect(patterns).not.toContain("global-only git *"); |
| 116 | + expect(patterns).not.toContain("provider-only npm *"); |
| 117 | + expect(removeGlobal).not.toHaveBeenCalled(); |
| 118 | + expect(removeProvider).not.toHaveBeenCalled(); |
| 119 | + expect(await readFile(userStorePath, "utf-8")).toBe(userStoreBefore); |
| 120 | + |
| 121 | + const listed = await admin.list(); |
| 122 | + const fileRow = listed.find((entry) => entry.pattern === "bun install*"); |
| 123 | + expect(fileRow).toEqual({ |
| 124 | + scope: "global", |
| 125 | + tool: "run_shell", |
| 126 | + pattern: "bun install*", |
| 127 | + }); |
| 128 | + await admin.revoke({ |
| 129 | + scope: "global", |
| 130 | + tool: "run_shell", |
| 131 | + pattern: "bun install*", |
| 132 | + }); |
| 133 | + await admin.revoke({ |
| 134 | + scope: "provider-model", |
| 135 | + tool: "run_shell", |
| 136 | + pattern: "scoped cargo *", |
| 137 | + providerModel: "openai:gpt-5", |
| 138 | + }); |
| 139 | + |
| 140 | + const afterFileRevoke = gate |
| 141 | + .getApprovals() |
| 142 | + .map((approval) => approval.pattern); |
| 143 | + expect(afterFileRevoke).not.toContain("bun install*"); |
| 144 | + expect(afterFileRevoke).not.toContain("scoped cargo *"); |
| 145 | + expect(afterFileRevoke).toContain("project keep *"); |
| 146 | + expect(afterFileRevoke).not.toContain("global-only git *"); |
| 147 | + expect(afterFileRevoke).not.toContain("provider-only npm *"); |
| 148 | + expect(removeGlobal).not.toHaveBeenCalled(); |
| 149 | + expect(removeProvider).not.toHaveBeenCalled(); |
| 150 | + expect(await readFile(userStorePath, "utf-8")).toBe(userStoreBefore); |
| 151 | + |
| 152 | + const fileAfter = JSON.parse(await readFile(permissionsPath, "utf-8")) as { |
| 153 | + approvals: { tool: string; pattern: string }[]; |
| 154 | + providerModels?: unknown; |
| 155 | + }; |
| 156 | + expect(fileAfter.approvals).toEqual([]); |
| 157 | + expect(fileAfter.providerModels).toBeUndefined(); |
| 158 | + |
| 159 | + const reseeded = await loadSeededApprovals(cwd, sessionId, home, { |
| 160 | + permissionsPath, |
| 161 | + }); |
| 162 | + const reseededPatterns = reseeded.map((approval) => approval.pattern); |
| 163 | + expect(reseededPatterns).not.toContain("bun install*"); |
| 164 | + expect(reseededPatterns).not.toContain("scoped cargo *"); |
| 165 | + expect(reseededPatterns).toContain("project keep *"); |
| 166 | + expect(reseededPatterns).not.toContain("global-only git *"); |
| 167 | + }); |
| 168 | +}); |
0 commit comments