Correct the skill_used allowlist rationale to reportable-by-name

user-invocable false opts out of slash synthesis, not name reporting: seven flagged skills stay allowlisted as use_skill recipes; only the four bake-only background skills are excluded.

Author: TheGreatAxios

docs/TELEMETRY.md

@@ -76,14 +76,19 @@ share of prompts driven by MCP stays visible without the server key coming
 with it. `agent_name` on `subagent_*` is the same pattern: first-party
 director ids from `DIRECTOR_IDS` (and the legacy `worker` alias) are reported
 by id; project-defined or marketplace profile ids become `custom`.
-`skill_used` carries `skill_name`: a user-invocable first-party skill name
-from the closed `corbits-skills` allowlist (`ast-grep`, `create-issue`,
+`skill_used` carries `skill_name`: a first-party skill name reportable by
+name from the closed `corbits-skills` allowlist (`ast-grep`, `create-issue`,
 `git-rebase`, `git-worktrees`, `implement`, `interview`,
 `linear-issue-workflow`, `opsh`, `philosophy`, `plan`,
 `pull-request-review`, `refactor`, `review`, `scribe`, `style`,
-`typescript`), or `custom` for anything else. Bundled skills marked
-`user-invocable: false` (`native-integration`, `native-runtime`, `ponytail`,
-`idiot-proof`) are excluded from the allowlist by design. Unknown,
+`typescript`), or `custom` for anything else. `user-invocable: false` opts a
+skill out of slash synthesis, not out of name reporting: eleven bundled
+skills carry the flag, and seven of them (`git-rebase`, `git-worktrees`,
+`linear-issue-workflow`, `opsh`, `philosophy`, `style`, `typescript`)
+remain real `use_skill` recipes, so they stay on the allowlist — the names
+are ours either way. Excluded are the four bake-only background skills
+(`idiot-proof`, `native-integration`, `native-runtime`, `ponytail`), which
+are baked into agent prompts rather than invoked as skills. Unknown,
 project-local, and plugin-authored skill names are never transmitted —
 `skill_name` is the only identifying-adjacent property the event can carry.
 `plugin_loaded` goes further: there is no first-party list of plugins to

src/telemetry/classify.ts

@@ -71,15 +71,19 @@ const BUILT_IN_AGENT_NAMES: ReadonlySet<string> = new Set([
   "worker",
 ]);
 
-// User-invocable first-party skills shipped by the bundled `corbits-skills`
-// plugin (plugins/corbits-skills/skills). The manifest carries only the plugin
-// id and kind — no skill list — so the closed set is spelled out here and
-// pinned by tests/unit/telemetry-product-events.test.ts. Bundled skills marked
-// `user-invocable: false` (native-integration, native-runtime, ponytail,
-// idiot-proof) are deliberately excluded — they are baked into agent prompts
-// rather than user-invoked — so the set covers only the user-invocable
-// first-party skills. Project- or plugin-authored skills are never reported by
-// name.
+// First-party skills reportable by name: the bundled `corbits-skills`
+// skills (plugins/corbits-skills/skills) whose names we ship ourselves, so
+// reporting one cannot identify the operator. The manifest carries only the
+// plugin id and kind — no skill list — so the closed set is spelled out here
+// and pinned by tests/unit/telemetry-product-events.test.ts.
+// `user-invocable: false` is a slash-surface flag, not a telemetry flag:
+// eleven bundled skills carry it, and seven of them (git-rebase,
+// git-worktrees, linear-issue-workflow, opsh, philosophy, style, typescript)
+// opt out of slash synthesis yet remain real `use_skill` recipes, so they
+// stay reportable by name. Excluded are the four bake-only background skills
+// (idiot-proof, native-integration, native-runtime, ponytail), which are
+// baked into agent prompts rather than invoked as skills. Project- or
+// plugin-authored skills are never reported by name.
 const FIRST_PARTY_SKILL_NAMES: ReadonlySet<string> = new Set([
   "ast-grep",
   "create-issue",

tests/unit/telemetry-product-events.test.ts

@@ -244,6 +244,11 @@ test("first-party skill names are reported by name; everything else stays custom
   expect(classifySkillName("acme-internal-deploy")).toBe("custom");
   // Bundled catalog skills outside the closed allowlist are not reported by
   // name either — the allowlist is the closed set, not the skills directory.
+  // All four bake-only background skills (user-invocable: false, baked into
+  // agent prompts rather than invoked as skills) stay custom, while the
+  // seven flagged-but-allowlisted use_skill-only recipes assert by name above.
+  expect(classifySkillName("idiot-proof")).toBe("custom");
+  expect(classifySkillName("native-integration")).toBe("custom");
   expect(classifySkillName("native-runtime")).toBe("custom");
   expect(classifySkillName("ponytail")).toBe("custom");
   expect(classifySkillName("Review")).toBe("custom");