Skip to content

Commit 9f37404

Browse files
Correct flagged-skill reporting split in TELEMETRY (#1004)
* docs(telemetry): correct flagged-skill reporting split Eight listed/loadable, git-worktrees explicit-only, two bake-only; seven reported, four custom. Part of CL-7931. * docs(telemetry): sync skill taxonomy comment with reporting split The allowlist comment still described four bake-only background skills while TELEMETRY documents native-integration and ponytail as listed and loadable.
1 parent 67b6305 commit 9f37404

2 files changed

Lines changed: 14 additions & 13 deletions

File tree

‎docs/TELEMETRY.md‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -83,12 +83,12 @@ name from the closed `corbits-skills` allowlist (`ast-grep`, `create-issue`,
8383
`pull-request-review`, `refactor`, `review`, `scribe`, `style`,
8484
`typescript`), or `custom` for anything else. `user-invocable: false` opts a
8585
skill out of slash synthesis, not out of name reporting: eleven bundled
86-
skills carry the flag, and seven of them (`git-rebase`, `git-worktrees`,
87-
`linear-issue-workflow`, `opsh`, `philosophy`, `style`, `typescript`)
88-
remain real `use_skill` recipes, so they stay on the allowlist — the names
89-
are ours either way. Excluded are the four bake-only background skills
90-
(`idiot-proof`, `native-integration`, `native-runtime`, `ponytail`), which
91-
are baked into agent prompts rather than invoked as skills. Unknown,
86+
skills carry the flag — eight stay listed and loadable (`git-rebase`,
87+
`linear-issue-workflow`, `opsh`, `philosophy`, `style`, `typescript`,
88+
`native-integration`, `ponytail`), `git-worktrees` resolves by explicit name
89+
only, and two stay hidden bake-only (`idiot-proof`, `native-runtime`). Of
90+
the eleven, seven are reported by name and four stay `custom` (pinned;
91+
conservative under-reporting, never a leak). Unknown,
9292
project-local, and plugin-authored skill names are never transmitted —
9393
`skill_name` is the only identifying-adjacent property the event can carry.
9494
`plugin_loaded` goes further: there is no first-party list of plugins to

‎src/telemetry/classify.ts‎

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,14 @@ const BUILT_IN_AGENT_NAMES: ReadonlySet<string> = new Set([
7777
// plugin id and kind — no skill list — so the closed set is spelled out here
7878
// and pinned by tests/unit/telemetry-product-events.test.ts.
7979
// `user-invocable: false` is a slash-surface flag, not a telemetry flag:
80-
// eleven bundled skills carry it, and seven of them (git-rebase,
81-
// git-worktrees, linear-issue-workflow, opsh, philosophy, style, typescript)
82-
// opt out of slash synthesis yet remain real `use_skill` recipes, so they
83-
// stay reportable by name. Excluded are the four bake-only background skills
84-
// (idiot-proof, native-integration, native-runtime, ponytail), which are
85-
// baked into agent prompts rather than invoked as skills. Project- or
86-
// plugin-authored skills are never reported by name.
80+
// eleven bundled skills carry it — eight stay listed and loadable
81+
// (git-rebase, linear-issue-workflow, opsh, philosophy, style, typescript,
82+
// native-integration, ponytail), `git-worktrees` resolves by explicit name
83+
// only, and two stay hidden bake-only (idiot-proof, native-runtime), which
84+
// are baked into agent prompts rather than invoked as skills. Of the eleven,
85+
// seven are reported by name and four stay `custom` (pinned; conservative
86+
// under-reporting, never a leak). Project- or plugin-authored skills are
87+
// never reported by name.
8788
const FIRST_PARTY_SKILL_NAMES: ReadonlySet<string> = new Set([
8889
"ast-grep",
8990
"create-issue",

0 commit comments

Comments
 (0)